Re: [PATCH v3 1/6] histograms: Initial histograms interface

[Stevie Alvarez <stevie.6strings@gmail.com>]

On Tue, Aug 08, 2023 at 03:35:47PM -0400, Steven Rostedt wrote:
> On Tue,  8 Aug 2023 12:11:54 -0400
> Stevie Alvarez <stevie.6strings@gmail.com> wrote:
> 
> > +/*
> > + * Trace data entry for a traceeval histogram
> > + * Constitutes keys and values.
> > + */
> > +union traceeval_data {
> > +	char				*string;
> 
> We need to also add:
> 
> 	const char			*cstring;
> 
> At least for the user interface, as I'm converting task-eval over to this,
> and I need to assign const strings to this union.

I assume I should treat cstring the same as string, execept because it's
constant, it should not be updated on insertion, correct?

-- Stevie
> 
> -- Steve
> 
> > +	struct traceeval_dynamic	*dyn_data;
> > +	unsigned long long		number_64;
> > +	unsigned long			number;
> > +	unsigned int			number_32;
> > +	unsigned short			number_16;
> > +	unsigned char			number_8;
> > +};
> > +