From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Florent Revest <revest@chromium.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf <bpf@vger.kernel.org>, Sven Schnelle <svens@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alan Maguire <alan.maguire@oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs
Date: Tue, 8 Aug 2023 23:53:46 +0900 [thread overview]
Message-ID: <20230808235346.fdd76875c71f0806773fad74@kernel.org> (raw)
In-Reply-To: <CABRcYmLYyohzVBzg-maoAwaFwj6VanWiAiv5GQnpagn2-ZDoRQ@mail.gmail.com>
On Tue, 8 Aug 2023 16:29:27 +0200
Florent Revest <revest@chromium.org> wrote:
> On Mon, Aug 7, 2023 at 8:48 AM Masami Hiramatsu (Google)
> <mhiramat@kernel.org> wrote:
> >
> > Florent, feel free to add your rethook for arm64, but please do not remove
> > kretprobe trampoline yet. It is another discussion point. We may be possible
> > to use ftrace_regs for kretprobe by ftrace_partial_regs() but kretprobe
> > allows nest probe. (maybe we can skip that case?)
>
> Ack :)
>
> > arch/Kconfig | 1 +
> > arch/arm64/include/asm/ftrace.h | 11 ++++++
> > arch/loongarch/Kconfig | 1 +
> > arch/s390/Kconfig | 1 +
> > arch/x86/Kconfig | 1 +
> > arch/x86/kernel/rethook.c | 9 +++--
> > include/linux/fprobe.h | 4 +-
> > include/linux/ftrace.h | 56 ++++++++++++++++++-----------
> > include/linux/rethook.h | 11 +++---
> > kernel/kprobes.c | 9 ++++-
> > kernel/trace/Kconfig | 9 ++++-
> > kernel/trace/bpf_trace.c | 14 +++++--
> > kernel/trace/fprobe.c | 8 ++--
> > kernel/trace/rethook.c | 16 ++++----
> > kernel/trace/trace_fprobe.c | 76 ++++++++++++++++++++++++---------------
> > kernel/trace/trace_probe_tmpl.h | 2 +
> > lib/test_fprobe.c | 10 +++--
> > samples/fprobe/fprobe_example.c | 4 +-
>
> I believe that Documentation/trace/fprobe.rst should also be modified
> following the API change
Indeed. Let me update it.
Thanks!
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-08-08 14:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 6:48 [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs Masami Hiramatsu (Google)
2023-08-07 6:48 ` [RFC PATCH v2 1/6] fprobe: Use fprobe_regs in fprobe entry handler Masami Hiramatsu (Google)
2023-08-09 10:28 ` Florent Revest
2023-08-09 14:10 ` Masami Hiramatsu
2023-08-09 16:09 ` Florent Revest
2023-08-09 16:17 ` Florent Revest
2023-08-09 22:13 ` Masami Hiramatsu
2023-08-11 17:10 ` Steven Rostedt
2023-08-07 6:48 ` [RFC PATCH v2 2/6] tracing: Expose ftrace_regs regardless of CONFIG_FUNCTION_TRACER Masami Hiramatsu (Google)
2023-08-09 10:29 ` Florent Revest
2023-08-09 14:16 ` Masami Hiramatsu
2023-08-09 15:53 ` Florent Revest
2023-08-07 6:48 ` [RFC PATCH v2 3/6] fprobe: rethook: Use fprobe_regs in fprobe exit handler and rethook Masami Hiramatsu (Google)
2023-08-09 10:30 ` Florent Revest
2023-08-09 14:43 ` Masami Hiramatsu
2023-08-09 15:45 ` Florent Revest
2023-08-10 0:32 ` Masami Hiramatsu
2023-08-07 6:49 ` [RFC PATCH v2 4/6] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS Masami Hiramatsu (Google)
2023-08-09 10:31 ` Florent Revest
2023-08-09 14:45 ` Masami Hiramatsu
2023-08-09 15:38 ` Florent Revest
2023-08-10 0:38 ` Masami Hiramatsu
2023-08-11 15:57 ` Steven Rostedt
2023-08-07 6:49 ` [RFC PATCH v2 5/6] ftrace: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Masami Hiramatsu (Google)
2023-08-09 10:31 ` Florent Revest
2023-08-09 14:52 ` Masami Hiramatsu
2023-08-07 6:49 ` [RFC PATCH v2 6/6] bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled Masami Hiramatsu (Google)
2023-08-07 22:08 ` Jiri Olsa
2023-08-08 10:20 ` Masami Hiramatsu
2023-08-08 14:29 ` [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs Florent Revest
2023-08-08 14:53 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808235346.fdd76875c71f0806773fad74@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=peterz@infradead.org \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.