From: Greg KH <gregkh@linuxfoundation.org>
To: Alexon Oliveira <alexondunkan@gmail.com>
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: vme_user: fix alignment of open parenthesis and deleted trailing spaces
Date: Tue, 8 Aug 2023 06:33:07 +0200 [thread overview]
Message-ID: <2023080840-passenger-sierra-55ef@gregkh> (raw)
In-Reply-To: <ZNFXMrtqSWvZv+rl@alolivei-thinkpadt480s.gru.csb>
On Mon, Aug 07, 2023 at 05:42:26PM -0300, Alexon Oliveira wrote:
> Fixed all CHECK: Alignment should match open parenthesis
> and deleted the trailing whitespaces as reported by
> checkpatch to adhere to the Linux kernel coding-style
> guidelines.
>
> Signed-off-by: Alexon Oliveira <alexondunkan@gmail.com>
> ---
>
> Changes in v2:
> - Fixed changelog, noted by Greg KH
>
> drivers/staging/vme_user/vme.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> index 977c81e2f3c7..741593d75a63 100644
> --- a/drivers/staging/vme_user/vme.c
> +++ b/drivers/staging/vme_user/vme.c
> @@ -563,7 +563,7 @@ EXPORT_SYMBOL(vme_master_request);
> * returned.
> */
> int vme_master_set(struct vme_resource *resource, int enabled,
> - unsigned long long vme_base, unsigned long long size,
> + unsigned long long vme_base, unsigned long long size,
> u32 aspace, u32 cycle, u32 dwidth)
I think the confusion here is that my tree does NOT look like your tree
at all right now. If I try to apply this patch, I get:
checking file drivers/staging/vme_user/vme.c
Hunk #1 FAILED at 563.
Hunk #2 FAILED at 614.
Hunk #3 FAILED at 1045.
Hunk #4 FAILED at 1841.
4 out of 4 hunks FAILED
So please, rebase your tree against my staging.git on git.kernel.org
tree, the staging-next branch, and then resend the patches from that.
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-08 4:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 20:42 [PATCH v2] staging: vme_user: fix alignment of open parenthesis and deleted trailing spaces Alexon Oliveira
2023-08-08 4:33 ` Greg KH [this message]
2023-08-08 13:05 ` Alexon Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080840-passenger-sierra-55ef@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexondunkan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.