From: Mighty <bavishimithil@gmail.com>
To: linus.walleij@linaro.org
Cc: jic23@kernel.org, lars@metafoo.de, liambeguin@gmail.com,
linux-iio@vger.kernel.org, peda@axentia.se,
stable@vger.kernel.org
Subject: Re: [PATCH] iio: afe: rescale: Fix logic bug
Date: Wed, 9 Aug 2023 19:13:37 +0530 [thread overview]
Message-ID: <20230809134337.28224-1-bavishimithil@gmail.com> (raw)
In-Reply-To: <20220524075448.140238-1-linus.walleij@linaro.org>
> The current code "mostly works" because we have not run into
> systems supporting only raw but not scale or only scale but not
> raw, and I doubt there are few using the rescaler on anything
> such, but let's fix the logic.
This does break the logic for twl6030/6032 boards as the seem to only have only raw and processed masks[1]. What would a probable solution for it be, to modify the twl gpadc to include scale+raw or just revert back to the OR?
[1] https://github.com/torvalds/linux/blob/master/drivers/iio/adc/twl6030-gpadc.c#L808-L840
Mithil
next prev parent reply other threads:[~2023-08-09 13:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:54 [PATCH] iio: afe: rescale: Fix logic bug Linus Walleij
2022-05-25 14:08 ` Peter Rosin
2022-05-26 1:29 ` Liam Beguin
2022-05-28 17:01 ` Jonathan Cameron
2023-08-09 13:43 ` Mighty [this message]
2023-08-10 8:56 ` Linus Walleij
2023-08-21 16:45 ` Mighty
2023-08-23 8:21 ` Linus Walleij
2023-08-24 7:39 ` Mighty
2023-08-24 8:24 ` Linus Walleij
2023-08-24 8:28 ` Linus Walleij
2023-08-28 18:18 ` Jonathan Cameron
2023-08-29 7:17 ` Linus Walleij
2023-08-29 11:37 ` Jonathan Cameron
2023-09-03 17:10 ` Mighty
2023-09-04 7:20 ` Linus Walleij
2023-09-03 18:04 ` Mighty
2023-09-04 7:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809134337.28224-1-bavishimithil@gmail.com \
--to=bavishimithil@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=peda@axentia.se \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.