All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: <sgoutham@marvell.com>, <gakula@marvell.com>,
	<sbhatta@marvell.com>, <hkelam@marvell.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lcherian@marvell.com>, <jerinj@marvell.com>
Subject: Re: [net PATCH V2 1/4] octeontx2-pf: Update PFC configuration
Date: Wed, 9 Aug 2023 16:05:17 -0700	[thread overview]
Message-ID: <20230809160517.7ff84c3b@kernel.org> (raw)
In-Reply-To: <20230809070532.3252464-2-sumang@marvell.com>

On Wed, 9 Aug 2023 12:35:29 +0530 Suman Ghosh wrote:
> +		otx2_stop(dev);
> +		otx2_open(dev);

If there is any error in open() this will silently take the interface
down. Can't you force a NAPI poll or some such, if the concern is a
missed IRQ?
-- 
pw-bot: cr

  reply	other threads:[~2023-08-09 23:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  7:05 [net PATCH V2 0/4] Fix PFC related issues Suman Ghosh
2023-08-09  7:05 ` [net PATCH V2 1/4] octeontx2-pf: Update PFC configuration Suman Ghosh
2023-08-09 23:05   ` Jakub Kicinski [this message]
2023-08-18  6:54     ` [EXT] " Suman Ghosh
2023-08-18 16:00       ` Jakub Kicinski
2023-08-19 10:10         ` Suman Ghosh
2023-08-09  7:05 ` [net PATCH V2 2/4] octeontx2-pf: Fix PFC TX scheduler free Suman Ghosh
2023-08-09  7:05 ` [net PATCH V2 3/4] octeontx2-af: CN10KB: fix PFC configuration Suman Ghosh
2023-08-09  7:05 ` [net PATCH V2 4/4] octeonxt2-pf: Fix backpressure config for multiple PFC priorities to work simultaneously Suman Ghosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809160517.7ff84c3b@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=sumang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.