All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch <hch@lst.de>
To: Richard Weinberger <richard@nod.at>
Cc: hch <hch@lst.de>, Stephan Wurm <stephan.wurm@a-eberle.de>,
	linux-block <linux-block@vger.kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Johannes Eigner <johannes.eigner@a-eberle.de>
Subject: Re: ubiblock: null pointer dereference using scatterlist in work_queue
Date: Thu, 10 Aug 2023 00:37:03 +0200	[thread overview]
Message-ID: <20230809223703.GA10719@lst.de> (raw)
In-Reply-To: <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at>

On Thu, Aug 10, 2023 at 12:34:44AM +0200, Richard Weinberger wrote:
> Will do so! So far I managed to get UBIblock work with scsi_kmap_atomic_sg().
> Sadly now with kmap'ed memory a bounce buffer is needed since IO in UBI/MTD can sleep.
> Is there a strong reason why scsi_kmap_atomic_sg() needs IRQs disabled?

I don't think it needs irqs disabled.  Also if you switch from the
deprecated kmap_atomic to kmap_local first you can sleep and don't
need bounce buffers.


WARNING: multiple messages have this Message-ID (diff)
From: hch <hch@lst.de>
To: Richard Weinberger <richard@nod.at>
Cc: hch <hch@lst.de>, Stephan Wurm <stephan.wurm@a-eberle.de>,
	linux-block <linux-block@vger.kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Johannes Eigner <johannes.eigner@a-eberle.de>
Subject: Re: ubiblock: null pointer dereference using scatterlist in work_queue
Date: Thu, 10 Aug 2023 00:37:03 +0200	[thread overview]
Message-ID: <20230809223703.GA10719@lst.de> (raw)
In-Reply-To: <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at>

On Thu, Aug 10, 2023 at 12:34:44AM +0200, Richard Weinberger wrote:
> Will do so! So far I managed to get UBIblock work with scsi_kmap_atomic_sg().
> Sadly now with kmap'ed memory a bounce buffer is needed since IO in UBI/MTD can sleep.
> Is there a strong reason why scsi_kmap_atomic_sg() needs IRQs disabled?

I don't think it needs irqs disabled.  Also if you switch from the
deprecated kmap_atomic to kmap_local first you can sleep and don't
need bounce buffers.


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-08-09 22:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17  8:07 ubiblock: null pointer dereference using scatterlist in work_queue Stephan Wurm
2023-07-17  8:07 ` Stephan Wurm
2023-07-17  9:42 ` Richard Weinberger
2023-07-17  9:42   ` Richard Weinberger
2023-07-17 10:27   ` Stephan Wurm
2023-07-17 10:27     ` Stephan Wurm
2023-07-17 11:03     ` Richard Weinberger
2023-07-17 11:03       ` Richard Weinberger
2023-07-17 14:55       ` Stephan Wurm
2023-07-17 14:55         ` Stephan Wurm
2023-07-17 20:54         ` Richard Weinberger
2023-07-17 20:54           ` Richard Weinberger
2023-07-19 14:31         ` Richard Weinberger
2023-07-19 14:31           ` Richard Weinberger
2023-07-19 14:38           ` Wurm, Stephan
2023-07-19 14:38             ` Wurm, Stephan
2023-07-21  7:41             ` Wurm, Stephan
2023-07-21  7:41               ` Wurm, Stephan
2023-08-07 22:02 ` Richard Weinberger
2023-08-07 22:02   ` Richard Weinberger
2023-08-09 13:53   ` hch
2023-08-09 13:53     ` hch
2023-08-09 14:10     ` Stephan Wurm
2023-08-09 14:10       ` Stephan Wurm
2023-08-09 14:15       ` hch
2023-08-09 14:15         ` hch
2023-08-09 22:34         ` Richard Weinberger
2023-08-09 22:34           ` Richard Weinberger
2023-08-09 22:37           ` hch [this message]
2023-08-09 22:37             ` hch
2023-08-09 22:43             ` Richard Weinberger
2023-08-09 22:43               ` Richard Weinberger
2023-08-10 15:43               ` hch
2023-08-10 15:43                 ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809223703.GA10719@lst.de \
    --to=hch@lst.de \
    --cc=johannes.eigner@a-eberle.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=stephan.wurm@a-eberle.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.