All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Martin Bark <martin@barkynet.com>,
	Julien Grossholtz <julien.grossholtz@openest.io>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'
Date: Thu, 10 Aug 2023 00:10:10 +0200	[thread overview]
Message-ID: <20230810001010.55cc070a@gmx.net> (raw)
In-Reply-To: <20230809001212.0d61539b@windsurf>

Hello Thomas,

On Wed, 9 Aug 2023 00:12:12 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Tue,  8 Aug 2023 20:09:59 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit
> > 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by
> > changing an dtoverlay option wrongly to an extra line (instead of changing
> > to an proper dtparam line), but as no one complained since 2021 just
>
> I'm failing to pase the "changing an dtoverlay option wrongly to an
> extra line (instead of changing to an proper dtparam line)". I'm
> confused by the "to an extra line".
>
> Do you mean that:
>
> dtoverlay=krnbt=on

To be precise the original was (and as documented here [1])

	dtoverlay=miniuart-bt,krnbt=on
>
> should have been:
>
> dtparam=krnbt=on

Yes (as documented here [2])...

Regards,
Peter

[1] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L2371
[2] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L213

>
> ?
>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-09 22:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 18:09 [Buildroot] [PATCH v1] board/raspberrypi/config_4_64bit.txt: remove testing dtoverlay entries (vc4-kms-v3d-pi4, imx219) Peter Seiderer
2023-08-08 18:09 ` [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on' Peter Seiderer
2023-08-08 22:12   ` Thomas Petazzoni via buildroot
2023-08-09 22:10     ` Peter Seiderer [this message]
2023-11-27 18:51 ` [Buildroot] [PATCH v1] board/raspberrypi/config_4_64bit.txt: remove testing dtoverlay entries (vc4-kms-v3d-pi4, imx219) Yann E. MORIN
2023-11-30 22:37   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230810001010.55cc070a@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    --cc=julien.grossholtz@openest.io \
    --cc=martin@barkynet.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.