From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF542C41513 for ; Thu, 10 Aug 2023 08:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbjHJILB (ORCPT ); Thu, 10 Aug 2023 04:11:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbjHJILA (ORCPT ); Thu, 10 Aug 2023 04:11:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E192136; Thu, 10 Aug 2023 01:10:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D3B465236; Thu, 10 Aug 2023 08:10:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D9DC433C7; Thu, 10 Aug 2023 08:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691655043; bh=pPtrMnD+a1HV9tVnWccuGoqbvbAmQI0mFVpSTDqunzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PiJbYP3AfcmvS4dhCAbBYRrSXKLMBY1z9owaOJIubJq7IqLfgJHX0AUitRGtbNmQb nsaudgbmLifGG9ihxAfEP2P5HXlXxCzELDp4l7RS2hV4gcIcZqQ2Vgvlmq7EG+MkcD +VKtJXMK9kFrQAeMUuP3s6zqIhpKIzk+TBDhF5jAjrfplR3mztX+cGThE902/i/nB4 hot3F370IagNSd975t+FVIA71gjEw2m38j56HhBiBpglmC7eSvC8t10U8nhsyP1VjD /od5y8Lrcljrc1VQuZtaqzQZ806yIlGN2xuKi0Ht6VU+PLV08DFJEA0BD5RbMYg/fe f9JGFVMex46EA== Date: Thu, 10 Aug 2023 10:10:40 +0200 From: Andi Shyti To: "Liao, Chang" Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function Message-ID: <20230810081040.xrhaa2beru52hxlu@intel.intel> References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-10-liaochang1@huawei.com> <20230809192117.h7rn6vwmvxdnkr2a@intel.intel> <46a39960-ad79-ca65-6b2b-ccaf982965f5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46a39960-ad79-ca65-6b2b-ccaf982965f5@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Liao, On Thu, Aug 10, 2023 at 10:33:58AM +0800, Liao, Chang wrote: > Hi Andi and Krzysztof, > > 在 2023/8/10 3:21, Andi Shyti 写道: > > Hi Liao, > > > > On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote: > >> Use the dev_err_probe function instead of dev_err in the probe function > >> so that the printed messge includes the return value and also handles > >> -EPROBE_DEFER nicely. > >> > >> Signed-off-by: Liao Chang > > > > After some discussions and time, I think it's right to r-b this > > patch. If you agree more with Krzysztof, feel free to follow his > > recommendation and send another version otherwise I will go ahead > > and take this series in my branch. I do not really mind, both > > arguments are valid. > > I saw that Frank Li developed some new APIs that look like they would be very > helpful for aligning the error messages of devm_request_irq in device probes. > However, the patches have been pending for weeks and the author hasn't sent a > new version. So I'm not planning to switch to the new APIs in this patch series, > if there are no objections. > > Do I need to resend a new revision to add your R-B at this patch? no, no need. I'm also going to fix a typo in the commit message (messge/message) that Markus has pointed out. Thanks for this series of cleanups, Andi > Thanks. > > > > > Reviewed-by: Andi Shyti > > > > Thanks, > > Andi > > -- > BR > Liao, Chang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CB66C001B0 for ; Thu, 10 Aug 2023 08:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ezlCBKe2UKxB8F3f/g/rXDmy6WS/89CAWrJb5kDd4eQ=; b=y1xI+yBEPFAVZS QeVRfEy0FOFcaUMwJo62dP9YWya4uLwNgpJT/VRqj2QhOE8l94GcrTZ3Icefb4WwOsduHl8TeJJsy mU2Bxsjx/omKUCc4xwOdXlLM3pa/N91yCaTIRIlIZpIs4CL+XOWTl7Zc7gioxEbAOc88Sea3se2hM ormQdeZNcxAXQC7cqjiKwN0IttvM8ukRvYBar3NAzYkwI7oGSghyy+VsRCh3tZ4ES5a+cSg0o1qKX JSjA3LSAIcp7/ZdWZ9/MBM6EG/ahVITFf7JdLdhBJ7/jsSY/LiO+L9cd8IgNME9o3Fg5x4eZL4uk0 Y0ziOJIhkoLr2bMez6tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU0kr-006oyr-1H; Thu, 10 Aug 2023 08:10:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU0km-006oxS-34; Thu, 10 Aug 2023 08:10:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 63F8A65235; Thu, 10 Aug 2023 08:10:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D9DC433C7; Thu, 10 Aug 2023 08:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691655043; bh=pPtrMnD+a1HV9tVnWccuGoqbvbAmQI0mFVpSTDqunzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PiJbYP3AfcmvS4dhCAbBYRrSXKLMBY1z9owaOJIubJq7IqLfgJHX0AUitRGtbNmQb nsaudgbmLifGG9ihxAfEP2P5HXlXxCzELDp4l7RS2hV4gcIcZqQ2Vgvlmq7EG+MkcD +VKtJXMK9kFrQAeMUuP3s6zqIhpKIzk+TBDhF5jAjrfplR3mztX+cGThE902/i/nB4 hot3F370IagNSd975t+FVIA71gjEw2m38j56HhBiBpglmC7eSvC8t10U8nhsyP1VjD /od5y8Lrcljrc1VQuZtaqzQZ806yIlGN2xuKi0Ht6VU+PLV08DFJEA0BD5RbMYg/fe f9JGFVMex46EA== Date: Thu, 10 Aug 2023 10:10:40 +0200 From: Andi Shyti To: "Liao, Chang" Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function Message-ID: <20230810081040.xrhaa2beru52hxlu@intel.intel> References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-10-liaochang1@huawei.com> <20230809192117.h7rn6vwmvxdnkr2a@intel.intel> <46a39960-ad79-ca65-6b2b-ccaf982965f5@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <46a39960-ad79-ca65-6b2b-ccaf982965f5@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_011045_031524_831F0F30 X-CRM114-Status: GOOD ( 24.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGlhbywKCk9uIFRodSwgQXVnIDEwLCAyMDIzIGF0IDEwOjMzOjU4QU0gKzA4MDAsIExpYW8s IENoYW5nIHdyb3RlOgo+IEhpIEFuZGkgYW5kIEtyenlzenRvZiwKPiAKPiDlnKggMjAyMy84LzEw IDM6MjEsIEFuZGkgU2h5dGkg5YaZ6YGTOgo+ID4gSGkgTGlhbywKPiA+IAo+ID4gT24gVHVlLCBB dWcgMDgsIDIwMjMgYXQgMDk6Mjk6NTRBTSArMDgwMCwgTGlhbyBDaGFuZyB3cm90ZToKPiA+PiBV c2UgdGhlIGRldl9lcnJfcHJvYmUgZnVuY3Rpb24gaW5zdGVhZCBvZiBkZXZfZXJyIGluIHRoZSBw cm9iZSBmdW5jdGlvbgo+ID4+IHNvIHRoYXQgdGhlIHByaW50ZWQgbWVzc2dlIGluY2x1ZGVzIHRo ZSByZXR1cm4gdmFsdWUgYW5kIGFsc28gaGFuZGxlcwo+ID4+IC1FUFJPQkVfREVGRVIgbmljZWx5 Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTGlhbyBDaGFuZyA8bGlhb2NoYW5nMUBodWF3ZWku Y29tPgo+ID4gCj4gPiBBZnRlciBzb21lIGRpc2N1c3Npb25zIGFuZCB0aW1lLCBJIHRoaW5rIGl0 J3MgcmlnaHQgdG8gci1iIHRoaXMKPiA+IHBhdGNoLiBJZiB5b3UgYWdyZWUgbW9yZSB3aXRoIEty enlzenRvZiwgZmVlbCBmcmVlIHRvIGZvbGxvdyBoaXMKPiA+IHJlY29tbWVuZGF0aW9uIGFuZCBz ZW5kIGFub3RoZXIgdmVyc2lvbiBvdGhlcndpc2UgSSB3aWxsIGdvIGFoZWFkCj4gPiBhbmQgdGFr ZSB0aGlzIHNlcmllcyBpbiBteSBicmFuY2guIEkgZG8gbm90IHJlYWxseSBtaW5kLCBib3RoCj4g PiBhcmd1bWVudHMgYXJlIHZhbGlkLgo+IAo+IEkgc2F3IHRoYXQgRnJhbmsgTGkgZGV2ZWxvcGVk IHNvbWUgbmV3IEFQSXMgdGhhdCBsb29rIGxpa2UgdGhleSB3b3VsZCBiZSB2ZXJ5Cj4gaGVscGZ1 bCBmb3IgYWxpZ25pbmcgdGhlIGVycm9yIG1lc3NhZ2VzIG9mIGRldm1fcmVxdWVzdF9pcnEgaW4g ZGV2aWNlIHByb2Jlcy4KPiBIb3dldmVyLCB0aGUgcGF0Y2hlcyBoYXZlIGJlZW4gcGVuZGluZyBm b3Igd2Vla3MgYW5kIHRoZSBhdXRob3IgaGFzbid0IHNlbnQgYQo+IG5ldyB2ZXJzaW9uLiBTbyBJ J20gbm90IHBsYW5uaW5nIHRvIHN3aXRjaCB0byB0aGUgbmV3IEFQSXMgaW4gdGhpcyBwYXRjaCBz ZXJpZXMsCj4gaWYgdGhlcmUgYXJlIG5vIG9iamVjdGlvbnMuCj4gCj4gRG8gSSBuZWVkIHRvIHJl c2VuZCBhIG5ldyByZXZpc2lvbiB0byBhZGQgeW91ciBSLUIgYXQgdGhpcyBwYXRjaD8KCm5vLCBu byBuZWVkLiBJJ20gYWxzbyBnb2luZyB0byBmaXggYSB0eXBvIGluIHRoZSBjb21taXQgbWVzc2Fn ZQoobWVzc2dlL21lc3NhZ2UpIHRoYXQgTWFya3VzIGhhcyBwb2ludGVkIG91dC4KClRoYW5rcyBm b3IgdGhpcyBzZXJpZXMgb2YgY2xlYW51cHMsCkFuZGkKCj4gVGhhbmtzLgo+IAo+ID4gCj4gPiBS ZXZpZXdlZC1ieTogQW5kaSBTaHl0aSA8YW5kaS5zaHl0aUBrZXJuZWwub3JnPiAKPiA+IAo+ID4g VGhhbmtzLAo+ID4gQW5kaQo+IAo+IC0tIAo+IEJSCj4gTGlhbywgQ2hhbmcKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK