* [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES
@ 2023-08-10 8:07 Stanislaw Gruszka
2023-08-10 14:27 ` Jeffrey Hugo
0 siblings, 1 reply; 5+ messages in thread
From: Stanislaw Gruszka @ 2023-08-10 8:07 UTC (permalink / raw)
To: dri-devel, Jeffrey Hugo; +Cc: Stanislaw Gruszka, Oded Gabbay, Jacek Lawrynowicz
Add comments regarding new DRM_IVPU_PARAM_CAPABILITIES param.
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
include/uapi/drm/ivpu_accel.h | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/include/uapi/drm/ivpu_accel.h b/include/uapi/drm/ivpu_accel.h
index a58a14c9f222..7d1ecc5bbac3 100644
--- a/include/uapi/drm/ivpu_accel.h
+++ b/include/uapi/drm/ivpu_accel.h
@@ -69,8 +69,21 @@ extern "C" {
#define DRM_IVPU_CONTEXT_PRIORITY_FOCUS 2
#define DRM_IVPU_CONTEXT_PRIORITY_REALTIME 3
-#define DRM_IVPU_CAP_METRIC_STREAMER 1
-#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
+/**
+ * DRM_IVPU_CAP_METRIC_STREAMER
+ *
+ * Metric streamer support, provides sampling of various hardware
+ * performance metrics (like DMA bandwidth, cache miss/hits),
+ * can be used for profiling.
+ */
+#define DRM_IVPU_CAP_METRIC_STREAMER 1
+/**
+ * DRM_IVPU_CAP_DMA_MEMORY_RANGE
+ *
+ * Driver has capability to allocate separate memory range
+ * accessible by hardware DMA.
+ */
+#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
/**
* struct drm_ivpu_param - Get/Set VPU parameters
@@ -123,6 +136,8 @@ struct drm_ivpu_param {
* %DRM_IVPU_PARAM_SKU:
* VPU SKU ID (read-only)
*
+ * %DRM_IVPU_PARAM_CAPABILITIES:
+ * Supported capabilities (read-only)
*/
__u32 param;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES
2023-08-10 8:07 [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES Stanislaw Gruszka
@ 2023-08-10 14:27 ` Jeffrey Hugo
2023-08-10 14:32 ` Stanislaw Gruszka
0 siblings, 1 reply; 5+ messages in thread
From: Jeffrey Hugo @ 2023-08-10 14:27 UTC (permalink / raw)
To: Stanislaw Gruszka, dri-devel; +Cc: Oded Gabbay, Jacek Lawrynowicz
On 8/10/2023 2:07 AM, Stanislaw Gruszka wrote:
> Add comments regarding new DRM_IVPU_PARAM_CAPABILITIES param.
>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> ---
> include/uapi/drm/ivpu_accel.h | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/drm/ivpu_accel.h b/include/uapi/drm/ivpu_accel.h
> index a58a14c9f222..7d1ecc5bbac3 100644
> --- a/include/uapi/drm/ivpu_accel.h
> +++ b/include/uapi/drm/ivpu_accel.h
> @@ -69,8 +69,21 @@ extern "C" {
> #define DRM_IVPU_CONTEXT_PRIORITY_FOCUS 2
> #define DRM_IVPU_CONTEXT_PRIORITY_REALTIME 3
>
> -#define DRM_IVPU_CAP_METRIC_STREAMER 1
> -#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
> +/**
> + * DRM_IVPU_CAP_METRIC_STREAMER
> + *
> + * Metric streamer support, provides sampling of various hardware
> + * performance metrics (like DMA bandwidth, cache miss/hits),
> + * can be used for profiling.
Feels like this is a run-on sentence. I think this reads better -
Metric streamer support. Provides sampling of various hardware
performance metrics like DMA bandwidth and cache miss/hits. Can be used
for profiling.
What do you think?
> + */
> +#define DRM_IVPU_CAP_METRIC_STREAMER 1
> +/**
> + * DRM_IVPU_CAP_DMA_MEMORY_RANGE
> + *
> + * Driver has capability to allocate separate memory range
> + * accessible by hardware DMA.
> + */
> +#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
>
> /**
> * struct drm_ivpu_param - Get/Set VPU parameters
> @@ -123,6 +136,8 @@ struct drm_ivpu_param {
> * %DRM_IVPU_PARAM_SKU:
> * VPU SKU ID (read-only)
> *
> + * %DRM_IVPU_PARAM_CAPABILITIES:
> + * Supported capabilities (read-only)
> */
> __u32 param;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES
2023-08-10 14:27 ` Jeffrey Hugo
@ 2023-08-10 14:32 ` Stanislaw Gruszka
2023-08-10 14:49 ` Jeffrey Hugo
0 siblings, 1 reply; 5+ messages in thread
From: Stanislaw Gruszka @ 2023-08-10 14:32 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: Oded Gabbay, Jacek Lawrynowicz, dri-devel
On Thu, Aug 10, 2023 at 08:27:08AM -0600, Jeffrey Hugo wrote:
> On 8/10/2023 2:07 AM, Stanislaw Gruszka wrote:
> > Add comments regarding new DRM_IVPU_PARAM_CAPABILITIES param.
> >
> > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > ---
> > include/uapi/drm/ivpu_accel.h | 19 +++++++++++++++++--
> > 1 file changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/uapi/drm/ivpu_accel.h b/include/uapi/drm/ivpu_accel.h
> > index a58a14c9f222..7d1ecc5bbac3 100644
> > --- a/include/uapi/drm/ivpu_accel.h
> > +++ b/include/uapi/drm/ivpu_accel.h
> > @@ -69,8 +69,21 @@ extern "C" {
> > #define DRM_IVPU_CONTEXT_PRIORITY_FOCUS 2
> > #define DRM_IVPU_CONTEXT_PRIORITY_REALTIME 3
> > -#define DRM_IVPU_CAP_METRIC_STREAMER 1
> > -#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
> > +/**
> > + * DRM_IVPU_CAP_METRIC_STREAMER
> > + *
> > + * Metric streamer support, provides sampling of various hardware
> > + * performance metrics (like DMA bandwidth, cache miss/hits),
> > + * can be used for profiling.
>
> Feels like this is a run-on sentence. I think this reads better -
>
> Metric streamer support. Provides sampling of various hardware performance
> metrics like DMA bandwidth and cache miss/hits. Can be used for profiling.
>
> What do you think?
Looks better :-)
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES
2023-08-10 14:32 ` Stanislaw Gruszka
@ 2023-08-10 14:49 ` Jeffrey Hugo
2023-08-11 8:52 ` Stanislaw Gruszka
0 siblings, 1 reply; 5+ messages in thread
From: Jeffrey Hugo @ 2023-08-10 14:49 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: Oded Gabbay, Jacek Lawrynowicz, dri-devel
On 8/10/2023 8:32 AM, Stanislaw Gruszka wrote:
> On Thu, Aug 10, 2023 at 08:27:08AM -0600, Jeffrey Hugo wrote:
>> On 8/10/2023 2:07 AM, Stanislaw Gruszka wrote:
>>> Add comments regarding new DRM_IVPU_PARAM_CAPABILITIES param.
>>>
>>> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>>> ---
>>> include/uapi/drm/ivpu_accel.h | 19 +++++++++++++++++--
>>> 1 file changed, 17 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/uapi/drm/ivpu_accel.h b/include/uapi/drm/ivpu_accel.h
>>> index a58a14c9f222..7d1ecc5bbac3 100644
>>> --- a/include/uapi/drm/ivpu_accel.h
>>> +++ b/include/uapi/drm/ivpu_accel.h
>>> @@ -69,8 +69,21 @@ extern "C" {
>>> #define DRM_IVPU_CONTEXT_PRIORITY_FOCUS 2
>>> #define DRM_IVPU_CONTEXT_PRIORITY_REALTIME 3
>>> -#define DRM_IVPU_CAP_METRIC_STREAMER 1
>>> -#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
>>> +/**
>>> + * DRM_IVPU_CAP_METRIC_STREAMER
>>> + *
>>> + * Metric streamer support, provides sampling of various hardware
>>> + * performance metrics (like DMA bandwidth, cache miss/hits),
>>> + * can be used for profiling.
>>
>> Feels like this is a run-on sentence. I think this reads better -
>>
>> Metric streamer support. Provides sampling of various hardware performance
>> metrics like DMA bandwidth and cache miss/hits. Can be used for profiling.
>>
>> What do you think?
>
> Looks better :-)
Ok. I guess with that
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES
2023-08-10 14:49 ` Jeffrey Hugo
@ 2023-08-11 8:52 ` Stanislaw Gruszka
0 siblings, 0 replies; 5+ messages in thread
From: Stanislaw Gruszka @ 2023-08-11 8:52 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: Oded Gabbay, Jacek Lawrynowicz, dri-devel
On Thu, Aug 10, 2023 at 08:49:00AM -0600, Jeffrey Hugo wrote:
> On 8/10/2023 8:32 AM, Stanislaw Gruszka wrote:
> > On Thu, Aug 10, 2023 at 08:27:08AM -0600, Jeffrey Hugo wrote:
> > > On 8/10/2023 2:07 AM, Stanislaw Gruszka wrote:
> > > > Add comments regarding new DRM_IVPU_PARAM_CAPABILITIES param.
> > > >
> > > > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > > > ---
> > > > include/uapi/drm/ivpu_accel.h | 19 +++++++++++++++++--
> > > > 1 file changed, 17 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/include/uapi/drm/ivpu_accel.h b/include/uapi/drm/ivpu_accel.h
> > > > index a58a14c9f222..7d1ecc5bbac3 100644
> > > > --- a/include/uapi/drm/ivpu_accel.h
> > > > +++ b/include/uapi/drm/ivpu_accel.h
> > > > @@ -69,8 +69,21 @@ extern "C" {
> > > > #define DRM_IVPU_CONTEXT_PRIORITY_FOCUS 2
> > > > #define DRM_IVPU_CONTEXT_PRIORITY_REALTIME 3
> > > > -#define DRM_IVPU_CAP_METRIC_STREAMER 1
> > > > -#define DRM_IVPU_CAP_DMA_MEMORY_RANGE 2
> > > > +/**
> > > > + * DRM_IVPU_CAP_METRIC_STREAMER
> > > > + *
> > > > + * Metric streamer support, provides sampling of various hardware
> > > > + * performance metrics (like DMA bandwidth, cache miss/hits),
> > > > + * can be used for profiling.
> > >
> > > Feels like this is a run-on sentence. I think this reads better -
> > >
> > > Metric streamer support. Provides sampling of various hardware performance
> > > metrics like DMA bandwidth and cache miss/hits. Can be used for profiling.
> > >
> > > What do you think?
> >
> > Looks better :-)
>
> Ok. I guess with that
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Thanks, applied to drm-misc-next
Regards
Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-11 8:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-10 8:07 [PATCH] accel/ivpu: Document DRM_IVPU_PARAM_CAPABILITIES Stanislaw Gruszka
2023-08-10 14:27 ` Jeffrey Hugo
2023-08-10 14:32 ` Stanislaw Gruszka
2023-08-10 14:49 ` Jeffrey Hugo
2023-08-11 8:52 ` Stanislaw Gruszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.