From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A8CAC001E0 for ; Thu, 10 Aug 2023 19:41:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B95D383FB4; Thu, 10 Aug 2023 19:41:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B95D383FB4 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hGf3OcNT X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mriNNUJ7WE5v; Thu, 10 Aug 2023 19:41:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4476883F9D; Thu, 10 Aug 2023 19:41:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4476883F9D Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 13059C0071; Thu, 10 Aug 2023 19:41:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id D1E57C0032 for ; Thu, 10 Aug 2023 19:41:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 96DFF409AD for ; Thu, 10 Aug 2023 19:41:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 96DFF409AD Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hGf3OcNT X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N9hWCI3tBjaa for ; Thu, 10 Aug 2023 19:41:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id D62F04071B for ; Thu, 10 Aug 2023 19:41:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D62F04071B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691696491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjLGJi3RZ2FKk2d3ScuHRczD0+DLJgOXpSTBakwEXCY=; b=hGf3OcNTpyuxn9Vj00C+u7E5W6NJXthXoOWqcU1NU0PXxxsuK4uz63sPIo/Pq+P1MWAaJO 8uGFhQXotNbVoOqpZewNhCIivNFVnMs97xmO2Xb7E+34N+scoyXJ0dTLz+WdBUAqD1vnXK wrzc0ObT3VV1nNd6jvAO7f9uBabO/h4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-jNNYcIY-MLSJs7RKzz7BoQ-1; Thu, 10 Aug 2023 15:41:28 -0400 X-MC-Unique: jNNYcIY-MLSJs7RKzz7BoQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fe4bda379fso8355585e9.1 for ; Thu, 10 Aug 2023 12:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691696487; x=1692301287; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SjLGJi3RZ2FKk2d3ScuHRczD0+DLJgOXpSTBakwEXCY=; b=MNCvi1GY7k5tCELyAwolR5wfC/5qC6XydZA/Hd231rPndFvCNeCa3k8gap6rogupN6 Xr+QI88OqfI/AJXElhLp3y0QNxl2GJmK5aoo10YwDtWMCsoYYSxcdBK/QLiO08qHDsZa Hlx9eYQgzawcPOKJMenQoDrQVh6zUP+iTLIWz8uUA6kYHmHTvFa4O4BOvm5QgWQdqClH hPivLzfDwO74KOXvXnkGOqauPn6wjhkhqtmd4i1ZcVZh+y+p+r+B7thKbyuYLjfhEeFP H6bG2rov6ZZY3eF2C/k5Y3W9Xw3DdWsFZJJB/pUjwsTOaE7yN8tK6M9Qp05DQy78LKaa PmjA== X-Gm-Message-State: AOJu0Yx2g+XgFuYHQ9mTEqsGoBfHi1d9zJXahbePBgOKrrnu4qyHCli2 flnSJc2akaOUivW9OlIGJmyCDJ4C3HccfWH0jXy8SPXgjkY/Qc7c+EBfIB6/uMV7Vkxkvz5njb+ FRbvc0QXGoY2DOQFt5rtxb+XzvP3OAfwABgGlBP0BMA== X-Received: by 2002:a1c:f716:0:b0:3fc:92:73d6 with SMTP id v22-20020a1cf716000000b003fc009273d6mr2740464wmh.11.1691696487031; Thu, 10 Aug 2023 12:41:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1U/nfcisU1GAe+gXcGkGEXKKOPDNR8Kh/fdNV5Dl10o59b7VmDZSZgwpMeakhNHq8pJgijA== X-Received: by 2002:a1c:f716:0:b0:3fc:92:73d6 with SMTP id v22-20020a1cf716000000b003fc009273d6mr2740454wmh.11.1691696486695; Thu, 10 Aug 2023 12:41:26 -0700 (PDT) Received: from redhat.com ([2.55.42.146]) by smtp.gmail.com with ESMTPSA id v2-20020a5d6102000000b003141e629cb6sm3022146wrt.101.2023.08.10.12.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 12:41:25 -0700 (PDT) Date: Thu, 10 Aug 2023 15:41:22 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop Message-ID: <20230810153744-mutt-send-email-mst@kernel.org> References: <20230725033506-mutt-send-email-mst@kernel.org> <20230726073453-mutt-send-email-mst@kernel.org> <20230727020930-mutt-send-email-mst@kernel.org> <20230727054300-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: xuanzhuo@linux.alibaba.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Maxime Coquelin , kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBBdWcgMDgsIDIwMjMgYXQgMTA6MzA6NTZBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBNb24sIEp1bCAzMSwgMjAyMyBhdCAyOjMw4oCvUE0gSmFzb24gV2FuZyA8amFzb3dh bmdAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gVGh1LCBKdWwgMjcsIDIwMjMgYXQgNTo0 NuKAr1BNIE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPgo+ ID4gPiBPbiBUaHUsIEp1bCAyNywgMjAyMyBhdCAwNDo1OTozM1BNICswODAwLCBKYXNvbiBXYW5n IHdyb3RlOgo+ID4gPiA+ID4gVGhleSByZWFsbHkgc2hvdWxkbid0IC0gYW55IE5JQyB0aGF0IHRh a2VzIGZvcmV2ZXIgdG8KPiA+ID4gPiA+IHByb2dyYW0gd2lsbCBjcmVhdGUgaXNzdWVzIGluIHRo ZSBuZXR3b3JraW5nIHN0YWNrLgo+ID4gPiA+Cj4gPiA+ID4gVW5mb3J0dW5hdGVseSwgaXQncyBu b3QgcmFyZSBhcyB0aGUgZGV2aWNlL2N2cSBjb3VsZCBiZSBpbXBsZW1lbnRlZAo+ID4gPiA+IHZp YSBmaXJtd2FyZSBvciBzb2Z0d2FyZS4KPiA+ID4KPiA+ID4gQ3VycmVudGx5IHRoYXQgbWVhbiBv bmUgZWl0aGVyIGhhcyBzYW5lIGZpcm13YXJlIHdpdGggYSBzY2hlZHVsZXIgdGhhdAo+ID4gPiBj YW4gbWVldCBkZWFkbGluZXMsIG9yIGxvc2VzIGFiaWxpdHkgdG8gcmVwb3J0IGVycm9ycyBiYWNr Lgo+ID4gPgo+ID4gPiA+ID4gQnV0IGlmIHRoZXkgZG8gdGhleSBjYW4gYWx3YXlzIHNldCB0aGlz IGZsYWcgdG9vLgo+ID4gPiA+Cj4gPiA+ID4gVGhpcyBtYXkgaGF2ZSBmYWxzZSBuZWdhdGl2ZXMg YW5kIG1heSBjb25mdXNlIHRoZSBtYW5hZ2VtZW50Lgo+ID4gPiA+Cj4gPiA+ID4gTWF5YmUgd2Ug Y2FuIGV4dGVuZCB0aGUgbmV0d29ya2luZyBjb3JlIHRvIGFsbG93IHNvbWUgZGV2aWNlIHNwZWNp ZmljCj4gPiA+ID4gY29uZmlndXJhdGlvbnMgdG8gYmUgZG9uZSB3aXRoIGRldmljZSBzcGVjaWZp YyBsb2NrIHdpdGhvdXQgcnRubC4gRm9yCj4gPiA+ID4gZXhhbXBsZSwgc3BsaXQgdGhlIHNldF9j aGFubmVscyB0bwo+ID4gPiA+Cj4gPiA+ID4gcHJlX3NldF9jaGFubmVscwo+ID4gPiA+IHNldF9j aGFubmVscwo+ID4gPiA+IHBvc3Rfc2V0X2NoYW5uZWxzCj4gPiA+ID4KPiA+ID4gPiBUaGUgZGV2 aWNlIHNwZWNpZmljIHBhcnQgY291bGQgYmUgZG9uZSBpbiBwcmUgYW5kIHBvc3Qgd2l0aG91dCBh IHJ0bmwgbG9jaz8KPiA+ID4gPgo+ID4gPiA+IFRoYW5rcwo+ID4gPgo+ID4gPgo+ID4gPiBXb3Vs ZCB0aGUgYmVuZWZpdCBiZSB0aGF0IGVycm9ycyBjYW4gYmUgcmVwb3J0ZWQgdG8gdXNlcnNwYWNl IHRoZW4/Cj4gPiA+IFRoZW4gbWF5YmUuICBJIHRoaW5rIHlvdSB3aWxsIGhhdmUgdG8gc2hvdyBo b3cgdGhpcyB3b3JrcyBmb3IgYXQgbGVhc3QKPiA+ID4gb25lIGNhcmQgYmVzaWRlcyB2aXJ0aW8u Cj4gPgo+ID4gRXZlbiBmb3IgdmlydGlvLCB0aGlzIHNlZW1zIG5vdCBlYXN5LCBhcyBlLmcgdGhl Cj4gPiB2aXJ0bmV0X3NlbmRfY29tbWFuZCgpIGFuZCBuZXRpZl9zZXRfcmVhbF9udW1fdHhfcXVl dWVzKCkgbmVlZCB0bwo+ID4gYXBwZWFyIHRvIGJlIGF0b21pYyB0byB0aGUgbmV0d29ya2luZyBj b3JlLgo+ID4KPiA+IEkgd29uZGVyIGlmIHdlIGNhbiByZS1jb25zaWRlciB0aGUgd2F5IG9mIGEg dGltZW91dCBoZXJlIGFuZCBjaG9vc2UgYQo+ID4gc2FuZSB2YWx1ZSBhcyBhIHN0YXJ0Lgo+IAo+ IE1pY2hhZWwsIGFueSBtb3JlIGlucHV0IG9uIHRoaXM/Cj4gCj4gVGhhbmtzCgpJIHRoaW5rIHRo aXMgaXMganVzdCBtaXNzaW9uIGNyZWVwLiBXZSBhcmUgdHJ5aW5nIHRvIGZpeAp2ZHVzZSAtIGxl dCdzIGRvIHRoYXQgZm9yIHN0YXJ0ZXJzLgoKUmVjb3ZlcmluZyBmcm9tIGZpcm13YXJlIHRpbWVv dXRzIGlzIGZhciBmcm9tIHRyaXZpYWwgYW5kCmp1c3QgYXNzdW1pbmcgdGhhdCBqdXN0IGJlY2F1 c2UgaXQgdGltZWQgb3V0IGl0IHdpbGwgbm90CmFjY2VzcyBtZW1vcnkgaXMganVzdCBhcyBsaWtl bHkgdG8gY2F1c2UgbWVtb3J5IGNvcnJ1cHRpb24Kd2l0aCB3b3JzZSByZXN1bHRzIHRoYW4gYW4g aW5maW5pdGUgc3Bpbi4KCkkgcHJvcG9zZSB3ZSBmaXggdGhpcyBmb3IgdmR1c2UgYW5kIGFzc3Vt ZSBoYXJkd2FyZS9maXJtd2FyZQppcyB3ZWxsIGJlaGF2ZWQuIE9yIG1heWJlIG5vdCB3ZWxsIGJl aGF2ZWQgZmlybXdhcmUgd2lsbApzZXQgdGhlIGZsYWcgbG9zaW5nIGVycm9yIHJlcG9ydGluZyBh YmlsaXR5LgoKCgo+ID4KPiA+IFRoYW5rcwo+ID4KPiA+ID4KPiA+ID4KPiA+ID4gLS0KPiA+ID4g TVNUCj4gPiA+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgt Zm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4v bGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F010DC001DE for ; Thu, 10 Aug 2023 19:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234851AbjHJTmP (ORCPT ); Thu, 10 Aug 2023 15:42:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233628AbjHJTmN (ORCPT ); Thu, 10 Aug 2023 15:42:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88AF62683 for ; Thu, 10 Aug 2023 12:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691696489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjLGJi3RZ2FKk2d3ScuHRczD0+DLJgOXpSTBakwEXCY=; b=dBDuvIuu+iUiZG1HCd0jLUbNaO7+syj7wHDzQUyNPbZOyjDKsrntUMFdVPYeyyFgm7V8ge w/2ifS0GbWtwdSXqgqD+LSd6IxEhJKfzyYIGxFi1a4zzvIaagpSBpoQ8Tj+e/C25GnD7cP TdYxjHNEEJ8Ooj7S0kOYfaTOdbgODUw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-nvRUW8YAMHqoZP4hiCnG0Q-1; Thu, 10 Aug 2023 15:41:28 -0400 X-MC-Unique: nvRUW8YAMHqoZP4hiCnG0Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fe19cf2796so8400285e9.0 for ; Thu, 10 Aug 2023 12:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691696487; x=1692301287; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SjLGJi3RZ2FKk2d3ScuHRczD0+DLJgOXpSTBakwEXCY=; b=PjXE0U1pjMuh9P+mRD86ogMgDalJlZPHEcpMpYSV11jtq1T2cDJ03+7OwgEey1BCY7 23z8mq/GDFb5a5Gzru0KHzJ6cijkJKFjuf3YT9DOM3XCVnlkHloOcfH2ld1vsBTsMIb8 DkZ5IwU6kaAX0Va4nFkNcJ0Jmki03D7j56+o8LeF/haZ5gUfunwyOipXNR7/7gKSA0zp r84QM/uwm1png/aKLdpb8OilWBfVm8OwZVW2x2b5ZjGaK9zB4kP+E3M01nSwBsO4L7Hl Ti9rTAw33nc6oHXmCpdu2Vj+RrhaMpWL87A3rfRFcJTJtEmB/9+VgeNLWNCWWycqdO98 6Rtg== X-Gm-Message-State: AOJu0YwnEQYrC+kV7xTYSIq3xkMPmY3gk+1+h5gyuOAIrYKf96Te6eyk d9dzLO+692G0Z5XVyRYXqzdoDr4ZhbQ7CHwpcvNKk8mSOWgq9nmgKY8CQDPhC292oM4BXERGJC9 9v7+VDckuK8jECjzsoMuyaWpP X-Received: by 2002:a1c:f716:0:b0:3fc:92:73d6 with SMTP id v22-20020a1cf716000000b003fc009273d6mr2740465wmh.11.1691696487032; Thu, 10 Aug 2023 12:41:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1U/nfcisU1GAe+gXcGkGEXKKOPDNR8Kh/fdNV5Dl10o59b7VmDZSZgwpMeakhNHq8pJgijA== X-Received: by 2002:a1c:f716:0:b0:3fc:92:73d6 with SMTP id v22-20020a1cf716000000b003fc009273d6mr2740454wmh.11.1691696486695; Thu, 10 Aug 2023 12:41:26 -0700 (PDT) Received: from redhat.com ([2.55.42.146]) by smtp.gmail.com with ESMTPSA id v2-20020a5d6102000000b003141e629cb6sm3022146wrt.101.2023.08.10.12.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 12:41:25 -0700 (PDT) Date: Thu, 10 Aug 2023 15:41:22 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Maxime Coquelin , Shannon Nelson , xuanzhuo@linux.alibaba.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop Message-ID: <20230810153744-mutt-send-email-mst@kernel.org> References: <20230725033506-mutt-send-email-mst@kernel.org> <20230726073453-mutt-send-email-mst@kernel.org> <20230727020930-mutt-send-email-mst@kernel.org> <20230727054300-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 10:30:56AM +0800, Jason Wang wrote: > On Mon, Jul 31, 2023 at 2:30 PM Jason Wang wrote: > > > > On Thu, Jul 27, 2023 at 5:46 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Jul 27, 2023 at 04:59:33PM +0800, Jason Wang wrote: > > > > > They really shouldn't - any NIC that takes forever to > > > > > program will create issues in the networking stack. > > > > > > > > Unfortunately, it's not rare as the device/cvq could be implemented > > > > via firmware or software. > > > > > > Currently that mean one either has sane firmware with a scheduler that > > > can meet deadlines, or loses ability to report errors back. > > > > > > > > But if they do they can always set this flag too. > > > > > > > > This may have false negatives and may confuse the management. > > > > > > > > Maybe we can extend the networking core to allow some device specific > > > > configurations to be done with device specific lock without rtnl. For > > > > example, split the set_channels to > > > > > > > > pre_set_channels > > > > set_channels > > > > post_set_channels > > > > > > > > The device specific part could be done in pre and post without a rtnl lock? > > > > > > > > Thanks > > > > > > > > > Would the benefit be that errors can be reported to userspace then? > > > Then maybe. I think you will have to show how this works for at least > > > one card besides virtio. > > > > Even for virtio, this seems not easy, as e.g the > > virtnet_send_command() and netif_set_real_num_tx_queues() need to > > appear to be atomic to the networking core. > > > > I wonder if we can re-consider the way of a timeout here and choose a > > sane value as a start. > > Michael, any more input on this? > > Thanks I think this is just mission creep. We are trying to fix vduse - let's do that for starters. Recovering from firmware timeouts is far from trivial and just assuming that just because it timed out it will not access memory is just as likely to cause memory corruption with worse results than an infinite spin. I propose we fix this for vduse and assume hardware/firmware is well behaved. Or maybe not well behaved firmware will set the flag losing error reporting ability. > > > > Thanks > > > > > > > > > > > -- > > > MST > > >