From: Jakub Kicinski <kuba@kernel.org>
To: Aaron Conole <aconole@redhat.com>
Cc: Adrian Moreno <amorenoz@redhat.com>,
netdev@vger.kernel.org, i.maximets@ovn.org, eric@garver.life,
dev@openvswitch.org
Subject: Re: [net-next v4 1/7] net: openvswitch: add last-action drop reason
Date: Thu, 10 Aug 2023 16:54:37 -0700 [thread overview]
Message-ID: <20230810165437.0560ade1@kernel.org> (raw)
In-Reply-To: <f7tfs4q22ba.fsf@redhat.com>
On Thu, 10 Aug 2023 14:13:29 -0400 Aaron Conole wrote:
> I think they can be resolved in the same way the mac80211 drops are
> resolved by using (__force u32) to pass the reason argument.
Yup, preferably by creating a helper which takes enum ovs_drop_reason
and does the forcing, rather than annotating each call site, to state
the obvious perhaps.
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-10 23:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:38 [net-next v4 0/7] openvswitch: add drop reasons Adrian Moreno
2023-08-09 15:38 ` [net-next v4 1/7] net: openvswitch: add last-action drop reason Adrian Moreno
2023-08-10 18:13 ` Aaron Conole
2023-08-10 23:54 ` Jakub Kicinski [this message]
2023-08-09 15:38 ` [net-next v4 2/7] net: openvswitch: add action error " Adrian Moreno
2023-08-09 15:38 ` [net-next v4 3/7] net: openvswitch: add explicit drop action Adrian Moreno
2023-08-09 15:38 ` [net-next v4 4/7] net: openvswitch: add meter drop reason Adrian Moreno
2023-08-09 15:38 ` [net-next v4 5/7] net: openvswitch: add misc error drop reasons Adrian Moreno
2023-08-09 15:38 ` [net-next v4 6/7] selftests: openvswitch: add drop reason testcase Adrian Moreno
2023-08-09 15:38 ` [net-next v4 7/7] selftests: openvswitch: add explicit drop testcase Adrian Moreno
2023-08-10 18:05 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810165437.0560ade1@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=amorenoz@redhat.com \
--cc=dev@openvswitch.org \
--cc=eric@garver.life \
--cc=i.maximets@ovn.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.