From: Eric Biggers <ebiggers@kernel.org>
To: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Cc: Jens Axboe <axboe@kernel.dk>, Satya Tangirala <satyat@google.com>,
linux-block@vger.kernel.org, kernel-team@meta.com,
stable@vger.kernel.org
Subject: Re: [PATCH v4] blk-crypto: dynamically allocate fallback profile
Date: Thu, 10 Aug 2023 17:24:57 +0000 [thread overview]
Message-ID: <20230810172457.GC701926@google.com> (raw)
In-Reply-To: <20230810142346.96772-1-sweettea-kernel@dorminy.me>
On Thu, Aug 10, 2023 at 10:21:16AM -0400, Sweet Tea Dorminy wrote:
> + /* Dynamic allocation is needed because of lockdep_register_key(). */
> + blk_crypto_fallback_profile =
> + kzalloc(sizeof(*blk_crypto_fallback_profile), GFP_KERNEL);
> + if (!blk_crypto_fallback_profile)
> goto fail_free_bioset;
err needs to be set to -ENOMEM on failure here. See the suggestion I gave in v1
- Eric
next prev parent reply other threads:[~2023-08-10 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 14:21 [PATCH v4] blk-crypto: dynamically allocate fallback profile Sweet Tea Dorminy
2023-08-10 17:24 ` Eric Biggers [this message]
2023-08-17 14:18 ` Sweet Tea Dorminy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810172457.GC701926@google.com \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=kernel-team@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=satyat@google.com \
--cc=stable@vger.kernel.org \
--cc=sweettea-kernel@dorminy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.