Re: [PATCH v4 0/5] histograms: Fix memory leak, logic bugs, legibility

[Ross Zwisler <zwisler@google.com>]

On Wed, Aug 09, 2023 at 02:30:41PM -0400, Steven Rostedt wrote:
> On Wed,  9 Aug 2023 13:53:33 -0400
> Stevie Alvarez <stevie.6strings@gmail.com> wrote:
> 
> > From: Stevie Alvarez (Google) <stevie.6strings@gmail.com>
> > 
> > Changes in v4:
> >  * Reorder enum traceeval_data_type numeric types for algorithmic access.
> >  * Reorder union traceeval_data numeric fields for legibility.
> >  * Remove parenthesis from function name in kerneldocs.
> >  * Optimize logic in type_alloc().
> >  * Distinguish internal vs public interfaces within include statements.
> >  * Rework copy_traceeval_data() logic for legibility.
> >  * Rework comparator return types to fix query and insert bugs.
> >  * update_entry() frees the entries old values to avoid a memory leak.
> > 
> > Steven, I didn't get around to adding in the cstring field to
> > traceeval_data, as I wasn't able to completely grasp what you were
> > looking for. My apologies.
> 
> Thanks Stevie!
> 
> I'm going to pull these in as-is and build on top of them for the rest so
> that you can work on other things. I'll still do a review of these patches
> for your own understanding, but you don't need to send another series.

Thanks for these, Stevie.  You've addressed all of my review comments, so
Steven, feel free to add:

Reviewed-by: Ross Zwisler <zwisler@google.com>

when you apply the series.