From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org
Subject: Re: [usb:usb-testing 36/37] drivers/usb/core/usb.c:648:18: warning: variable 'root_hub' set but not used
Date: Thu, 10 Aug 2023 21:03:05 +0200 [thread overview]
Message-ID: <2023081032-launch-unrigged-2a4b@gregkh> (raw)
In-Reply-To: <d814a834-de95-486b-9c97-2a4f673700f4@rowland.harvard.edu>
On Wed, Aug 09, 2023 at 11:35:04AM -0400, Alan Stern wrote:
> On Wed, Aug 09, 2023 at 11:11:29PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > head: f176638af476c6d46257cc3303f5c7cf47d5967d
> > commit: 1e4c574225cc5a0553115e5eb5787d1474db5b0f [36/37] USB: Remove remnants of Wireless USB and UWB
> > config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230809/202308092350.HR4PVHUt-lkp@intel.com/config)
> > compiler: loongarch64-linux-gcc (GCC) 12.3.0
> > reproduce: (https://download.01.org/0day-ci/archive/20230809/202308092350.HR4PVHUt-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202308092350.HR4PVHUt-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/usb/core/usb.c: In function 'usb_alloc_dev':
> > >> drivers/usb/core/usb.c:648:18: warning: variable 'root_hub' set but not used [-Wunused-but-set-variable]
> > 648 | unsigned root_hub = 0;
> > | ^~~~~~~~
>
> Odd. I'm quite sure that I built this with no problems. [Does some
> checking...] Aha! When I built it, I didn't use W=1.
>
> Greg, would you prefer a new version of this patch or a separate
> correction patch?
A new version, let me go drop the three patches from you for this as you
found a different issue on the first one already. Just resend a new
series please.
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-10 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:11 [usb:usb-testing 36/37] drivers/usb/core/usb.c:648:18: warning: variable 'root_hub' set but not used kernel test robot
2023-08-09 15:35 ` Alan Stern
2023-08-10 19:03 ` Greg KH [this message]
2023-08-10 19:04 ` Greg KH
2023-08-11 15:47 ` [PATCH] USB: core: Fix unused variable warning in usb_alloc_dev() Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081032-launch-unrigged-2a4b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.