From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB4B1C001DB for ; Fri, 11 Aug 2023 09:48:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5A30581420; Fri, 11 Aug 2023 09:48:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5A30581420 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i6KGhJ1i X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g99Ip8ja39jg; Fri, 11 Aug 2023 09:48:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8DE9381414; Fri, 11 Aug 2023 09:48:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8DE9381414 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 65144C0072; Fri, 11 Aug 2023 09:48:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3BFF6C0032 for ; Fri, 11 Aug 2023 09:48:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0FD4F60BCB for ; Fri, 11 Aug 2023 09:48:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0FD4F60BCB Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i6KGhJ1i X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X1oOG0tmbvHD for ; Fri, 11 Aug 2023 09:48:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 094EC60A93 for ; Fri, 11 Aug 2023 09:48:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 094EC60A93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691747329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fuPwMiCOds871v8o/ogtGSupZ7sHE8svUP10CQtFD/o=; b=i6KGhJ1igbSShxZa6tfwrXxa7Hm3iCDUvHMVw/MAe/4PuIYtMMCJuoPbzrVvej7QXTEn1Y OD5c49ZruDbFozKDN3dVNYYUlNxq3UE0kO0OQfscuhaT0V7BjGvUCsCp9ZAZWkOUssFy2b 2dL5M8AwSYXaemhL1GGlWQlgYkjH6Us= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-B6UWLATvOVWafIKldIFWNA-1; Fri, 11 Aug 2023 05:48:47 -0400 X-MC-Unique: B6UWLATvOVWafIKldIFWNA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f5df65fa35so11443395e9.3 for ; Fri, 11 Aug 2023 02:48:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691747326; x=1692352126; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fuPwMiCOds871v8o/ogtGSupZ7sHE8svUP10CQtFD/o=; b=MONrQmvo4ka9nGXE2Kb/jLxxDg64x0D5lbroynykExjehRF6bmmMkZUwOiPgSzRh4B B71jW+kElMpFdFle6/friQB3UUjeFK0VgeucKDureFO1FQFFKwMG+BbFAdxmlnfX33ZJ ZE43KSe3+neszRUgejcDEGgdOQ71Oy56vn4WMaA0yE0SVA3Ys91WskePls9zcB/M9O7U XOp5Dc1i1aLMViDwI94OGhARP1V9h7E9LT8n5UkAP0fk2s9fRKF8BmiwbzwamT4qNy9J ChCSu2LV0kp5/dGTheC/B3fVzC5Li6AWIRrT69RqGb+G2qsQiGolHgm03HqM8RsbNL8W ug8g== X-Gm-Message-State: AOJu0YwmSgIK25q9k3eSKHDfVZwionNZJRgMOLYWq9rH0uGDn6LOHZ+u tECmFhOPNyjE1jAfgGdvCS4cUGb5SYFEPHqkY4NDo3lzLbo/LtHi4Lbv/S/lea5iPzhbjAcURd2 7TH3tX+zHVwM9ejX8d8YZclTARvFkq/b2QlnCEYf4qA== X-Received: by 2002:a1c:cc12:0:b0:3fa:8db4:91ec with SMTP id h18-20020a1ccc12000000b003fa8db491ecmr1134556wmb.10.1691747326505; Fri, 11 Aug 2023 02:48:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGf9bXPD4yjwvlp8v42lTNJRVWFj4ngnnn3DuWzV+hlTBAZcBoR/XB3/gpHHTV7jqPuGXB0EA== X-Received: by 2002:a1c:cc12:0:b0:3fa:8db4:91ec with SMTP id h18-20020a1ccc12000000b003fa8db491ecmr1134544wmb.10.1691747326177; Fri, 11 Aug 2023 02:48:46 -0700 (PDT) Received: from redhat.com ([2.55.42.146]) by smtp.gmail.com with ESMTPSA id c16-20020a7bc010000000b003fc00212c1esm4709023wmb.28.2023.08.11.02.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 02:48:45 -0700 (PDT) Date: Fri, 11 Aug 2023 05:48:42 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH] virtio_vdpa: build affinity masks conditionally Message-ID: <20230811054736-mutt-send-email-mst@kernel.org> References: <20230811091539.1359865-1-jasowang@redhat.com> <20230811052435-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: xuanzhuo@linux.alibaba.com, xieyongji@bytedance.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gRnJpLCBBdWcgMTEsIDIwMjMgYXQgMDU6NDE6NDRQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBGcmksIEF1ZyAxMSwgMjAyMyBhdCA1OjI14oCvUE0gTWljaGFlbCBTLiBUc2lya2lu IDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gRnJpLCBBdWcgMTEsIDIwMjMgYXQg MDU6MTU6MzlBTSAtMDQwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gV2UgdHJ5IHRvIGJ1aWxk IGFmZmluaXR5IG1hc2sgdmlhIGNyZWF0ZV9hZmZpbml0eV9tYXNrcygpCj4gPiA+IHVuY29uZGl0 aW9uYWxseSB3aGljaCBtYXkgbGVhZCBzZXZlcmFsIGlzc3VlczoKPiA+ID4KPiA+ID4gLSB0aGUg YWZmaW5pdHkgbWFzayBpcyBub3QgdXNlZCBmb3IgcGFyZW50IHdpdGhvdXQgYWZmaW5pdHkgc3Vw cG9ydAo+ID4gPiAgIChvbmx5IFZEVVNFIHN1cHBvcnQgdGhlIGFmZmluaXR5IG5vdykKPiA+ID4g LSB0aGUgbG9naWMgb2YgY3JlYXRlX2FmZmluaXR5X21hc2tzKCkgbWlnaHQgbm90IHdvcmsgZm9y IGRldmljZXMKPiA+ID4gICBvdGhlciB0aGFuIGJsb2NrLiBGb3IgZXhhbXBsZSBpdCdzIG5vdCBy YXJlIGluIHRoZSBuZXR3b3JraW5nIGRldmljZQo+ID4gPiAgIHdoZXJlIHRoZSBudW1iZXIgb2Yg cXVldWVzIGNvdWxkIGV4Y2VlZCB0aGUgbnVtYmVyIG9mIENQVXMuIFN1Y2gKPiA+ID4gICBjYXNl IGJyZWFrcyB0aGUgY3VycmVudCBhZmZpbml0eSBsb2dpYyB3aGljaCBpcyBiYXNlZCBvbgo+ID4g PiAgIGdyb3VwX2NwdXNfZXZlbmx5KCkgd2hvIGFzc3VtZXMgdGhlIG51bWJlciBvZiBDUFVzIGFy ZSBub3QgbGVzcyB0aGFuCj4gPiA+ICAgdGhlIG51bWJlciBvZiBncm91cHMuIFRoaXMgY2FuIHRy aWdnZXIgYSB3YXJuaW5nWzFdOgo+ID4gPgo+ID4gPiAgICAgICBpZiAocmV0ID49IDApCj4gPiA+ ICAgICAgICAgICAgICAgV0FSTl9PTihucl9wcmVzZW50ICsgbnJfb3RoZXJzIDwgbnVtZ3Jwcyk7 Cj4gPiA+Cj4gPiA+IEZpeGluZyB0aGlzIGJ5IG9ubHkgYnVpbGQgdGhlIGFmZmluaXR5IG1hc2tz IG9ubHkgd2hlbgo+ID4gPgo+ID4gPiAtIERyaXZlciBwYXNzZXMgYWZmaW5pdHkgZGVzY3JpcHRv ciwgZHJpdmVyIGxpa2UgdmlydGlvLWJsayBjYW4gbWFrZQo+ID4gPiAgIHN1cmUgdG8gbGltaXQg dGhlIG51bWJlciBvZiBxdWV1ZXMgd2hlbiBpdCBleGNlZWRzIHRoZSBudW1iZXIgb2YgQ1BVcwo+ ID4gPiAtIFBhcmVudCBzdXBwb3J0IGFmZmluaXR5IHNldHRpbmcgY29uZmlnIG9wcwo+ID4gPgo+ ID4gPiBUaGlzIGhlbHAgdG8gYXZvaWQgdGhlIHdhcm5pbmcuIE1vcmUgb3B0aW1pemF0aW9ucyBj b3VsZCBiZSBkb25lIG9uCj4gPiA+IHRvcC4KPiA+ID4KPiA+ID4gWzFdCj4gPiA+IFsgIDY4Mi4x NDY2NTVdIFdBUk5JTkc6IENQVTogNiBQSUQ6IDE1NTAgYXQgbGliL2dyb3VwX2NwdXMuYzo0MDAg Z3JvdXBfY3B1c19ldmVubHkrMHgxYWEvMHgxYzAKPiA+ID4gWyAgNjgyLjE0NjY2OF0gQ1BVOiA2 IFBJRDogMTU1MCBDb21tOiB2ZHBhIE5vdCB0YWludGVkIDYuNS4wLXJjNWphc29uKyAjNzkKPiA+ ID4gWyAgNjgyLjE0NjY3MV0gSGFyZHdhcmUgbmFtZTogUUVNVSBTdGFuZGFyZCBQQyAoaTQ0MEZY ICsgUElJWCwgMTk5NiksIEJJT1MgcmVsLTEuMTYuMi0wLWdlYTFiN2EwNzMzOTAtcHJlYnVpbHQu cWVtdS5vcmcgMDQvMDEvMjAxNAo+ID4gPiBbICA2ODIuMTQ2NjczXSBSSVA6IDAwMTA6Z3JvdXBf Y3B1c19ldmVubHkrMHgxYWEvMHgxYzAKPiA+ID4gWyAgNjgyLjE0NjY3Nl0gQ29kZTogNGMgODkg ZTAgNWIgNWQgNDEgNWMgNDEgNWQgNDEgNWUgYzMgY2MgY2MgY2MgY2MgZTggMWIgYzQgNzQgZmYg NDggODkgZWYgZTggMTMgYWMgOTggZmYgNGMgODkgZTcgNDUgMzEgZTQgZTggMDggYWMgOTggZmYg ZWIgYzIgPDBmPiAwYiBlYiBiNiBlOCBmZCAwNSBjMyAwMCA0NSAzMSBlNCBlYiBlNSBjYyBjYyBj YyBjYyBjYyBjYyBjYyBjYwo+ID4gPiBbICA2ODIuMTQ2Njc5XSBSU1A6IDAwMTg6ZmZmZmM5MDAw MjE1ZjQ5OCBFRkxBR1M6IDAwMDEwMjkzCj4gPiA+IFsgIDY4Mi4xNDY2ODJdIFJBWDogMDAwMDAw MDAwMDAxZjFlMCBSQlg6IDAwMDAwMDAwMDAwMDAwNDEgUkNYOiAwMDAwMDAwMDAwMDAwMDAwCj4g PiA+IFsgIDY4Mi4xNDY2ODRdIFJEWDogZmZmZjg4ODEwOTkyMjA1OCBSU0k6IDAwMDAwMDAwMDAw MDAwNDEgUkRJOiAwMDAwMDAwMDAwMDAwMDMwCj4gPiA+IFsgIDY4Mi4xNDY2ODZdIFJCUDogZmZm Zjg4ODEwOTkyMjA1OCBSMDg6IGZmZmZjOTAwMDIxNWY0OTggUjA5OiBmZmZmYzkwMDAyMTVmNGEw Cj4gPiA+IFsgIDY4Mi4xNDY2ODddIFIxMDogMDAwMDAwMDAwMDAxOThkMCBSMTE6IDAwMDAwMDAw MDAwMDAwMzAgUjEyOiBmZmZmODg4MTA3ZTAyODAwCj4gPiA+IFsgIDY4Mi4xNDY2ODldIFIxMzog MDAwMDAwMDAwMDAwMDAzMCBSMTQ6IDAwMDAwMDAwMDAwMDAwMzAgUjE1OiAwMDAwMDAwMDAwMDAw MDQxCj4gPiA+IFsgIDY4Mi4xNDY2OTJdIEZTOiAgMDAwMDdmZWY1MjMxNTc0MCgwMDAwKSBHUzpm ZmZmODg4MjM3MzgwMDAwKDAwMDApIGtubEdTOjAwMDAwMDAwMDAwMDAwMDAKPiA+ID4gWyAgNjgy LjE0NjY5NV0gQ1M6ICAwMDEwIERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAz Mwo+ID4gPiBbICA2ODIuMTQ2Njk2XSBDUjI6IDAwMDA3ZmVmNTI1MDkwMDAgQ1IzOiAwMDAwMDAw MTEwZGJjMDA0IENSNDogMDAwMDAwMDAwMDM3MGVlMAo+ID4gPiBbICA2ODIuMTQ2Njk4XSBEUjA6 IDAwMDAwMDAwMDAwMDAwMDAgRFIxOiAwMDAwMDAwMDAwMDAwMDAwIERSMjogMDAwMDAwMDAwMDAw MDAwMAo+ID4gPiBbICA2ODIuMTQ2NzAwXSBEUjM6IDAwMDAwMDAwMDAwMDAwMDAgRFI2OiAwMDAw MDAwMGZmZmUwZmYwIERSNzogMDAwMDAwMDAwMDAwMDQwMAo+ID4gPiBbICA2ODIuMTQ2NzAxXSBD YWxsIFRyYWNlOgo+ID4gPiBbICA2ODIuMTQ2NzAzXSAgPFRBU0s+Cj4gPiA+IFsgIDY4Mi4xNDY3 MDVdICA/IF9fd2FybisweDdiLzB4MTMwCj4gPiA+IFsgIDY4Mi4xNDY3MDldICA/IGdyb3VwX2Nw dXNfZXZlbmx5KzB4MWFhLzB4MWMwCj4gPiA+IFsgIDY4Mi4xNDY3MTJdICA/IHJlcG9ydF9idWcr MHgxYzgvMHgxZTAKPiA+ID4gWyAgNjgyLjE0NjcxN10gID8gaGFuZGxlX2J1ZysweDNjLzB4NzAK PiA+ID4gWyAgNjgyLjE0NjcyMV0gID8gZXhjX2ludmFsaWRfb3ArMHgxNC8weDcwCj4gPiA+IFsg IDY4Mi4xNDY3MjNdICA/IGFzbV9leGNfaW52YWxpZF9vcCsweDE2LzB4MjAKPiA+ID4gWyAgNjgy LjE0NjcyN10gID8gZ3JvdXBfY3B1c19ldmVubHkrMHgxYWEvMHgxYzAKPiA+ID4gWyAgNjgyLjE0 NjcyOV0gID8gZ3JvdXBfY3B1c19ldmVubHkrMHgxNWMvMHgxYzAKPiA+ID4gWyAgNjgyLjE0Njcz MV0gIGNyZWF0ZV9hZmZpbml0eV9tYXNrcysweGFmLzB4MWEwCj4gPiA+IFsgIDY4Mi4xNDY3MzVd ICB2aXJ0aW9fdmRwYV9maW5kX3ZxcysweDgzLzB4MWQwCj4gPiA+IFsgIDY4Mi4xNDY3MzhdICA/ IF9fcGZ4X2RlZmF1bHRfY2FsY19zZXRzKzB4MTAvMHgxMAo+ID4gPiBbICA2ODIuMTQ2NzQyXSAg dmlydG5ldF9maW5kX3ZxcysweDFmMC8weDM3MAo+ID4gPiBbICA2ODIuMTQ2NzQ3XSAgdmlydG5l dF9wcm9iZSsweDUwMS8weGNkMAo+ID4gPiBbICA2ODIuMTQ2NzQ5XSAgPyB2cF9tb2Rlcm5fZ2V0 X3N0YXR1cysweDEyLzB4MjAKPiA+ID4gWyAgNjgyLjE0Njc1MV0gID8gZ2V0X2NhcF9hZGRyLmlz cmEuMCsweDEwLzB4YzAKPiA+ID4gWyAgNjgyLjE0Njc1NF0gIHZpcnRpb19kZXZfcHJvYmUrMHgx YWYvMHgyNjAKPiA+ID4gWyAgNjgyLjE0Njc1OV0gIHJlYWxseV9wcm9iZSsweDFhNS8weDQxMAo+ ID4gPgo+ID4gPiBGaXhlczogM2RhZDU2ODIzYjUzICgidmlydGlvLXZkcGE6IFN1cHBvcnQgaW50 ZXJydXB0IGFmZmluaXR5IHNwcmVhZGluZyBtZWNoYW5pc20iKQo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+ID4KPiA+IFRoaXMgd29uJ3QgZml4 IHRoZSBjYXNlIHdoZXJlIGJsb2NrIGhhcyBtb3JlIHF1ZXVlcyB0aGFuIENQVXMgdGhvdWdoLAo+ ID4gd2lsbCBpdD8KPiAKPiBCbG9jayB3aWxsIGxpbWl0IHRoZSBudW1iZXIgb2YgcXVldWVzIGR1 cmluZyBpbml0X3ZxKCk6Cj4gCj4gICAgICAgICBudW1fdnFzID0gbWluX3QodW5zaWduZWQgaW50 LAo+ICAgICAgICAgICAgICAgICAgICAgICAgIG1pbl9ub3RfemVybyhudW1fcmVxdWVzdF9xdWV1 ZXMsIG5yX2NwdV9pZHMpLAo+ICAgICAgICAgICAgICAgICAgICAgICAgIG51bV92cXMpOwo+IAo+ IAo+IFRoYW5rcwoKR29vZCBwb2ludC4gVGhpcyBkb2Vzbid0IHBsYXkgd2VsbCB3aXRoIGNwdSBo b3RwbHVnIGJ1dCB0aGF0IGlzIG5vdCBuZXcuCgo+ID4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJz L3ZpcnRpby92aXJ0aW9fdmRwYS5jIHwgMTcgKysrKysrKysrKystLS0tLS0KPiA+ID4gIDEgZmls ZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3ZkcGEuYyBiL2RyaXZlcnMvdmlydGlv L3ZpcnRpb192ZHBhLmMKPiA+ID4gaW5kZXggOTYxMTYxZGE1OTAwLi4wNmNlNmQ4YzJlMDAgMTAw NjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb192ZHBhLmMKPiA+ID4gKysrIGIv ZHJpdmVycy92aXJ0aW8vdmlydGlvX3ZkcGEuYwo+ID4gPiBAQCAtMzY2LDExICszNjYsMTQgQEAg c3RhdGljIGludCB2aXJ0aW9fdmRwYV9maW5kX3ZxcyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRl diwgdW5zaWduZWQgaW50IG52cXMsCj4gPiA+ICAgICAgIHN0cnVjdCBpcnFfYWZmaW5pdHkgZGVm YXVsdF9hZmZkID0geyAwIH07Cj4gPiA+ICAgICAgIHN0cnVjdCBjcHVtYXNrICptYXNrczsKPiA+ ID4gICAgICAgc3RydWN0IHZkcGFfY2FsbGJhY2sgY2I7Cj4gPiA+ICsgICAgIGJvb2wgaGFzX2Fm ZmluaXR5ID0gZGVzYyAmJiBvcHMtPnNldF92cV9hZmZpbml0eTsKPiA+ID4gICAgICAgaW50IGks IGVyciwgcXVldWVfaWR4ID0gMDsKPiA+ID4KPiA+ID4gLSAgICAgbWFza3MgPSBjcmVhdGVfYWZm aW5pdHlfbWFza3MobnZxcywgZGVzYyA/IGRlc2MgOiAmZGVmYXVsdF9hZmZkKTsKPiA+ID4gLSAg ICAgaWYgKCFtYXNrcykKPiA+ID4gLSAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiA+ID4g KyAgICAgaWYgKGhhc19hZmZpbml0eSkgewo+ID4gPiArICAgICAgICAgICAgIG1hc2tzID0gY3Jl YXRlX2FmZmluaXR5X21hc2tzKG52cXMsIGRlc2MgPyBkZXNjIDogJmRlZmF1bHRfYWZmZCk7Cj4g PiA+ICsgICAgICAgICAgICAgaWYgKCFtYXNrcykKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg IHJldHVybiAtRU5PTUVNOwo+ID4gPiArICAgICB9Cj4gPiA+Cj4gPiA+ICAgICAgIGZvciAoaSA9 IDA7IGkgPCBudnFzOyArK2kpIHsKPiA+ID4gICAgICAgICAgICAgICBpZiAoIW5hbWVzW2ldKSB7 Cj4gPiA+IEBAIC0zODYsMjAgKzM4OSwyMiBAQCBzdGF0aWMgaW50IHZpcnRpb192ZHBhX2ZpbmRf dnFzKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2LCB1bnNpZ25lZCBpbnQgbnZxcywKPiA+ID4g ICAgICAgICAgICAgICAgICAgICAgIGdvdG8gZXJyX3NldHVwX3ZxOwo+ID4gPiAgICAgICAgICAg ICAgIH0KPiA+ID4KPiA+ID4gLSAgICAgICAgICAgICBpZiAob3BzLT5zZXRfdnFfYWZmaW5pdHkp Cj4gPiA+ICsgICAgICAgICAgICAgaWYgKGhhc19hZmZpbml0eSkKPiA+ID4gICAgICAgICAgICAg ICAgICAgICAgIG9wcy0+c2V0X3ZxX2FmZmluaXR5KHZkcGEsIGksICZtYXNrc1tpXSk7Cj4gPiA+ ICAgICAgIH0KPiA+ID4KPiA+ID4gICAgICAgY2IuY2FsbGJhY2sgPSB2aXJ0aW9fdmRwYV9jb25m aWdfY2I7Cj4gPiA+ICAgICAgIGNiLnByaXZhdGUgPSB2ZF9kZXY7Cj4gPiA+ICAgICAgIG9wcy0+ c2V0X2NvbmZpZ19jYih2ZHBhLCAmY2IpOwo+ID4gPiAtICAgICBrZnJlZShtYXNrcyk7Cj4gPiA+ ICsgICAgIGlmIChoYXNfYWZmaW5pdHkpCj4gPiA+ICsgICAgICAgICAgICAga2ZyZWUobWFza3Mp Owo+ID4gPgo+ID4gPiAgICAgICByZXR1cm4gMDsKPiA+ID4KPiA+ID4gIGVycl9zZXR1cF92cToK PiA+ID4gICAgICAgdmlydGlvX3ZkcGFfZGVsX3Zxcyh2ZGV2KTsKPiA+ID4gLSAgICAga2ZyZWUo bWFza3MpOwo+ID4gPiArICAgICBpZiAoaGFzX2FmZmluaXR5KQo+ID4gPiArICAgICAgICAgICAg IGtmcmVlKG1hc2tzKTsKPiA+ID4gICAgICAgcmV0dXJuIGVycjsKPiA+ID4gIH0KPiA+ID4KPiA+ ID4gLS0KPiA+ID4gMi4zOS4zCj4gPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9u QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9u Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C87DC04A6A for ; Fri, 11 Aug 2023 09:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234534AbjHKJtm (ORCPT ); Fri, 11 Aug 2023 05:49:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbjHKJtg (ORCPT ); Fri, 11 Aug 2023 05:49:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 191072723 for ; Fri, 11 Aug 2023 02:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691747329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fuPwMiCOds871v8o/ogtGSupZ7sHE8svUP10CQtFD/o=; b=i6KGhJ1igbSShxZa6tfwrXxa7Hm3iCDUvHMVw/MAe/4PuIYtMMCJuoPbzrVvej7QXTEn1Y OD5c49ZruDbFozKDN3dVNYYUlNxq3UE0kO0OQfscuhaT0V7BjGvUCsCp9ZAZWkOUssFy2b 2dL5M8AwSYXaemhL1GGlWQlgYkjH6Us= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-ITziIuwbO1enDueYMZ8g5w-1; Fri, 11 Aug 2023 05:48:47 -0400 X-MC-Unique: ITziIuwbO1enDueYMZ8g5w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fe5c898715so11552865e9.0 for ; Fri, 11 Aug 2023 02:48:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691747326; x=1692352126; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fuPwMiCOds871v8o/ogtGSupZ7sHE8svUP10CQtFD/o=; b=SqmoO7LTVN+C9cDhxvNdYtylymlklbWnKOZKbzz6P+7ch2LMAzZTj9d+TDhVXPHlVK RY2sqgWAfwaJguOm0Vy9BJg6nxkSOpA+q60J2Agfex7rdUOgZbvjZJFzOH/4sbrwLITG Z/2G/gL2RuIebT9+EcOwQjPmvVAoCCvghb2wBPIkeBwaAmBn80SwjOuvMiE/4dgKXV03 8VM36y6cOz8m3Flw64GzR3ip/raYIWv4kTohWp1wQIHpPwSsJtu5gHVaK7mkvAWPrPpk P3kBez0cOzu33QPgp3V54wLm7DDiO6P50i34nuZ2VfSPuy4SmRX40StH8pKinJih1d5d 4fQA== X-Gm-Message-State: AOJu0Yznt9KoO9/QSNT3jXUUn+6MSSk1olaJ6wz76wui1w68UPk28NYg TXiBONr3cu6Wd0/5phgzYhmFMQY6vm2p9L/RptwfwMGCSLYy+jWLyBqPBUXJVmFvBrbw3L6nxJI VrxleNygWkEN/TtkmxvWJ2iq4EyD9FjNE X-Received: by 2002:a1c:cc12:0:b0:3fa:8db4:91ec with SMTP id h18-20020a1ccc12000000b003fa8db491ecmr1134553wmb.10.1691747326504; Fri, 11 Aug 2023 02:48:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGf9bXPD4yjwvlp8v42lTNJRVWFj4ngnnn3DuWzV+hlTBAZcBoR/XB3/gpHHTV7jqPuGXB0EA== X-Received: by 2002:a1c:cc12:0:b0:3fa:8db4:91ec with SMTP id h18-20020a1ccc12000000b003fa8db491ecmr1134544wmb.10.1691747326177; Fri, 11 Aug 2023 02:48:46 -0700 (PDT) Received: from redhat.com ([2.55.42.146]) by smtp.gmail.com with ESMTPSA id c16-20020a7bc010000000b003fc00212c1esm4709023wmb.28.2023.08.11.02.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 02:48:45 -0700 (PDT) Date: Fri, 11 Aug 2023 05:48:42 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: xuanzhuo@linux.alibaba.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, xieyongji@bytedance.com Subject: Re: [PATCH] virtio_vdpa: build affinity masks conditionally Message-ID: <20230811054736-mutt-send-email-mst@kernel.org> References: <20230811091539.1359865-1-jasowang@redhat.com> <20230811052435-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 05:41:44PM +0800, Jason Wang wrote: > On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > > We try to build affinity mask via create_affinity_masks() > > > unconditionally which may lead several issues: > > > > > > - the affinity mask is not used for parent without affinity support > > > (only VDUSE support the affinity now) > > > - the logic of create_affinity_masks() might not work for devices > > > other than block. For example it's not rare in the networking device > > > where the number of queues could exceed the number of CPUs. Such > > > case breaks the current affinity logic which is based on > > > group_cpus_evenly() who assumes the number of CPUs are not less than > > > the number of groups. This can trigger a warning[1]: > > > > > > if (ret >= 0) > > > WARN_ON(nr_present + nr_others < numgrps); > > > > > > Fixing this by only build the affinity masks only when > > > > > > - Driver passes affinity descriptor, driver like virtio-blk can make > > > sure to limit the number of queues when it exceeds the number of CPUs > > > - Parent support affinity setting config ops > > > > > > This help to avoid the warning. More optimizations could be done on > > > top. > > > > > > [1] > > > [ 682.146655] WARNING: CPU: 6 PID: 1550 at lib/group_cpus.c:400 group_cpus_evenly+0x1aa/0x1c0 > > > [ 682.146668] CPU: 6 PID: 1550 Comm: vdpa Not tainted 6.5.0-rc5jason+ #79 > > > [ 682.146671] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014 > > > [ 682.146673] RIP: 0010:group_cpus_evenly+0x1aa/0x1c0 > > > [ 682.146676] Code: 4c 89 e0 5b 5d 41 5c 41 5d 41 5e c3 cc cc cc cc e8 1b c4 74 ff 48 89 ef e8 13 ac 98 ff 4c 89 e7 45 31 e4 e8 08 ac 98 ff eb c2 <0f> 0b eb b6 e8 fd 05 c3 00 45 31 e4 eb e5 cc cc cc cc cc cc cc cc > > > [ 682.146679] RSP: 0018:ffffc9000215f498 EFLAGS: 00010293 > > > [ 682.146682] RAX: 000000000001f1e0 RBX: 0000000000000041 RCX: 0000000000000000 > > > [ 682.146684] RDX: ffff888109922058 RSI: 0000000000000041 RDI: 0000000000000030 > > > [ 682.146686] RBP: ffff888109922058 R08: ffffc9000215f498 R09: ffffc9000215f4a0 > > > [ 682.146687] R10: 00000000000198d0 R11: 0000000000000030 R12: ffff888107e02800 > > > [ 682.146689] R13: 0000000000000030 R14: 0000000000000030 R15: 0000000000000041 > > > [ 682.146692] FS: 00007fef52315740(0000) GS:ffff888237380000(0000) knlGS:0000000000000000 > > > [ 682.146695] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 682.146696] CR2: 00007fef52509000 CR3: 0000000110dbc004 CR4: 0000000000370ee0 > > > [ 682.146698] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > [ 682.146700] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > [ 682.146701] Call Trace: > > > [ 682.146703] > > > [ 682.146705] ? __warn+0x7b/0x130 > > > [ 682.146709] ? group_cpus_evenly+0x1aa/0x1c0 > > > [ 682.146712] ? report_bug+0x1c8/0x1e0 > > > [ 682.146717] ? handle_bug+0x3c/0x70 > > > [ 682.146721] ? exc_invalid_op+0x14/0x70 > > > [ 682.146723] ? asm_exc_invalid_op+0x16/0x20 > > > [ 682.146727] ? group_cpus_evenly+0x1aa/0x1c0 > > > [ 682.146729] ? group_cpus_evenly+0x15c/0x1c0 > > > [ 682.146731] create_affinity_masks+0xaf/0x1a0 > > > [ 682.146735] virtio_vdpa_find_vqs+0x83/0x1d0 > > > [ 682.146738] ? __pfx_default_calc_sets+0x10/0x10 > > > [ 682.146742] virtnet_find_vqs+0x1f0/0x370 > > > [ 682.146747] virtnet_probe+0x501/0xcd0 > > > [ 682.146749] ? vp_modern_get_status+0x12/0x20 > > > [ 682.146751] ? get_cap_addr.isra.0+0x10/0xc0 > > > [ 682.146754] virtio_dev_probe+0x1af/0x260 > > > [ 682.146759] really_probe+0x1a5/0x410 > > > > > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism") > > > Signed-off-by: Jason Wang > > > > This won't fix the case where block has more queues than CPUs though, > > will it? > > Block will limit the number of queues during init_vq(): > > num_vqs = min_t(unsigned int, > min_not_zero(num_request_queues, nr_cpu_ids), > num_vqs); > > > Thanks Good point. This doesn't play well with cpu hotplug but that is not new. > > > > > --- > > > drivers/virtio/virtio_vdpa.c | 17 +++++++++++------ > > > 1 file changed, 11 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > > > index 961161da5900..06ce6d8c2e00 100644 > > > --- a/drivers/virtio/virtio_vdpa.c > > > +++ b/drivers/virtio/virtio_vdpa.c > > > @@ -366,11 +366,14 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs, > > > struct irq_affinity default_affd = { 0 }; > > > struct cpumask *masks; > > > struct vdpa_callback cb; > > > + bool has_affinity = desc && ops->set_vq_affinity; > > > int i, err, queue_idx = 0; > > > > > > - masks = create_affinity_masks(nvqs, desc ? desc : &default_affd); > > > - if (!masks) > > > - return -ENOMEM; > > > + if (has_affinity) { > > > + masks = create_affinity_masks(nvqs, desc ? desc : &default_affd); > > > + if (!masks) > > > + return -ENOMEM; > > > + } > > > > > > for (i = 0; i < nvqs; ++i) { > > > if (!names[i]) { > > > @@ -386,20 +389,22 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs, > > > goto err_setup_vq; > > > } > > > > > > - if (ops->set_vq_affinity) > > > + if (has_affinity) > > > ops->set_vq_affinity(vdpa, i, &masks[i]); > > > } > > > > > > cb.callback = virtio_vdpa_config_cb; > > > cb.private = vd_dev; > > > ops->set_config_cb(vdpa, &cb); > > > - kfree(masks); > > > + if (has_affinity) > > > + kfree(masks); > > > > > > return 0; > > > > > > err_setup_vq: > > > virtio_vdpa_del_vqs(vdev); > > > - kfree(masks); > > > + if (has_affinity) > > > + kfree(masks); > > > return err; > > > } > > > > > > -- > > > 2.39.3 > >