From: Jakub Kicinski <kuba@kernel.org>
To: Sai Krishna Gajula <saikrishnag@marvell.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
Naveen Mamindlapalli <naveenm@marvell.com>
Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter atomic update feature
Date: Fri, 11 Aug 2023 15:04:49 -0700 [thread overview]
Message-ID: <20230811150449.64ce3512@kernel.org> (raw)
In-Reply-To: <BY3PR18MB470745294C1B03C0DA5364E6A010A@BY3PR18MB4707.namprd18.prod.outlook.com>
On Fri, 11 Aug 2023 05:48:38 +0000 Sai Krishna Gajula wrote:
> > If you reorder the includes - maybe put them in alphabetical order?
>
> There are some structure definitions in rvu.h which are required in
> ptp.h. So, re-ordering in alphabetical order will give compilation
> issue.
Headers should be self-contained. Such dependencies are hard to figure
out for people doing refactoring so it'd be best to clean that up.
next prev parent reply other threads:[~2023-08-11 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 14:05 [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter atomic update feature Sai Krishna
2023-08-09 13:07 ` Kalesh Anakkur Purayil
2023-08-09 22:50 ` Jakub Kicinski
2023-08-11 5:48 ` Sai Krishna Gajula
2023-08-11 22:04 ` Jakub Kicinski [this message]
2023-08-14 11:33 ` Sai Krishna Gajula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811150449.64ce3512@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.