From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
jacob.e.keller@intel.com,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next v2 2/5] ice: configure FW logging
Date: Fri, 11 Aug 2023 15:16:00 -0700 [thread overview]
Message-ID: <20230811151600.6d59eaad@kernel.org> (raw)
In-Reply-To: <ZNYH705yA5qGxnvJ@vergenet.net>
On Fri, 11 Aug 2023 12:05:35 +0200 Simon Horman wrote:
> > if (status) {
> > pr_err("failed to register PCI driver, err %d\n", status);
> > goto err_dest_lag_wq;
> > + destroy_workqueue(ice_wq);
> > + ice_debugfs_exit();
>
> Hi Paul and Tony,
>
> this new code seems to be unreachable.
> Should it go before the goto statement?
:o catch of the week! :)
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-11 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 17:01 [PATCH net-next v2 0/5][pull request] add v2 FW logging for ice driver Tony Nguyen
2023-08-10 17:01 ` [PATCH net-next v2 1/5] ice: remove FW logging code Tony Nguyen
2023-08-10 17:01 ` [PATCH net-next v2 2/5] ice: configure FW logging Tony Nguyen
2023-08-11 10:05 ` Simon Horman
2023-08-11 22:16 ` Jakub Kicinski [this message]
2023-08-14 15:24 ` Paul M Stillwell Jr
2023-08-10 17:01 ` [PATCH net-next v2 3/5] ice: enable " Tony Nguyen
2023-08-10 17:01 ` [PATCH net-next v2 4/5] ice: add ability to read FW log data and configure the number of log buffers Tony Nguyen
2023-08-10 17:01 ` [PATCH net-next v2 5/5] ice: add documentation for FW logging Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811151600.6d59eaad@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.