From: Jakub Kicinski <kuba@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, xuanzhuo@linux.alibaba.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net V2] virtio-net: set queues after driver_ok
Date: Fri, 11 Aug 2023 18:23:44 -0700 [thread overview]
Message-ID: <20230811182344.763f10da@kernel.org> (raw)
In-Reply-To: <20230810031256.813284-1-jasowang@redhat.com>
On Wed, 9 Aug 2023 23:12:56 -0400 Jason Wang wrote:
> Commit 25266128fe16 ("virtio-net: fix race between set queues and
> probe") tries to fix the race between set queues and probe by calling
> _virtnet_set_queues() before DRIVER_OK is set. This violates virtio
> spec. Fixing this by setting queues after virtio_device_ready().
>
> Note that rtnl needs to be held for userspace requests to change the
> number of queues. So we are serialized in this way.
FTR this appears to have been applied yesterday by DaveM. Thanks!
next prev parent reply other threads:[~2023-08-12 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 3:12 [PATCH net V2] virtio-net: set queues after driver_ok Jason Wang
2023-08-10 3:12 ` Jason Wang
2023-08-12 1:23 ` Jakub Kicinski [this message]
2023-08-21 7:54 ` Like Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811182344.763f10da@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.