Re: [PATCH v18 1/1] clk: npcm8xx: add clock controller

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230727074328.34144-2-tmaimon77@gmail.com>
References: <20230727074328.34144-2-tmaimon77@gmail.com>
TO: Tomer Maimon <tmaimon77@gmail.com>

Hi Tomer,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.5-rc3]
[also build test WARNING on linus/master next-20230809]
[cannot apply to clk/clk-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tomer-Maimon/clk-npcm8xx-add-clock-controller/20230727-161149
base:   v6.5-rc3
patch link:    https://lore.kernel.org/r/20230727074328.34144-2-tmaimon77%40gmail.com
patch subject: [PATCH v18 1/1] clk: npcm8xx: add clock controller
:::::: branch date: 2 weeks ago
:::::: commit date: 2 weeks ago
config: nios2-randconfig-m031-20230812 (https://download.01.org/0day-ci/archive/20230812/202308121204.0vblViWk-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230812/202308121204.0vblViWk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202308121204.0vblViWk-lkp@intel.com/

smatch warnings:
drivers/clk/clk-npcm8xx.c:375 npcm8xx_clk_register_pll() warn: passing devm_ allocated variable to kfree. 'pll'

vim +/pll +375 drivers/clk/clk-npcm8xx.c

43dcec6ce04c61 Tomer Maimon 2023-07-27  350  
43dcec6ce04c61 Tomer Maimon 2023-07-27  351  static struct clk_hw *
43dcec6ce04c61 Tomer Maimon 2023-07-27  352  npcm8xx_clk_register_pll(struct device *dev, void __iomem *pllcon,
43dcec6ce04c61 Tomer Maimon 2023-07-27  353  			 const char *name, const struct clk_parent_data *parent,
43dcec6ce04c61 Tomer Maimon 2023-07-27  354  			 unsigned long flags)
43dcec6ce04c61 Tomer Maimon 2023-07-27  355  {
43dcec6ce04c61 Tomer Maimon 2023-07-27  356  	struct npcm8xx_clk_pll *pll;
43dcec6ce04c61 Tomer Maimon 2023-07-27  357  	struct clk_init_data init = {};
43dcec6ce04c61 Tomer Maimon 2023-07-27  358  	int ret;
43dcec6ce04c61 Tomer Maimon 2023-07-27  359  
43dcec6ce04c61 Tomer Maimon 2023-07-27  360  	pll = devm_kzalloc(dev, sizeof(*pll), GFP_KERNEL);
43dcec6ce04c61 Tomer Maimon 2023-07-27  361  	if (!pll)
43dcec6ce04c61 Tomer Maimon 2023-07-27  362  		return ERR_PTR(-ENOMEM);
43dcec6ce04c61 Tomer Maimon 2023-07-27  363  
43dcec6ce04c61 Tomer Maimon 2023-07-27  364  	init.name = name;
43dcec6ce04c61 Tomer Maimon 2023-07-27  365  	init.ops = &npcm8xx_clk_pll_ops;
43dcec6ce04c61 Tomer Maimon 2023-07-27  366  	init.parent_data = parent;
43dcec6ce04c61 Tomer Maimon 2023-07-27  367  	init.num_parents = 1;
43dcec6ce04c61 Tomer Maimon 2023-07-27  368  	init.flags = flags;
43dcec6ce04c61 Tomer Maimon 2023-07-27  369  
43dcec6ce04c61 Tomer Maimon 2023-07-27  370  	pll->pllcon = pllcon;
43dcec6ce04c61 Tomer Maimon 2023-07-27  371  	pll->hw.init = &init;
43dcec6ce04c61 Tomer Maimon 2023-07-27  372  
43dcec6ce04c61 Tomer Maimon 2023-07-27  373  	ret = devm_clk_hw_register(dev, &pll->hw);
43dcec6ce04c61 Tomer Maimon 2023-07-27  374  	if (ret) {
43dcec6ce04c61 Tomer Maimon 2023-07-27 @375  		kfree(pll);
43dcec6ce04c61 Tomer Maimon 2023-07-27  376  		return ERR_PTR(ret);
43dcec6ce04c61 Tomer Maimon 2023-07-27  377  	}
43dcec6ce04c61 Tomer Maimon 2023-07-27  378  
43dcec6ce04c61 Tomer Maimon 2023-07-27  379  	return &pll->hw;
43dcec6ce04c61 Tomer Maimon 2023-07-27  380  }
43dcec6ce04c61 Tomer Maimon 2023-07-27  381  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki