All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bartosz Bilas <b.bilas@grinn-global.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] gdb: disable source-highlight
Date: Sat, 12 Aug 2023 12:50:51 +0200	[thread overview]
Message-ID: <20230812125051.4b8b0b84@windsurf> (raw)
In-Reply-To: <20230811093421.300794-1-b.bilas@grinn-global.com>

On Fri, 11 Aug 2023 11:34:21 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> It's being found from the host's source-highlight library
> which results in the following build errors:
> 
> ../../gdb/source-cache.c:37:10: fatal error: srchilite/sourcehighlight.h: No such file or directory
>    37 | #include <srchilite/sourcehighlight.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [Makefile:1645: source-cache.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>

Thanks patch applied to master, after updating the commit title to use
"package/gdb: " as the prefix, to follow our convention.

Also, I am wondering if the same should not be done for the host
variant of gdb. Indeed, we don't want to rely on the system-provided
source highlight if it's not built by Buildroot. Could you have a look
into this, and if it makes sense, send a patch?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-12 10:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  9:34 [Buildroot] [PATCH] gdb: disable source-highlight Bartosz Bilas
2023-08-12 10:50 ` Thomas Petazzoni via buildroot [this message]
     [not found]   ` <5cd4ca82-696e-037c-2a84-1de6f34cdc7f@grinn-global.com>
     [not found]     ` <20230817122702.18d7760f@windsurf>
2023-08-18  6:18       ` Bartosz Bilas
2023-09-12 21:22   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230812125051.4b8b0b84@windsurf \
    --to=buildroot@buildroot.org \
    --cc=b.bilas@grinn-global.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.