Re: [Buildroot] [PATCH] andes_ae350_45: Fix build issues of AE350

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kilian Zinnecker <kilian.zinnecker@mail.de>
Cc: Yu Chien Peter Lin <peterlin@andestech.com>,
	ycliang@andestech.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] andes_ae350_45: Fix build issues of AE350
Date: Sat, 12 Aug 2023 14:27:59 +0200	[thread overview]
Message-ID: <20230812142759.2bc8cee3@windsurf> (raw)
In-Reply-To: <2300152.ElGaqSPkdT@kilian-aisec>

On Sat, 12 Aug 2023 14:00:00 +0200
Kilian Zinnecker <kilian.zinnecker@mail.de> wrote:

> So I think setting BR2_RISCV_ISA_CUSTOM_RVA=y is correct. However, you could 
> try whether it works, if you then completely remove the 
> BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS?

The U-Boot version used by the andes_ae350_45 defconfig indeed includes:

# Newer binutils versions default to ISA spec version 20191213 which moves some
# instructions from the I extension to the Zicsr and Zifencei extensions.
toolchain-need-zicsr-zifencei := $(call cc-option-yn, -mabi=$(ABI) -march=$(RISCV_MARCH)_zicsr_zifencei)
ifeq ($(toolchain-need-zicsr-zifencei),y)
        RISCV_MARCH := $(RISCV_MARCH)_zicsr_zifencei
endif

So it should already be doing the right thing automatically. However,
the fact that the defconfig forces its own ARCH_FLAGS=-march=rv64imafdc
is probably what breaks the build.

So I agree with Kilian here: please try without any:

BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc"

and see if that helps. However in that case, you might need indeed to
keep the addition of BR2_RISCV_ISA_CUSTOM_RVA=y as part of the fix:
please double check that.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot