From: Greg KH <gregkh@linuxfoundation.org>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: stable@vger.kernel.org, RAJESH DASARI <raajeshdasari@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 5.4,5.10] x86/pkeys: Revert a5eff7259790 ("x86/pkeys: Add PKRU value to init_fpstate")
Date: Sat, 12 Aug 2023 08:07:49 +0200 [thread overview]
Message-ID: <2023081241-simmering-compacted-20eb@gregkh> (raw)
In-Reply-To: <20230810153106.172292-1-cascardo@canonical.com>
On Thu, Aug 10, 2023 at 12:31:06PM -0300, Thadeu Lima de Souza Cascardo wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Commit b3607269ff57fd3c9690cb25962c5e4b91a0fd3b upstream.
>
> This cannot work and it's unclear how that ever made a difference.
>
> init_fpstate.xsave.header.xfeatures is always 0 so get_xsave_addr() will
> always return a NULL pointer, which will prevent storing the default PKRU
> value in init_fpstate.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Reviewed-by: Borislav Petkov <bp@suse.de>
> Link: https://lkml.kernel.org/r/20210623121451.451391598@linutronix.de
> Reported-by: RAJESH DASARI <raajeshdasari@gmail.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>
> This has been reported to cause a WARNing since the backport of b81fac906a8f
> ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()").
>
> a5eff7259790 was part of 5.2 and no older LTS kernels carry it, so not
> necessary on 4.19 or 4.14.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-08-12 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 15:31 [PATCH 5.4,5.10] x86/pkeys: Revert a5eff7259790 ("x86/pkeys: Add PKRU value to init_fpstate") Thadeu Lima de Souza Cascardo
2023-08-12 6:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081241-simmering-compacted-20eb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=cascardo@canonical.com \
--cc=raajeshdasari@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.