All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Cyrus Ramavarapu <cyrus.ramavarapu@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon: Remove unnecessary parentheses
Date: Sun, 13 Aug 2023 08:28:01 +0200	[thread overview]
Message-ID: <2023081302-ripping-yo-yo-2b44@gregkh> (raw)
In-Reply-To: <20230813005326.98905-1-cyrus.ramavarapu@gmail.com>

On Sat, Aug 12, 2023 at 08:53:26PM -0400, Cyrus Ramavarapu wrote:
> Remove unnecessary parentheses found by checkpatch.

Please no, don't do this, see the email archives of this list for why I
don't like this type of change (it forces you do have to remember rules
when looking at the code in the future.)

I wish checkpatch would not report this type of issue anymore...

thanks,

greg k-h

  reply	other threads:[~2023-08-13  6:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-13  0:53 [PATCH] staging: octeon: Remove unnecessary parentheses Cyrus Ramavarapu
2023-08-13  6:28 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-02 20:51 [PATCH] staging: octeon: remove " Tianbo Fu
2026-10-02 14:00 ` Greg Kroah-Hartman
2026-10-13 13:40 ` Greg Kroah-Hartman
2023-10-29 16:35 Dorine Tipo
2023-10-29 17:15 ` Julia Lawall
2023-10-29 16:24 Dorine Tipo
2023-10-29 16:53 ` Julia Lawall
2023-10-29 16:01 Dorine Tipo
2023-10-29 16:30 ` Julia Lawall
2017-09-14 16:51 [PATCH] Staging: octeon: Remove " Meghana Madhyastha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023081302-ripping-yo-yo-2b44@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cyrus.ramavarapu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.