From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9FEC001B0 for ; Sun, 13 Aug 2023 15:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231620AbjHMPxo (ORCPT ); Sun, 13 Aug 2023 11:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231893AbjHMPxE (ORCPT ); Sun, 13 Aug 2023 11:53:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6FDC1BF9; Sun, 13 Aug 2023 08:52:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88BC863345; Sun, 13 Aug 2023 15:52:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75E24C433C8; Sun, 13 Aug 2023 15:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691941954; bh=CIoXN1vFQHFotOHTx6OeSkrhly9vPo0mvFHSoT31VUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZwufX9r+36F8KClRNvy8A5I7B1hecLsbypujqrF5acjj5wTv30l00XORF5sWUgZq VvbmwyDiq4JMNWVIhAKjQMQAfd/komVPzM8fRcVqhbH7kBxWkml6IF+Dh64ycgefj2 oDkXSw1n+p+A/y3P2YJrqiZxdygT0a21i35RJH7DBf+XhIiDjH3+wwCZvyVcJwyorR m8EJbrE4GujPHmWiUGAISHjfTsqr46LdERwq7+cCWhHoA/UXNmsKzwvzLYblnqQVr6 NSNVDCfNA4/si1HzOs/Px3sRicx0axgv9d6eErNVrLeAhZqbPQ8ENzSQELnoJxVEbD aZN8Fkz2jxuvg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Minjie Du , Viresh Kumar , Sergey Shtylyov , Damien Le Moal , Sasha Levin , vireshk@kernel.org, linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 6.4 46/54] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() Date: Sun, 13 Aug 2023 11:49:25 -0400 Message-Id: <20230813154934.1067569-46-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230813154934.1067569-1-sashal@kernel.org> References: <20230813154934.1067569-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.10 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Minjie Du [ Upstream commit 4139f992c49356391fb086c0c8ce51f66c26d623 ] It is possible for dma_request_chan() to return EPROBE_DEFER, which means acdev->host->dev is not ready yet. At this point dev_err() will have no output. Use dev_err_probe() instead. Signed-off-by: Minjie Du Acked-by: Viresh Kumar Reviewed-by: Sergey Shtylyov Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/pata_arasan_cf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index 6ab294322e792..314eaa1679540 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work) /* dma_request_channel may sleep, so calling from process context */ acdev->dma_chan = dma_request_chan(acdev->host->dev, "data"); if (IS_ERR(acdev->dma_chan)) { - dev_err(acdev->host->dev, "Unable to get dma_chan\n"); + dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan), + "Unable to get dma_chan\n"); acdev->dma_chan = NULL; goto chan_request_fail; } -- 2.40.1