All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	hugo@hugovil.com, quic_nguyenb@quicinc.com
Subject: [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init
Date: Mon, 14 Aug 2023 14:43:51 -0400	[thread overview]
Message-ID: <20230814184352.200531-2-bmasney@redhat.com> (raw)
In-Reply-To: <20230814184352.200531-1-bmasney@redhat.com>

Convert ufshcd_variant_hba_init() over to use dev_err_probe() to avoid
log messages like the following on bootup:

    ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
        failed err -517

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Changes since v2
- None

Changes since v1
- Dropped code cleanup

 drivers/ufs/core/ufshcd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 129446775796..409d176542e1 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -9235,8 +9235,9 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
 
 	err = ufshcd_vops_init(hba);
 	if (err)
-		dev_err(hba->dev, "%s: variant %s init failed err %d\n",
-			__func__, ufshcd_get_var_name(hba), err);
+		dev_err_probe(hba->dev, err,
+			      "%s: variant %s init failed err %d\n",
+			      __func__, ufshcd_get_var_name(hba), err);
 out:
 	return err;
 }
-- 
2.41.0


  reply	other threads:[~2023-08-14 18:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 18:43 [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe() Brian Masney
2023-08-14 18:43 ` Brian Masney [this message]
2023-08-14 19:31   ` [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init Bart Van Assche
2023-08-14 21:18     ` Brian Masney
2023-08-14 21:24       ` Bart Van Assche
2023-08-14 18:43 ` [PATCH v3 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init Brian Masney
2023-08-15  3:25   ` Bao D. Nguyen
2023-08-21 20:45 ` [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe() Martin K. Petersen
2023-08-25  1:12 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814184352.200531-2-bmasney@redhat.com \
    --to=bmasney@redhat.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=hugo@hugovil.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_nguyenb@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.