From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F154DC001DB for ; Tue, 15 Aug 2023 02:43:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7AB2960B03; Tue, 15 Aug 2023 02:43:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7AB2960B03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692067423; bh=hsQXpep1uLEwLY7YM8TfjwtbUpk+LuN83szoy/irxZw=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=G96XWN7k6xaG/204HkGqLuZoCgYOky0s5m9EpKzcnpNc2b1SblG7Cppxh7QMgFsfp sFcImjj5u006sgKPtZxi45UScJ7wXilfcWU3WCUosB9T6vB7OKZcleY7nqjayT420J g5Ad6vxOzcpXuHbtEJI0Iw9sNs5yTa88A/aMAbEFLLhhji8NUbVJjlnAEsSiciTemz qQl40W2f3Od/yCLXjyABIrEN60Kh//a5siqzKoozbZ6ldJkv4UH1MrWZfeWXUHU1LG UMpO3mwNaYHF1q7HHA3RCTWoMeFZPYYHHA8ZtKQQK0YNVvzChO5rYKdji2czngnJwX ZtLN67Hgs1R/Q== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KL6lVzo9mutZ; Tue, 15 Aug 2023 02:43:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A1E4160BA7; Tue, 15 Aug 2023 02:43:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A1E4160BA7 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 0818C1BF2B6 for ; Tue, 15 Aug 2023 02:43:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D9ECC408AE for ; Tue, 15 Aug 2023 02:43:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D9ECC408AE X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5b_18NNZs2fX for ; Tue, 15 Aug 2023 02:43:40 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id CA8FB408AB for ; Tue, 15 Aug 2023 02:43:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CA8FB408AB Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A33F96495A; Tue, 15 Aug 2023 02:43:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64589C433C8; Tue, 15 Aug 2023 02:43:37 +0000 (UTC) Date: Mon, 14 Aug 2023 19:43:36 -0700 From: Jakub Kicinski To: Vadim Fedorenko Message-ID: <20230814194336.55642f34@kernel.org> In-Reply-To: <20230811200340.577359-3-vadim.fedorenko@linux.dev> References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-3-vadim.fedorenko@linux.dev> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692067418; bh=7blTAewUXh9WclBQZ+mReosFc6JNCK0kdPIFgrfLNQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bL23djTCRcM7r+1Gp9qSDhPMBmz3x/C4x5iSW4nmvHKAbKinIWMu1gpgCHV4bQVvO iocZQpk1ugrWIBmTlyjBYz5Fvl9hd/E+NoXEsPmh+rGNp31RAAKtoxKTO8IEl0Gwoi uUldRosk0KIrHE/IQPDAjJ8cgdfeDS1VMB+IcNrZrxPJL9JgBvr/jscPaqc7XPbxg1 2aF7Hq0AWIZ7l7eqt7jdapEwypftzA2y2QjPKmz22u2HCEuwNz3EblWVp3FbN0p5RS cYrQr31icAt0/4PEiCaf6+BlAmGP9viia3Y2nGMjQ9XfUPNzOM+9WK2H4UgWY2UNXz CM5OJBRgrf65Q== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bL23djTC Subject: Re: [Intel-wired-lan] [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , Bart Van Assche , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, Jiri Pirko , Jonathan Lemon , Paolo Abeni , linux-clk@vger.kernel.org, Milena Olech Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 11 Aug 2023 21:03:33 +0100 Vadim Fedorenko wrote: > +attribute-sets: > + - > + name: dpll > + enum-name: dpll_a > + attributes: > + - > + name: id > + type: u32 > + value: 1 value: 1 is the default > + - > + name: module-name > + type: string > + - > + name: clock-id > + type: u64 I don't see a pad, you have a u64 without a pad? > + - > + name: mode > + type: u8 It's an enum, should always be u32 or bigger at protocol level. Netlink pads to 4B, you're not saving any space. > + enum: mode > + - > + name: mode-supported > + type: u8 Same. > + enum: mode > + multi-attr: true > + - > + name: lock-status > + type: u8 And here. > + enum: lock-status > + - > + name: temp > + type: s32 > + - > + name: type > + type: u8 And here, etc. Why are all attributes in a single attr space? :( More than half of them are prefixed with a pin- does it really not scream to you that they belong to a different space? > +operations: > + enum-name: dpll_cmd > + list: > + - > + name: device-id-get > + doc: | > + Get id of dpll device that matches given attributes > + value: 1 is the default -- pw-bot: cr _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDE4C001DB for ; Tue, 15 Aug 2023 02:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234340AbjHOCoE (ORCPT ); Mon, 14 Aug 2023 22:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234362AbjHOCnj (ORCPT ); Mon, 14 Aug 2023 22:43:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26F671715 for ; Mon, 14 Aug 2023 19:43:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABB5C64BD4 for ; Tue, 15 Aug 2023 02:43:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64589C433C8; Tue, 15 Aug 2023 02:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692067418; bh=7blTAewUXh9WclBQZ+mReosFc6JNCK0kdPIFgrfLNQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bL23djTCRcM7r+1Gp9qSDhPMBmz3x/C4x5iSW4nmvHKAbKinIWMu1gpgCHV4bQVvO iocZQpk1ugrWIBmTlyjBYz5Fvl9hd/E+NoXEsPmh+rGNp31RAAKtoxKTO8IEl0Gwoi uUldRosk0KIrHE/IQPDAjJ8cgdfeDS1VMB+IcNrZrxPJL9JgBvr/jscPaqc7XPbxg1 2aF7Hq0AWIZ7l7eqt7jdapEwypftzA2y2QjPKmz22u2HCEuwNz3EblWVp3FbN0p5RS cYrQr31icAt0/4PEiCaf6+BlAmGP9viia3Y2nGMjQ9XfUPNzOM+9WK2H4UgWY2UNXz CM5OJBRgrf65Q== Date: Mon, 14 Aug 2023 19:43:36 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: <20230814194336.55642f34@kernel.org> In-Reply-To: <20230811200340.577359-3-vadim.fedorenko@linux.dev> References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-3-vadim.fedorenko@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, 11 Aug 2023 21:03:33 +0100 Vadim Fedorenko wrote: > +attribute-sets: > + - > + name: dpll > + enum-name: dpll_a > + attributes: > + - > + name: id > + type: u32 > + value: 1 value: 1 is the default > + - > + name: module-name > + type: string > + - > + name: clock-id > + type: u64 I don't see a pad, you have a u64 without a pad? > + - > + name: mode > + type: u8 It's an enum, should always be u32 or bigger at protocol level. Netlink pads to 4B, you're not saving any space. > + enum: mode > + - > + name: mode-supported > + type: u8 Same. > + enum: mode > + multi-attr: true > + - > + name: lock-status > + type: u8 And here. > + enum: lock-status > + - > + name: temp > + type: s32 > + - > + name: type > + type: u8 And here, etc. Why are all attributes in a single attr space? :( More than half of them are prefixed with a pin- does it really not scream to you that they belong to a different space? > +operations: > + enum-name: dpll_cmd > + list: > + - > + name: device-id-get > + doc: | > + Get id of dpll device that matches given attributes > + value: 1 is the default -- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21830C0015E for ; Tue, 15 Aug 2023 03:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N88yuhsxtHNOYGoB6wA6urjhcp9DeOolGdRi/Sbud54=; b=2D0xP0pFiJvJnj m9QENn+N5IHImkvALe97cm8Hl9fRyVLyKUhnGChBfgxirgLrNMfRCIH4l8PvdfywejTRQ+/AwRfi+ /qUNZ1Wujw+KtMwEw4PbVJ7OdwB3xo/ZBKAQl2mVfbs02CPzhhRrQ+QMwNJRJGZt8M+1aVejyQFXL UP7J18i6Hbt5reyA6GeMEu4eX/s6j3KXdVdphrPwyMR5s2Y0pxjpGiyENpuVd4nUqtdTDVQZzSLy4 3p0/aUmSYYW3WiFOGnjV3AwFDYXf13U8txja0xmNI4/1nXhbgZMYcP+66E3aiZZQKEiqnnJmbFLLu 5Z1knVUq72cnB/e07vMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVkzg-000ot7-2n; Tue, 15 Aug 2023 03:45:20 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVk2B-000koK-0q for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Aug 2023 02:43:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=enwKXFTWOfODQavDEhjfrOcKTC8a9tt9QEJ6z2oHSvg=; b=QSnuyUGSJ7zq06umRSiHdMc3QU bh+N/H/ico3YgvExD4RPjuX/9ywN6LGWWOhR7zytV+4XTEfBT4PnjbEzcE0uNNaLI2ENY96K2amd1 RLSM8pTbDCujQpuyxnk59fuflxLxKoL98rQGJu60XgFEZ1IS2vqdTmOuE6pILlWkI5UAY2IPbTZVt RprBOuEdHmUR1/knHOX5ZTWaxZk4K5e9uUdjIJ13KAkwxwjyeoKPWkwPQdPe2lkF8c4QE8CCeq1Nr T+Bs5DF8QGIZ2aAy8s7JNTtSiB0GBuc1JvGtPCe2R1HbBbPN4OxYtemSQ3IVNXUYUZZAOAvUbbv3Z jbbjrAXg==; Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVk27-00BU9O-10 for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 02:43:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A33F96495A; Tue, 15 Aug 2023 02:43:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64589C433C8; Tue, 15 Aug 2023 02:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692067418; bh=7blTAewUXh9WclBQZ+mReosFc6JNCK0kdPIFgrfLNQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bL23djTCRcM7r+1Gp9qSDhPMBmz3x/C4x5iSW4nmvHKAbKinIWMu1gpgCHV4bQVvO iocZQpk1ugrWIBmTlyjBYz5Fvl9hd/E+NoXEsPmh+rGNp31RAAKtoxKTO8IEl0Gwoi uUldRosk0KIrHE/IQPDAjJ8cgdfeDS1VMB+IcNrZrxPJL9JgBvr/jscPaqc7XPbxg1 2aF7Hq0AWIZ7l7eqt7jdapEwypftzA2y2QjPKmz22u2HCEuwNz3EblWVp3FbN0p5RS cYrQr31icAt0/4PEiCaf6+BlAmGP9viia3Y2nGMjQ9XfUPNzOM+9WK2H4UgWY2UNXz CM5OJBRgrf65Q== Date: Mon, 14 Aug 2023 19:43:36 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: <20230814194336.55642f34@kernel.org> In-Reply-To: <20230811200340.577359-3-vadim.fedorenko@linux.dev> References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-3-vadim.fedorenko@linux.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_034347_795588_3A04F3FE X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Aug 2023 21:03:33 +0100 Vadim Fedorenko wrote: > +attribute-sets: > + - > + name: dpll > + enum-name: dpll_a > + attributes: > + - > + name: id > + type: u32 > + value: 1 value: 1 is the default > + - > + name: module-name > + type: string > + - > + name: clock-id > + type: u64 I don't see a pad, you have a u64 without a pad? > + - > + name: mode > + type: u8 It's an enum, should always be u32 or bigger at protocol level. Netlink pads to 4B, you're not saving any space. > + enum: mode > + - > + name: mode-supported > + type: u8 Same. > + enum: mode > + multi-attr: true > + - > + name: lock-status > + type: u8 And here. > + enum: lock-status > + - > + name: temp > + type: s32 > + - > + name: type > + type: u8 And here, etc. Why are all attributes in a single attr space? :( More than half of them are prefixed with a pin- does it really not scream to you that they belong to a different space? > +operations: > + enum-name: dpll_cmd > + list: > + - > + name: device-id-get > + doc: | > + Get id of dpll device that matches given attributes > + value: 1 is the default -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel