From: kernel test robot <lkp@intel.com>
To: linux@treblig.org, smfrench@gmail.com, dave.kleikamp@oracle.com,
tom@talpey.com, pc@manguebit.com
Cc: oe-kbuild-all@lists.linux.dev, linkinjeon@kernel.org,
linux-cifs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org, krisman@collabora.com,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: Re: [PATCH v4 3/4] fs/smb/client: Use common code in client
Date: Mon, 14 Aug 2023 21:47:15 +0800 [thread overview]
Message-ID: <202308142118.G4M0uxEm-lkp@intel.com> (raw)
In-Reply-To: <20230813005344.112955-4-linux@treblig.org>
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on cifs/for-next]
[also build test WARNING on kleikamp-shaggy/jfs-next linus/master v6.5-rc6 next-20230809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/linux-treblig-org/fs-smb-Remove-unicode-lower-tables/20230813-085613
base: git://git.samba.org/sfrench/cifs-2.6.git for-next
patch link: https://lore.kernel.org/r/20230813005344.112955-4-linux%40treblig.org
patch subject: [PATCH v4 3/4] fs/smb/client: Use common code in client
config: i386-randconfig-i062-20230814 (https://download.01.org/0day-ci/archive/20230814/202308142118.G4M0uxEm-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230814/202308142118.G4M0uxEm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308142118.G4M0uxEm-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> fs/smb/client/smb2pdu.c:2573:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] *ucs1 @@ got restricted __le16 [usertype] * @@
fs/smb/client/smb2pdu.c:2573:27: sparse: expected unsigned short [usertype] *ucs1
fs/smb/client/smb2pdu.c:2573:27: sparse: got restricted __le16 [usertype] *
>> fs/smb/client/smb2pdu.c:2573:38: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned short const [usertype] *ucs2 @@ got restricted __le16 const * @@
fs/smb/client/smb2pdu.c:2573:38: sparse: expected unsigned short const [usertype] *ucs2
fs/smb/client/smb2pdu.c:2573:38: sparse: got restricted __le16 const *
fs/smb/client/smb2pdu.c:2574:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] *ucs1 @@ got restricted __le16 [usertype] * @@
fs/smb/client/smb2pdu.c:2574:27: sparse: expected unsigned short [usertype] *ucs1
fs/smb/client/smb2pdu.c:2574:27: sparse: got restricted __le16 [usertype] *
>> fs/smb/client/smb2pdu.c:2574:38: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned short const [usertype] *ucs2 @@ got restricted __le16 const [usertype] *path @@
fs/smb/client/smb2pdu.c:2574:38: sparse: expected unsigned short const [usertype] *ucs2
fs/smb/client/smb2pdu.c:2574:38: sparse: got restricted __le16 const [usertype] *path
vim +2573 fs/smb/client/smb2pdu.c
ff2a09e9196e2f fs/cifs/smb2pdu.c Steve French 2019-07-06 2535
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2536 static int
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2537 alloc_path_with_tree_prefix(__le16 **out_path, int *out_size, int *out_len,
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2538 const char *treename, const __le16 *path)
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2539 {
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2540 int treename_len, path_len;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2541 struct nls_table *cp;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2542 const __le16 sep[] = {cpu_to_le16('\\'), cpu_to_le16(0x0000)};
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2543
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2544 /*
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2545 * skip leading "\\"
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2546 */
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2547 treename_len = strlen(treename);
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2548 if (treename_len < 2 || !(treename[0] == '\\' && treename[1] == '\\'))
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2549 return -EINVAL;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2550
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2551 treename += 2;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2552 treename_len -= 2;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2553
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2554 path_len = UniStrnlen((wchar_t *)path, PATH_MAX);
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2555
a1d2eb51f0a33c fs/cifs/smb2pdu.c Paulo Alcantara 2022-08-19 2556 /* make room for one path separator only if @path isn't empty */
a1d2eb51f0a33c fs/cifs/smb2pdu.c Paulo Alcantara 2022-08-19 2557 *out_len = treename_len + (path[0] ? 1 : 0) + path_len;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2558
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2559 /*
a1d2eb51f0a33c fs/cifs/smb2pdu.c Paulo Alcantara 2022-08-19 2560 * final path needs to be 8-byte aligned as specified in
a1d2eb51f0a33c fs/cifs/smb2pdu.c Paulo Alcantara 2022-08-19 2561 * MS-SMB2 2.2.13 SMB2 CREATE Request.
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2562 */
d7173623bf0b15 fs/cifs/smb2pdu.c Enzo Matsumiya 2022-10-12 2563 *out_size = round_up(*out_len * sizeof(__le16), 8);
a1d2eb51f0a33c fs/cifs/smb2pdu.c Paulo Alcantara 2022-08-19 2564 *out_path = kzalloc(*out_size + sizeof(__le16) /* null */, GFP_KERNEL);
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2565 if (!*out_path)
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2566 return -ENOMEM;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2567
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2568 cp = load_nls_default();
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2569 cifs_strtoUTF16(*out_path, treename, treename_len, cp);
7eacba3b00a3c3 fs/cifs/smb2pdu.c Eugene Korenevsky 2022-01-14 2570
7eacba3b00a3c3 fs/cifs/smb2pdu.c Eugene Korenevsky 2022-01-14 2571 /* Do not append the separator if the path is empty */
7eacba3b00a3c3 fs/cifs/smb2pdu.c Eugene Korenevsky 2022-01-14 2572 if (path[0] != cpu_to_le16(0x0000)) {
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 @2573 UniStrcat(*out_path, sep);
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 @2574 UniStrcat(*out_path, path);
7eacba3b00a3c3 fs/cifs/smb2pdu.c Eugene Korenevsky 2022-01-14 2575 }
7eacba3b00a3c3 fs/cifs/smb2pdu.c Eugene Korenevsky 2022-01-14 2576
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2577 unload_nls(cp);
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2578
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2579 return 0;
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2580 }
f0712928be1a66 fs/cifs/smb2pdu.c Aurelien Aptel 2017-02-22 2581
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-08-14 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 0:53 [PATCH v4 0/4] dedupe smb unicode files linux
2023-08-13 0:53 ` [PATCH v4 1/4] fs/smb: Remove unicode 'lower' tables linux
2023-08-13 0:53 ` [PATCH v4 2/4] fs/smb: Swing unicode common code from smb->NLS linux
2023-08-13 0:53 ` [PATCH v4 3/4] fs/smb/client: Use common code in client linux
2023-08-14 13:47 ` kernel test robot [this message]
2023-08-13 0:53 ` [PATCH v4 4/4] fs/jfs: Use common ucs2 upper case table linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308142118.G4M0uxEm-lkp@intel.com \
--to=lkp@intel.com \
--cc=dave.kleikamp@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=krisman@collabora.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.