Re: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs

[kernel test robot <lkp@intel.com>]

Hi David,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.5-rc6]
[cannot apply to next-20230809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Howells/iov_iter-Convert-iterate-to-inline-funcs/20230811-224036
base:   linus/master
patch link:    https://lore.kernel.org/r/3710261.1691764329%40warthog.procyon.org.uk
patch subject: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs
config: mips-randconfig-r091-20230814 (https://download.01.org/0day-ci/archive/20230815/202308150012.tLtBLImx-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230815/202308150012.tLtBLImx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308150012.tLtBLImx-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> lib/iov_iter.c:162:32: sparse: sparse: incompatible types in comparison expression (different type sizes):
>> lib/iov_iter.c:162:32: sparse:    unsigned int *
>> lib/iov_iter.c:162:32: sparse:    unsigned long *
>> lib/iov_iter.c:162:32: sparse: sparse: cannot size expression

vim +162 lib/iov_iter.c

   133	
   134	static __always_inline
   135	size_t iterate_xarray(struct iov_iter *iter, size_t len, void *priv, __wsum *csum,
   136			      iov_step_f step)
   137	{
   138		struct folio *folio;
   139		size_t progress = 0;
   140		loff_t start = iter->xarray_start + iter->iov_offset;
   141		pgoff_t index = start / PAGE_SIZE;
   142		XA_STATE(xas, iter->xarray, index);
   143	
   144		rcu_read_lock();
   145		xas_for_each(&xas, folio, ULONG_MAX) {
   146			size_t remain, consumed, offset, part, flen;
   147	
   148			if (xas_retry(&xas, folio))
   149				continue;
   150			if (WARN_ON(xa_is_value(folio)))
   151				break;
   152			if (WARN_ON(folio_test_hugetlb(folio)))
   153				break;
   154	
   155			offset = offset_in_folio(folio, start);
   156			flen = min(folio_size(folio) - offset, len);
   157			start += flen;
   158	
   159			while (flen) {
   160				void *base = kmap_local_folio(folio, offset);
   161	
 > 162				part = min(flen, PAGE_SIZE - offset_in_page(offset));
   163				remain = step(base, progress, part, priv, csum);
   164				kunmap_local(base);
   165	
   166				consumed = part - remain;
   167				progress += consumed;
   168				len -= consumed;
   169	
   170				if (remain || len == 0)
   171					goto out;
   172				flen -= consumed;
   173				offset += consumed;
   174			}
   175		}
   176	
   177	out:
   178		rcu_read_unlock();
   179		iter->iov_offset += progress;
   180		iter->count -= progress;
   181		return progress;
   182	}
   183	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki