From: okaya@kernel.org
Cc: dev@dpdk.org, Sinan Kaya <okaya@kernel.org>
Subject: [PATCH v1 2/7] tailq: skip init if already initialized
Date: Mon, 14 Aug 2023 21:38:21 -0400 [thread overview]
Message-ID: <20230815013826.1288972-3-okaya@kernel.org> (raw)
In-Reply-To: <20230815013826.1288972-1-okaya@kernel.org>
From: Sinan Kaya <okaya@kernel.org>
Allows tailq to be reinitialied multiple times
by looking up previously registered tailqs
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
lib/eal/common/eal_common_tailqs.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/lib/eal/common/eal_common_tailqs.c b/lib/eal/common/eal_common_tailqs.c
index 580fbf24bc..3995aa2717 100644
--- a/lib/eal/common/eal_common_tailqs.c
+++ b/lib/eal/common/eal_common_tailqs.c
@@ -73,9 +73,10 @@ rte_eal_tailq_create(const char *name)
strlcpy(head->name, name, sizeof(head->name) - 1);
TAILQ_INIT(&head->tailq_head);
rte_tailqs_count++;
+ return head;
}
- return head;
+ return rte_eal_tailq_lookup(name);
}
/* local register, used to store "early" tailqs before rte_eal_init() and to
@@ -99,7 +100,10 @@ rte_eal_tailq_update(struct rte_tailq_elem *t)
{
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
/* primary process is the only one that creates */
- t->head = rte_eal_tailq_create(t->name);
+ t->head = rte_eal_tailq_lookup(t->name);
+ if (t->head == NULL) {
+ t->head = rte_eal_tailq_create(t->name);
+ }
} else {
t->head = rte_eal_tailq_lookup(t->name);
}
@@ -108,15 +112,13 @@ rte_eal_tailq_update(struct rte_tailq_elem *t)
int
rte_eal_tailq_register(struct rte_tailq_elem *t)
{
- if (rte_eal_tailq_local_register(t) < 0) {
- RTE_LOG(ERR, EAL,
- "%s tailq is already registered\n", t->name);
- goto error;
- }
+ rte_eal_tailq_local_register(t);
/* if a register happens after rte_eal_tailqs_init(), then we can update
* tailq head */
if (rte_tailqs_count >= 0) {
+ RTE_LOG(INFO, EAL,
+ "%s tailq is registered\n", t->name);
rte_eal_tailq_update(t);
if (t->head == NULL) {
RTE_LOG(ERR, EAL,
@@ -138,6 +140,11 @@ rte_eal_tailqs_init(void)
{
struct rte_tailq_elem *t;
+ if (rte_tailqs_count > 0) {
+ RTE_LOG(INFO, EAL, "tailq already initialized \n");
+ return 0;
+ }
+
rte_tailqs_count = 0;
TAILQ_FOREACH(t, &rte_tailq_elem_head, next) {
--
2.25.1
next prev parent reply other threads:[~2023-08-15 1:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 1:38 [PATCH v1 0/7] support reinit flow okaya
2023-08-15 1:38 ` [PATCH v1 1/7] eal: fixes for re-initialization issues okaya
2023-08-15 2:21 ` Stephen Hemminger
2023-08-15 2:24 ` Stephen Hemminger
2023-08-15 1:38 ` okaya [this message]
2023-08-15 2:22 ` [PATCH v1 2/7] tailq: skip init if already initialized Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 3/7] eal_memzone: bail out on initialized okaya
2023-08-15 2:22 ` Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 4/7] memseg: init once okaya
2023-08-15 1:38 ` [PATCH v1 5/7] eal_memory: skip initialization okaya
2023-08-15 1:38 ` [PATCH v1 6/7] eal_interrupts: don't reinitialize threads okaya
2023-08-15 2:20 ` Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 7/7] eal: initialize worker threads once okaya
2023-08-15 2:24 ` Stephen Hemminger
2023-08-15 2:12 ` [PATCH v1 0/7] support reinit flow Stephen Hemminger
2023-08-15 3:12 ` Sinan Kaya
2023-08-15 21:49 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815013826.1288972-3-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.