From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85D8DC001B0 for ; Tue, 15 Aug 2023 16:55:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 38C0B60C16; Tue, 15 Aug 2023 16:55:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 38C0B60C16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692118525; bh=WN9S8Njc2tiAyYvTsvRD2mLgDtiW0AVJLknxGc99Mek=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Ns0fFYWknzOjK498HjpiEMhNAM/pIBp82roQeuxPygALW1gDD3MNLwroHhtJOvMlN gzylkW5FvOsiqMzHpiEEOj9E93NbkD981lcO+yWUIeO1Eg85dZeN5KASPMHB78UBjw LdcBNVvL9BdeOPoKiYSwLfwtUO4wWgMvHQbPHKwJUNMaVDAaWROVT1TWgzf+QhIeOY uFAUxqH/+UJm9syL59Xe1VYPGiJ9UQPdP87Io1tdc/i8te9fH9ahvwy91hotObmP/j 69mpncCKnmf2tIAUSYU7Ey3UZlXSOuKmpoxAA26lS8auCShNPZK06NgLjzfNjrbozn TvoFwAkyER3gQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VtRPuMnszD6X; Tue, 15 Aug 2023 16:55:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 499D260C2B; Tue, 15 Aug 2023 16:55:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 499D260C2B Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 635AE1BF379 for ; Tue, 15 Aug 2023 16:55:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 3BA0E60C2B for ; Tue, 15 Aug 2023 16:55:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3BA0E60C2B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gPlDLK5QD5KU for ; Tue, 15 Aug 2023 16:55:22 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8759C60C16 for ; Tue, 15 Aug 2023 16:55:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8759C60C16 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD5E261ADA; Tue, 15 Aug 2023 16:55:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51967C433CD; Tue, 15 Aug 2023 16:55:20 +0000 (UTC) Date: Tue, 15 Aug 2023 09:55:19 -0700 From: Jakub Kicinski To: Vadim Fedorenko Message-ID: <20230815095519.76d06274@kernel.org> In-Reply-To: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692118520; bh=0NoRpcHZaUX5im0cn9/N12oK9jNQtW6pqx60BrLK0cs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h/qtXebOTThtIYgLdqHqoNRqfFRfa9y/NntkWbmyTvfgyh9BOctmFKj8k3XAsH1JF aoJAGqTrHqidY5JCD+vm0ExK6+BLcxDLSq3p717eHvClBAxkaQSQRbfU1psUYJ74Bd kRbPS0rjZmAdOGYHTHVXNwPnKjpnhSFi0B1wAuRKNJLkChNkLAJtDl052iMqhiYfZN gLXuKq0MKFOl6PONyTJmxtK4SAvnRX8Q7p9ID1pGkSED5bp6y1rmkY83gbeufmn7as b20tSiNqCkYQIn2ljZnydCYVtFoTrK3QNRMZqB4owFbaLyN+qC3eEAVhaUSNzJt1Kk YrHv4JWLD1v1g== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h/qtXebO Subject: Re: [Intel-wired-lan] [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , Bart Van Assche , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, Jiri Pirko , Jonathan Lemon , Paolo Abeni , linux-clk@vger.kernel.org, Milena Olech Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 15 Aug 2023 16:18:16 +0100 Vadim Fedorenko wrote: > On 15/08/2023 04:24, Jakub Kicinski wrote: > > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: > >> + xa_for_each(&pin->dpll_refs, i, ref) { > >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); > >> + struct dpll_device *dpll = ref->dpll; > >> + > >> + if (!ops->frequency_set) > >> + return -EOPNOTSUPP; > >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), > >> + dpll, dpll_priv(dpll), freq, extack); > >> + if (ret) > >> + return ret; > >> + __dpll_pin_change_ntf(pin); > >> + } > > > > only one freq is reported in get, AFAICT, so why send a notification > > after each ref is updated? > > The pin can be technically connected to several DPLLs and app may watch > for the specific DPLL messages only. We would like to inform all users > on any DPLL which has this pin connected to. How does this end up looking in the notifications? __dpll_pin_change_ntf() only takes the pin object, from a quick read it seems like it will generate the same notification multiple times. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C6FC001DE for ; Tue, 15 Aug 2023 16:56:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbjHOQzw (ORCPT ); Tue, 15 Aug 2023 12:55:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238441AbjHOQzY (ORCPT ); Tue, 15 Aug 2023 12:55:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 016C319BF for ; Tue, 15 Aug 2023 09:55:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 701DA65DB2 for ; Tue, 15 Aug 2023 16:55:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51967C433CD; Tue, 15 Aug 2023 16:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692118520; bh=0NoRpcHZaUX5im0cn9/N12oK9jNQtW6pqx60BrLK0cs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h/qtXebOTThtIYgLdqHqoNRqfFRfa9y/NntkWbmyTvfgyh9BOctmFKj8k3XAsH1JF aoJAGqTrHqidY5JCD+vm0ExK6+BLcxDLSq3p717eHvClBAxkaQSQRbfU1psUYJ74Bd kRbPS0rjZmAdOGYHTHVXNwPnKjpnhSFi0B1wAuRKNJLkChNkLAJtDl052iMqhiYfZN gLXuKq0MKFOl6PONyTJmxtK4SAvnRX8Q7p9ID1pGkSED5bp6y1rmkY83gbeufmn7as b20tSiNqCkYQIn2ljZnydCYVtFoTrK3QNRMZqB4owFbaLyN+qC3eEAVhaUSNzJt1Kk YrHv4JWLD1v1g== Date: Tue, 15 Aug 2023 09:55:19 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Message-ID: <20230815095519.76d06274@kernel.org> In-Reply-To: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 15 Aug 2023 16:18:16 +0100 Vadim Fedorenko wrote: > On 15/08/2023 04:24, Jakub Kicinski wrote: > > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: > >> + xa_for_each(&pin->dpll_refs, i, ref) { > >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); > >> + struct dpll_device *dpll = ref->dpll; > >> + > >> + if (!ops->frequency_set) > >> + return -EOPNOTSUPP; > >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), > >> + dpll, dpll_priv(dpll), freq, extack); > >> + if (ret) > >> + return ret; > >> + __dpll_pin_change_ntf(pin); > >> + } > > > > only one freq is reported in get, AFAICT, so why send a notification > > after each ref is updated? > > The pin can be technically connected to several DPLLs and app may watch > for the specific DPLL messages only. We would like to inform all users > on any DPLL which has this pin connected to. How does this end up looking in the notifications? __dpll_pin_change_ntf() only takes the pin object, from a quick read it seems like it will generate the same notification multiple times. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AAD2C001B0 for ; Tue, 15 Aug 2023 16:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PNbg7FUJ9Qb1hv/lXZWSZ1kfr64KzA+k7rrRUs3KDY0=; b=WfmQu5XxDmDkqF et2Qfg9JXb8f+maIIBfTuAKZQGOWLrd2hYyN/XMxXzoOv6Ld+aq2IR030rXAj2kJpU1H5Q8oY/0Ck X7PMSPi8ob1+AVLJ0R6z/vJa+YT6bD4Wjc4oSyH61Ulwe8MFLWZpDqNNaUSCO8THXWNzS3Y2KiJSR vuDREaWzlpOEM+JCRRom3uzyHMuny32GEl34sPsFGmpy7eaqriaidOrgeiP92zM/uLMmDuTw6VtZZ cBhj5hWPtnQ7vTBOzZ9hdPXn9K3FzJ+o4PWV4j3LsApTiYfUG9lh0nFMb34ZHmjmXNsuYacSBq4mJ Cddcapi5L8yroc0/fDBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVxKH-002156-1d; Tue, 15 Aug 2023 16:55:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVxKF-002149-1F for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 16:55:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD5E261ADA; Tue, 15 Aug 2023 16:55:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51967C433CD; Tue, 15 Aug 2023 16:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692118520; bh=0NoRpcHZaUX5im0cn9/N12oK9jNQtW6pqx60BrLK0cs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h/qtXebOTThtIYgLdqHqoNRqfFRfa9y/NntkWbmyTvfgyh9BOctmFKj8k3XAsH1JF aoJAGqTrHqidY5JCD+vm0ExK6+BLcxDLSq3p717eHvClBAxkaQSQRbfU1psUYJ74Bd kRbPS0rjZmAdOGYHTHVXNwPnKjpnhSFi0B1wAuRKNJLkChNkLAJtDl052iMqhiYfZN gLXuKq0MKFOl6PONyTJmxtK4SAvnRX8Q7p9ID1pGkSED5bp6y1rmkY83gbeufmn7as b20tSiNqCkYQIn2ljZnydCYVtFoTrK3QNRMZqB4owFbaLyN+qC3eEAVhaUSNzJt1Kk YrHv4JWLD1v1g== Date: Tue, 15 Aug 2023 09:55:19 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Message-ID: <20230815095519.76d06274@kernel.org> In-Reply-To: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_095523_515473_7DEE46BB X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Aug 2023 16:18:16 +0100 Vadim Fedorenko wrote: > On 15/08/2023 04:24, Jakub Kicinski wrote: > > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: > >> + xa_for_each(&pin->dpll_refs, i, ref) { > >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); > >> + struct dpll_device *dpll = ref->dpll; > >> + > >> + if (!ops->frequency_set) > >> + return -EOPNOTSUPP; > >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), > >> + dpll, dpll_priv(dpll), freq, extack); > >> + if (ret) > >> + return ret; > >> + __dpll_pin_change_ntf(pin); > >> + } > > > > only one freq is reported in get, AFAICT, so why send a notification > > after each ref is updated? > > The pin can be technically connected to several DPLLs and app may watch > for the specific DPLL messages only. We would like to inform all users > on any DPLL which has this pin connected to. How does this end up looking in the notifications? __dpll_pin_change_ntf() only takes the pin object, from a quick read it seems like it will generate the same notification multiple times. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel