From: Leon Romanovsky <leon@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: hns3: Support tlv in regs data for HNS3 PF driver
Date: Tue, 15 Aug 2023 21:26:10 +0300 [thread overview]
Message-ID: <20230815182610.GQ22185@unreal> (raw)
In-Reply-To: <20230815060641.3551665-3-shaojijie@huawei.com>
On Tue, Aug 15, 2023 at 02:06:39PM +0800, Jijie Shao wrote:
> The dump register function is being refactored.
> The second step in refactoring is to support tlv info in regs data for
> HNS3 PF driver.
>
> Currently, if we use "ethtool -d" to dump regs value,
> the output is as follows:
> offset1: 00 01 02 03 04 05 ...
> offset2：10 11 12 13 14 15 ...
> ......
>
> We can't get the value of a register directly.
>
> This patch deletes the original separator information and
> add tag_len_value information in regs data.
> ethtool can parse register data in key-value format by -d command.
>
> a patch will be added to the ethtool to parse regs data
> in the following format:
> reg1 : value2
> reg2 : value2
> ......
>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
> .../hisilicon/hns3/hns3pf/hclge_regs.c | 167 +++++++++++-------
> 1 file changed, 102 insertions(+), 65 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-08-15 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 6:06 [PATCH net-next 0/4] refactor registers information for ethtool -d Jijie Shao
2023-08-15 6:06 ` [PATCH net-next 1/4] net: hns3: move dump regs function to a separate file Jijie Shao
2023-08-15 18:25 ` Leon Romanovsky
2023-08-15 6:06 ` [PATCH net-next 2/4] net: hns3: Support tlv in regs data for HNS3 PF driver Jijie Shao
2023-08-15 18:26 ` Leon Romanovsky [this message]
2023-08-15 6:06 ` [PATCH net-next 3/4] net: hns3: Support tlv in regs data for HNS3 VF driver Jijie Shao
2023-08-15 18:26 ` Leon Romanovsky
2023-08-15 6:06 ` [PATCH net-next 4/4] net: hns3: fix wrong rpu tln reg issue Jijie Shao
2023-08-15 18:26 ` Leon Romanovsky
2023-08-16 9:00 ` [PATCH net-next 0/4] refactor registers information for ethtool -d patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815182610.GQ22185@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.