From: Atul Kumar Pant <atulpant.linux@gmail.com>
To: oneukum@suse.com, gregkh@linuxfoundation.org
Cc: Atul Kumar Pant <atulpant.linux@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah@kernel.org
Subject: [PATCH v1] kernel: usb: Adds space, removes trailing whitespace and fixes pointer declaration.
Date: Wed, 16 Aug 2023 02:18:41 +0530 [thread overview]
Message-ID: <20230815204841.52600-1-atulpant.linux@gmail.com> (raw)
This patch fixes following checkpatch.pl issue:
ERROR: space required before the open parenthesis '('
ERROR: trailing whitespace
ERROR: space required after that ','
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---
drivers/usb/class/cdc-acm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 11da5fb284d0..638c9cdaa041 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -203,7 +203,7 @@ static int acm_wb_is_avail(struct acm *acm)
n = ACM_NW;
spin_lock_irqsave(&acm->write_lock, flags);
for (i = 0; i < ACM_NW; i++)
- if(acm->wb[i].use)
+ if (acm->wb[i].use)
n--;
spin_unlock_irqrestore(&acm->write_lock, flags);
return n;
@@ -1006,7 +1006,7 @@ static int wait_serial_change(struct acm *acm, unsigned long arg)
}
} while (!rv);
-
+
return rv;
}
@@ -1257,7 +1257,7 @@ static int acm_probe(struct usb_interface *intf,
if (control_interface == data_interface) {
/* some broken devices designed for windows work this way */
- dev_warn(&intf->dev,"Control and data interfaces are not separated!\n");
+ dev_warn(&intf->dev, "Control and data interfaces are not separated!\n");
combined_interfaces = 1;
/* a popular other OS doesn't use it */
quirks |= NO_CAP_LINE;
@@ -1428,7 +1428,7 @@ static int acm_probe(struct usb_interface *intf,
goto err_free_write_urbs;
if (h.usb_cdc_country_functional_desc) { /* export the country data */
- struct usb_cdc_country_functional_desc * cfd =
+ struct usb_cdc_country_functional_desc *cfd =
h.usb_cdc_country_functional_desc;
acm->country_codes = kmalloc(cfd->bLength - 4, GFP_KERNEL);
--
2.25.1
next reply other threads:[~2023-08-15 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 20:48 Atul Kumar Pant [this message]
2023-08-15 21:04 ` [PATCH v1] kernel: usb: Adds space, removes trailing whitespace and fixes pointer declaration Greg KH
2023-08-16 2:48 ` Atul Kumar Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815204841.52600-1-atulpant.linux@gmail.com \
--to=atulpant.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.