From: Atul Kumar Pant <atulpant.linux@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: eparis@redhat.com, audit@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v1] kernel: Add space before parenthesis and around '=', "==" and '<'
Date: Wed, 16 Aug 2023 08:25:50 +0530 [thread overview]
Message-ID: <20230816025550.GD57274@atom0118> (raw)
In-Reply-To: <aecb4e94bc65928c674b6a083e7fd489.paul@paul-moore.com>
On Tue, Aug 15, 2023 at 06:09:19PM -0400, Paul Moore wrote:
> On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@gmail.com> wrote:
> >
> > Fixes following checkpatch.pl issue:
> > ERROR: space required before the open parenthesis '('
> > ERROR: spaces required around that '='
> > ERROR: spaces required around that '<'
> > ERROR: spaces required around that '=='
> >
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > ---
> > kernel/acct.c | 2 +-
> > kernel/auditfilter.c | 16 ++++++++--------
> > kernel/auditsc.c | 2 +-
> > 3 files changed, 10 insertions(+), 10 deletions(-)
>
> I changed the subject line to "audit: add space before parenthesis and
> around '=', "==", and '<'" as the "audit:" prefix is more appropriate
> and I'm a believer of the Oxford Comma. Otherwise it looks fine and I
> just merged it into audit/next, thanks.
Thank you for your comments. Do I need to change commit message now?
>
> --
> paul-moore.com
next prev parent reply other threads:[~2023-08-16 2:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 20:45 [PATCH v1] kernel: Add space before parenthesis and around '=', "==" and '<' Atul Kumar Pant
2023-08-15 22:09 ` Paul Moore
2023-08-16 2:55 ` Atul Kumar Pant [this message]
2023-08-16 13:38 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816025550.GD57274@atom0118 \
--to=atulpant.linux@gmail.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.