All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Dean Luick <dean.luick@cornelisnetworks.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Subject: [cornelisnetworks:for-upstream_20230815 22/26] drivers/infiniband/hw/hfi1/chip_gen.c:13:6: warning: no previous prototype for 'gen_setextled'
Date: Wed, 16 Aug 2023 09:33:50 +0800	[thread overview]
Message-ID: <202308160959.nYVbHANG-lkp@intel.com> (raw)

tree:   https://github.com/cornelisnetworks/linux.git for-upstream_20230815
head:   5536d462af3f2f64d807c8f142bace179036dd1e
commit: 67101d56b7cf4dcd019e447fccb325ca55bd98bf [22/26] RDMA/hfi1: Add JKR external LED functions
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230816/202308160959.nYVbHANG-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230816/202308160959.nYVbHANG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308160959.nYVbHANG-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/infiniband/hw/hfi1/chip_gen.c:13:6: warning: no previous prototype for 'gen_setextled' [-Wmissing-prototypes]
      13 | void gen_setextled(struct hfi1_pportdata *ppd, u32 on)
         |      ^~~~~~~~~~~~~
>> drivers/infiniband/hw/hfi1/chip_gen.c:23:6: warning: no previous prototype for 'gen_start_led_override' [-Wmissing-prototypes]
      23 | void gen_start_led_override(struct hfi1_pportdata *ppd, unsigned int timeon,
         |      ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/infiniband/hw/hfi1/chip_gen.c:39:6: warning: no previous prototype for 'gen_shutdown_led_override' [-Wmissing-prototypes]
      39 | void gen_shutdown_led_override(struct hfi1_pportdata *ppd)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/gen_setextled +13 drivers/infiniband/hw/hfi1/chip_gen.c

     9	
    10	/*
    11	 * Control the port LED state.  Cancel with gen_shutdown_led_override().
    12	 */
  > 13	void gen_setextled(struct hfi1_pportdata *ppd, u32 on)
    14	{
    15		/* XXX Replace with a CPORT message */
    16		dd_dev_warn(ppd->dd, "%s: on %d, JKR TODO\n", __func__, on);
    17	}
    18	
    19	/*
    20	 * Make the port LED blink in pattern.  Parameters timeon and timeoff are
    21	 * in milliseconds.  Cancel with gen_shutdown_led_override().
    22	 */
  > 23	void gen_start_led_override(struct hfi1_pportdata *ppd, unsigned int timeon,
    24				    unsigned int timeoff)
    25	{
    26		/* XXX Replace with a CPORT message */
    27		dd_dev_warn(ppd->dd, "%s: JKR TODO\n", __func__);
    28	
    29		/* used by the subnet manager to know if it set beaconing */
    30		atomic_set(&ppd->led_override_timer_active, 1);
    31		/* ensure the atomic_set is visible to all CPUs */
    32		smp_wmb();
    33	}
    34	
    35	/*
    36	 * Return to normal LED operation.  This cancels overrides started with
    37	 * gen_setextled() or gen_start_led_override().
    38	 */
  > 39	void gen_shutdown_led_override(struct hfi1_pportdata *ppd)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-08-16  1:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308160959.nYVbHANG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dean.luick@cornelisnetworks.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.