From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EF6C25B4F for ; Wed, 16 Aug 2023 20:39:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346179AbjHPUjQ (ORCPT ); Wed, 16 Aug 2023 16:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346192AbjHPUjA (ORCPT ); Wed, 16 Aug 2023 16:39:00 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 742792708 for ; Wed, 16 Aug 2023 13:38:59 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1bdf98a6086so18498695ad.0 for ; Wed, 16 Aug 2023 13:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692218339; x=1692823139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mebqjsm4NZp8ScdZvCRAS9NYd++02rPC44UvNuMOWag=; b=B+9GwZKIjimcZET39jiEv3WT0GoLENkoUfDXOud4xZGq1bLQ1uxHedO/2+FXbu7uVA Y9WlkpPr4WpBzxpKyuS8Pvf+B1kG+L9oA4H2PNzOk4n1hZl3E0VlEt2/uWNI9vGw0Lv1 Uug01LJbx6MbgyC/oVAaHSUyikQJHyIlZe/Q0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692218339; x=1692823139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mebqjsm4NZp8ScdZvCRAS9NYd++02rPC44UvNuMOWag=; b=LHehgJ6sYs06O7t5dWMfPZuOLEBgM+TIuXWpJyiyc2u5bHeBDXgn4FVbGl+S8t8jOc hcw8S16a5IqZADnVPWbcO6qlL90J3x47aMjh/pKqHdpwvEM1tNF8qO2J8qkk9qgsnzDY ZDLgA9vHymsIEjEvy/Jrp9KC3ccGGQR8uv6sZweRCGsPxHorsjaPVGlqzqUNEvRWYifn CuWLj+C079ntfsfz0ZgtvW4zZ3NKdivDsMCqMjmjmoArNPOuKP4OUV7E/3wJbz9n7ZqN 0N01BrEE3rTZHiHWpv7rM+2WG9lJgXNY66Jy7w4VPL0STvLxpK5NWjSEzgi817a+SE4h kuug== X-Gm-Message-State: AOJu0Yz7lZRG80CvkjIx+YGwKZmI5MD1m8nqbd3LBHDQ6BsnuLg3fQcm X+3ma0V3ZdMn4dtGY9qtvrg8R/6r1WKMy7EgoTw= X-Google-Smtp-Source: AGHT+IH8TNVv8K24tYufYWfhj6FReA3GRy3bUNjldrAPON0uLm7g+SZDkIHCoYjL1zNAe1G0wAMRyA== X-Received: by 2002:a17:902:c94e:b0:1bb:598a:14e5 with SMTP id i14-20020a170902c94e00b001bb598a14e5mr2728850pla.43.1692218338963; Wed, 16 Aug 2023 13:38:58 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id f10-20020a170902ce8a00b001b7fd27144dsm13607893plg.40.2023.08.16.13.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 13:38:58 -0700 (PDT) Date: Wed, 16 Aug 2023 13:38:58 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Ben Skeggs , Karol Herbst , Lyude Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional Message-ID: <202308161338.C7162E7@keescook> References: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, Aug 16, 2023 at 12:05:06PM -0600, Gustavo A. R. Silva wrote: > Fix checkpatch.pl ERROR: do not use assignment in if condition. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AB80C27C41 for ; Wed, 16 Aug 2023 20:39:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16BD810E3B8; Wed, 16 Aug 2023 20:39:02 +0000 (UTC) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60F9010E3B8 for ; Wed, 16 Aug 2023 20:38:59 +0000 (UTC) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bee82fab5aso13733495ad.3 for ; Wed, 16 Aug 2023 13:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692218339; x=1692823139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mebqjsm4NZp8ScdZvCRAS9NYd++02rPC44UvNuMOWag=; b=B+9GwZKIjimcZET39jiEv3WT0GoLENkoUfDXOud4xZGq1bLQ1uxHedO/2+FXbu7uVA Y9WlkpPr4WpBzxpKyuS8Pvf+B1kG+L9oA4H2PNzOk4n1hZl3E0VlEt2/uWNI9vGw0Lv1 Uug01LJbx6MbgyC/oVAaHSUyikQJHyIlZe/Q0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692218339; x=1692823139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mebqjsm4NZp8ScdZvCRAS9NYd++02rPC44UvNuMOWag=; b=kDANlmSY7/MKGk51gg6v+hk+JDqbGwJBqXwYjamdYVpZrUTA3SirZWCEwmde8kxHEi tx0tmacGJe7mAW8KNL4a6jEgDg2nbK+LjaB/04PAvov7rq/gCrLCcKM/y1UyDPOd3hIp Crb0ovt4xOfVhcf2uY/0TojbE4SOLhLBXAya4ZPdmPOHoXgtGWdKf3YlNAG6C+TW1N6G VsgDth8cV/JvQpqp51gHTMlJ7MOfBCVz0AEB+4eG8YXIu9rGKzve7F+RWoECvUBF9RR+ blERv6ibYggscTqiuuxcQd1rC3OuI0uTw0Z5C/Dno3GIaL/DUbwK+i1twNG3VsmKsFIP leJQ== X-Gm-Message-State: AOJu0YwRrBcIAl32ZnFdxXbbG/CjyjAR2JOt5Edz2ozAzcLPLmZ0g2gh cfUXVDecW5Yj5tCu4FaZy0osmQ== X-Google-Smtp-Source: AGHT+IH8TNVv8K24tYufYWfhj6FReA3GRy3bUNjldrAPON0uLm7g+SZDkIHCoYjL1zNAe1G0wAMRyA== X-Received: by 2002:a17:902:c94e:b0:1bb:598a:14e5 with SMTP id i14-20020a170902c94e00b001bb598a14e5mr2728850pla.43.1692218338963; Wed, 16 Aug 2023 13:38:58 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id f10-20020a170902ce8a00b001b7fd27144dsm13607893plg.40.2023.08.16.13.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 13:38:58 -0700 (PDT) Date: Wed, 16 Aug 2023 13:38:58 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Message-ID: <202308161338.C7162E7@keescook> References: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org> Subject: Re: [Nouveau] [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs , Daniel Vetter , linux-hardening@vger.kernel.org Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Aug 16, 2023 at 12:05:06PM -0600, Gustavo A. R. Silva wrote: > Fix checkpatch.pl ERROR: do not use assignment in if condition. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B8B6C27C41 for ; Wed, 16 Aug 2023 20:39:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E79210E3B7; Wed, 16 Aug 2023 20:39:01 +0000 (UTC) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6164010E3B9 for ; Wed, 16 Aug 2023 20:38:59 +0000 (UTC) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1bee82fab5aso13733485ad.3 for ; Wed, 16 Aug 2023 13:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692218339; x=1692823139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mebqjsm4NZp8ScdZvCRAS9NYd++02rPC44UvNuMOWag=; b=B+9GwZKIjimcZET39jiEv3WT0GoLENkoUfDXOud4xZGq1bLQ1uxHedO/2+FXbu7uVA Y9WlkpPr4WpBzxpKyuS8Pvf+B1kG+L9oA4H2PNzOk4n1hZl3E0VlEt2/uWNI9vGw0Lv1 Uug01LJbx6MbgyC/oVAaHSUyikQJHyIlZe/Q0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692218339; x=1692823139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mebqjsm4NZp8ScdZvCRAS9NYd++02rPC44UvNuMOWag=; b=KALmGwVyEWUocqMyl+beENZ4/rVCiVKutYwKXyjsI99Rjqoh9AEGnD4fhkS9HNyzHF L5sXhfn6lGcNy+WunOV6Q9BsorkVJCFD6D1/C2lYT1IUX95welgHhJIzCnXlT01NjVc4 cHvBdXcpt4Z5gZgS9CC1kgzCuX/q/d69VkeS4OH3tUmsoddTxiw/meiodLsxCoolM7G5 k8SGKAvYOpGW0DI7WDKbF95P580QeSbr4VGynV5v4X7FnChLUPGAt7VKLgzo2+v29kQb XLvGY/OBrbQlldGlQLY67/XP2yj0aZ9jx0srB7vtdq6oaFfOOkVCa/dJsG3PkzLekwZV q+5g== X-Gm-Message-State: AOJu0YykOHEHFOXzSfDknubCIcOcAbahD9r2C2PDPE8yThRM9U4sZx4b gP9APO0qblyObwHJq9I2N1HcLQ== X-Google-Smtp-Source: AGHT+IH8TNVv8K24tYufYWfhj6FReA3GRy3bUNjldrAPON0uLm7g+SZDkIHCoYjL1zNAe1G0wAMRyA== X-Received: by 2002:a17:902:c94e:b0:1bb:598a:14e5 with SMTP id i14-20020a170902c94e00b001bb598a14e5mr2728850pla.43.1692218338963; Wed, 16 Aug 2023 13:38:58 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id f10-20020a170902ce8a00b001b7fd27144dsm13607893plg.40.2023.08.16.13.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 13:38:58 -0700 (PDT) Date: Wed, 16 Aug 2023 13:38:58 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Subject: Re: [PATCH 2/2][next] nouveau/svm: Split assignment from if conditional Message-ID: <202308161338.C7162E7@keescook> References: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b900e80b5587187c68efc788f5b042ca747d374.1692208802.git.gustavoars@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs , linux-hardening@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Aug 16, 2023 at 12:05:06PM -0600, Gustavo A. R. Silva wrote: > Fix checkpatch.pl ERROR: do not use assignment in if condition. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook