From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41DDC2FC14 for ; Thu, 17 Aug 2023 06:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347239AbjHQG45 (ORCPT ); Thu, 17 Aug 2023 02:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348333AbjHQG4x (ORCPT ); Thu, 17 Aug 2023 02:56:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23F8F1FF3; Wed, 16 Aug 2023 23:56:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 940F563CF6; Thu, 17 Aug 2023 06:56:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B884AC433C8; Thu, 17 Aug 2023 06:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692255411; bh=JKi+meRqZX/8UsgXnMaQA/rgBXUj+9Xf7F21WE4jfi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O1ZhxIhknpoHs6tOzMIpy2RDgtvvJBEtxMeyo4St7zs/Czf1JiK6YxyKSg97SlklO oDKoEA588mGo8RWAatxMxA9KqFgIbLCaFCEjrw8987r01ydVlVf9dVdfO56j/2IhZe gkkXT2H6PKRwMJ4+V+O9smk8R5TGauGe/fIX4l3cgNxdthZhtNNrjjDRyUsFIVG44v 4mPJwn6LikDx07xBBe9O9tNvgmSBor2w2rIOYKzdQmeT4QDVLwqPKPlUq3H83fm6p6 6LON+TZNSWhOQ27g2LeCkjeRUkpGWwDApGg8uGVm+EHa2Ufo7FujZUoafi10xqr1qG M9XEhYlrt4MUg== Date: Thu, 17 Aug 2023 12:26:41 +0530 From: Manivannan Sadhasivam To: Justin Stitt Cc: Vinod Koul , Andreas =?iso-8859-1?Q?F=E4rber?= , Nathan Chancellor , Nick Desaulniers , Tom Rix , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] dmaengine: owl-dma: fix clang -Wvoid-pointer-to-enum-cast warning Message-ID: <20230817065641.GA4864@thinkpad> References: <20230816-void-drivers-dma-owl-dma-v1-1-a0a5e085e937@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816-void-drivers-dma-owl-dma-v1-1-a0a5e085e937@google.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, Aug 16, 2023 at 08:12:50PM +0000, Justin Stitt wrote: > When building with clang 18 I see the following warning: > | drivers/dma/owl-dma.c:1119:14: warning: cast to smaller integer type > | 'enum owl_dma_id' from 'const void *' [-Wvoid-pointer-to-enum-cast] > | 1119 | od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); > > This is due to the fact that `of_device_get_match_data()` returns a > void* while `enum owl_dma_id` has the size of an int. > > Cast result of `of_device_get_match_data()` to a uintptr_t to silence > the above warning for clang builds using W=1 > > Link: https://github.com/ClangBuiltLinux/linux/issues/1910 > Reported-by: Nathan Chancellor > Signed-off-by: Justin Stitt Acked-by: Manivannan Sadhasivam - Mani > --- > drivers/dma/owl-dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c > index b6e0ac8314e5..f340a04579f4 100644 > --- a/drivers/dma/owl-dma.c > +++ b/drivers/dma/owl-dma.c > @@ -1116,7 +1116,7 @@ static int owl_dma_probe(struct platform_device *pdev) > dev_info(&pdev->dev, "dma-channels %d, dma-requests %d\n", > nr_channels, nr_requests); > > - od->devid = (enum owl_dma_id)of_device_get_match_data(&pdev->dev); > + od->devid = (uintptr_t)of_device_get_match_data(&pdev->dev); > > od->nr_pchans = nr_channels; > od->nr_vchans = nr_requests; > > --- > base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421 > change-id: 20230816-void-drivers-dma-owl-dma-41b95a098275 > > Best regards, > -- > Justin Stitt > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 313C4C2FC0E for ; Thu, 17 Aug 2023 06:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E9S5wTMQpDamOuFjPW+7E1B49OFgTw2X4Ly0wi8idaI=; b=I28iwwMwIhxGKj DKIizrnqlN7xDO58sZSf2pnO7av0RvyiZ61qpRYHqQwR6xpz2mDSrGb/fD50R2jkLyKB8UejV3qes RBtC4kexeevP0iRJQ0XtN3wR5SuPuhseo6+3ryVdvjZGD+GS54AVjpQb58sZZ0MaB2VwJx2tmftLL lXHlszEoZCfDwgtelXc/NH/67EtHVTVAeesQXx7uSeOgnRZ1f6M3w+2dSSo5/UejGZiq3tKZwOSTL vjiOP503XTqra3w9O4groOSra/4hh9kMTBCsCxbRJSGhe0IaQIwwwfesqwB0hK0KfU+nLQNFq/pHi MFWVKW9NHVSql/B1NIeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWWwC-005g3L-1S; Thu, 17 Aug 2023 06:56:56 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWWw9-005g2l-39; Thu, 17 Aug 2023 06:56:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93F8B63B45; Thu, 17 Aug 2023 06:56:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B884AC433C8; Thu, 17 Aug 2023 06:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692255411; bh=JKi+meRqZX/8UsgXnMaQA/rgBXUj+9Xf7F21WE4jfi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O1ZhxIhknpoHs6tOzMIpy2RDgtvvJBEtxMeyo4St7zs/Czf1JiK6YxyKSg97SlklO oDKoEA588mGo8RWAatxMxA9KqFgIbLCaFCEjrw8987r01ydVlVf9dVdfO56j/2IhZe gkkXT2H6PKRwMJ4+V+O9smk8R5TGauGe/fIX4l3cgNxdthZhtNNrjjDRyUsFIVG44v 4mPJwn6LikDx07xBBe9O9tNvgmSBor2w2rIOYKzdQmeT4QDVLwqPKPlUq3H83fm6p6 6LON+TZNSWhOQ27g2LeCkjeRUkpGWwDApGg8uGVm+EHa2Ufo7FujZUoafi10xqr1qG M9XEhYlrt4MUg== Date: Thu, 17 Aug 2023 12:26:41 +0530 From: Manivannan Sadhasivam To: Justin Stitt Cc: Vinod Koul , Andreas =?iso-8859-1?Q?F=E4rber?= , Nathan Chancellor , Nick Desaulniers , Tom Rix , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] dmaengine: owl-dma: fix clang -Wvoid-pointer-to-enum-cast warning Message-ID: <20230817065641.GA4864@thinkpad> References: <20230816-void-drivers-dma-owl-dma-v1-1-a0a5e085e937@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230816-void-drivers-dma-owl-dma-v1-1-a0a5e085e937@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230816_235654_081963_04BF0FD8 X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMTYsIDIwMjMgYXQgMDg6MTI6NTBQTSArMDAwMCwgSnVzdGluIFN0aXR0IHdy b3RlOgo+IFdoZW4gYnVpbGRpbmcgd2l0aCBjbGFuZyAxOCBJIHNlZSB0aGUgZm9sbG93aW5nIHdh cm5pbmc6Cj4gfCAgICAgICBkcml2ZXJzL2RtYS9vd2wtZG1hLmM6MTExOToxNDogd2FybmluZzog Y2FzdCB0byBzbWFsbGVyIGludGVnZXIgdHlwZQo+IHwgICAgICAgJ2VudW0gb3dsX2RtYV9pZCcg ZnJvbSAnY29uc3Qgdm9pZCAqJyBbLVd2b2lkLXBvaW50ZXItdG8tZW51bS1jYXN0XQo+IHwgICAg ICAgIDExMTkgfCBvZC0+ZGV2aWQgPSAoZW51bSBvd2xfZG1hX2lkKW9mX2RldmljZV9nZXRfbWF0 Y2hfZGF0YSgmcGRldi0+ZGV2KTsKPiAKPiBUaGlzIGlzIGR1ZSB0byB0aGUgZmFjdCB0aGF0IGBv Zl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKWAgcmV0dXJucyBhCj4gdm9pZCogd2hpbGUgYGVudW0g b3dsX2RtYV9pZGAgaGFzIHRoZSBzaXplIG9mIGFuIGludC4KPiAKPiBDYXN0IHJlc3VsdCBvZiBg b2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKClgIHRvIGEgdWludHB0cl90IHRvIHNpbGVuY2UKPiB0 aGUgYWJvdmUgd2FybmluZyBmb3IgY2xhbmcgYnVpbGRzIHVzaW5nIFc9MQo+IAo+IExpbms6IGh0 dHBzOi8vZ2l0aHViLmNvbS9DbGFuZ0J1aWx0TGludXgvbGludXgvaXNzdWVzLzE5MTAKPiBSZXBv cnRlZC1ieTogTmF0aGFuIENoYW5jZWxsb3IgPG5hdGhhbkBrZXJuZWwub3JnPgo+IFNpZ25lZC1v ZmYtYnk6IEp1c3RpbiBTdGl0dCA8anVzdGluc3RpdHRAZ29vZ2xlLmNvbT4KCkFja2VkLWJ5OiBN YW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbmlAa2VybmVsLm9yZz4KCi0gTWFuaQoKPiAtLS0KPiAg ZHJpdmVycy9kbWEvb3dsLWRtYS5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvb3dsLWRt YS5jIGIvZHJpdmVycy9kbWEvb3dsLWRtYS5jCj4gaW5kZXggYjZlMGFjODMxNGU1Li5mMzQwYTA0 NTc5ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEvb3dsLWRtYS5jCj4gKysrIGIvZHJpdmVy cy9kbWEvb3dsLWRtYS5jCj4gQEAgLTExMTYsNyArMTExNiw3IEBAIHN0YXRpYyBpbnQgb3dsX2Rt YV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJZGV2X2luZm8oJnBkZXYt PmRldiwgImRtYS1jaGFubmVscyAlZCwgZG1hLXJlcXVlc3RzICVkXG4iLAo+ICAJCSBucl9jaGFu bmVscywgbnJfcmVxdWVzdHMpOwo+ICAKPiAtCW9kLT5kZXZpZCA9IChlbnVtIG93bF9kbWFfaWQp b2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKCZwZGV2LT5kZXYpOwo+ICsJb2QtPmRldmlkID0gKHVp bnRwdHJfdClvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4gIAo+ICAJb2Qt Pm5yX3BjaGFucyA9IG5yX2NoYW5uZWxzOwo+ICAJb2QtPm5yX3ZjaGFucyA9IG5yX3JlcXVlc3Rz Owo+IAo+IC0tLQo+IGJhc2UtY29tbWl0OiAyY2NkZDFiMTNjNTkxZDMwNmYwNDAxZDk4ZGVkYzRi ZGNkMDJiNDIxCj4gY2hhbmdlLWlkOiAyMDIzMDgxNi12b2lkLWRyaXZlcnMtZG1hLW93bC1kbWEt NDFiOTVhMDk4Mjc1Cj4gCj4gQmVzdCByZWdhcmRzLAo+IC0tCj4gSnVzdGluIFN0aXR0IDxqdXN0 aW5zdGl0dEBnb29nbGUuY29tPgo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDg rprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK