From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Wolfram Sang <wsa@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: Make I2C_ATR invisible
Date: Thu, 17 Aug 2023 09:45:12 +0200 [thread overview]
Message-ID: <20230817094512.38b3d45b@booty> (raw)
In-Reply-To: <588d302477cb7e6b30b52ee6448807324c57b88a.1692113321.git.geert+renesas@glider.be>
Hi Geert,
On Tue, 15 Aug 2023 17:29:11 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> I2C Address Translator (ATR) support is not a stand-alone driver, but a
> library. All of its users select I2C_ATR. Hence there is no need for
> the user to enable this symbol manually, except when compile-testing.
>
> Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Do we care yet about out-of-tree drivers that need this functionality?
> ---
> drivers/i2c/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index c6d1a345ea6d8aee..9388823bb0bb960c 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -72,7 +72,7 @@ config I2C_MUX
> source "drivers/i2c/muxes/Kconfig"
>
> config I2C_ATR
> - tristate "I2C Address Translator (ATR) support"
> + tristate "I2C Address Translator (ATR) support" if COMPILE_TEST
Either as-is, or with an anonymous tristate:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-08-17 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 15:29 [PATCH] i2c: Make I2C_ATR invisible Geert Uytterhoeven
2023-08-15 15:59 ` Tomi Valkeinen
2023-08-16 8:17 ` Geert Uytterhoeven
2023-08-16 8:27 ` Tomi Valkeinen
2023-08-17 7:45 ` Luca Ceresoli [this message]
2023-08-17 10:29 ` Tomi Valkeinen
2023-08-25 21:16 ` Wolfram Sang
2023-09-13 8:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817094512.38b3d45b@booty \
--to=luca.ceresoli@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.