From: Jakub Kicinski <kuba@kernel.org>
To: "Martin Hundebøll" <martin@geanix.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] can: netlink: support setting hardware filters
Date: Thu, 17 Aug 2023 09:45:29 -0700 [thread overview]
Message-ID: <20230817094529.68ae1083@kernel.org> (raw)
In-Reply-To: <20230817101014.3484715-2-martin@geanix.com>
On Thu, 17 Aug 2023 12:10:13 +0200 Martin Hundebøll wrote:
> + int len = nla_len(data[IFLA_CAN_HW_FILTER]);
> + int num_filter = len / sizeof(struct can_filter);
> + struct can_filter *filter = nla_data(data[IFLA_CAN_HW_FILTER]);
This will prevent you from ever extending struct can_filter in
a backward-compatible fashion, right? I obviously know very little
about CAN but are you confident a more bespoke API to manipulate
filters individually and allow extensibility is not warranted?
next prev parent reply other threads:[~2023-08-17 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 10:10 [PATCH 0/2] can: per-device hardware filter support Martin Hundebøll
2023-08-17 10:10 ` [PATCH 1/2] can: netlink: support setting hardware filters Martin Hundebøll
2023-08-17 16:45 ` Jakub Kicinski [this message]
2023-08-19 13:10 ` Vincent Mailhol
2023-08-19 13:29 ` Vincent Mailhol
2023-08-20 19:20 ` Oliver Hartkopp
2023-08-21 16:50 ` Vincent Mailhol
2023-08-17 10:10 ` [PATCH 2/2] can: m_can: support setting hw filters Martin Hundebøll
2023-08-17 10:37 ` [PATCH 0/2] can: per-device hardware filter support Oliver Hartkopp
2023-08-17 11:05 ` [PATCH] can: ip: support hw-filter setting Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817094529.68ae1083@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@geanix.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.