All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: oe-kbuild-all@lists.linux.dev,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Ogness <john.ogness@linutronix.de>
Subject: [rt-devel:linux-6.5.y-rt 31/87] kernel/printk/printk_nobkl.c:1029: warning: Function parameter or member 'unsafe' not described in '__console_update_unsafe'
Date: Thu, 17 Aug 2023 14:07:05 +0800	[thread overview]
Message-ID: <202308171313.el16bGIc-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-6.5.y-rt
head:   16ae0de52ef9f7e5c2cd7e8443f5195c176353ea
commit: aa998c7010a5fb980abe598fc1e34ad69da6dd44 [31/87] printk: nobkl: Add print state functions
config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20230817/202308171313.el16bGIc-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171313.el16bGIc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171313.el16bGIc-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/printk/printk_nobkl.c:1029: warning: Function parameter or member 'unsafe' not described in '__console_update_unsafe'


vim +1029 kernel/printk/printk_nobkl.c

  1010	
  1011	/**
  1012	 * __console_update_unsafe - Update the unsafe bit in @con->atomic_state
  1013	 * @wctxt:	The write context that was handed to the write function
  1014	 *
  1015	 * Returns:	True if the state is correct. False if a handover
  1016	 *		has been requested or if the console was taken
  1017	 *		over.
  1018	 *
  1019	 * Must be invoked before an unsafe driver section is entered.
  1020	 *
  1021	 * When this function returns false then the calling context is not allowed
  1022	 * to go forward and has to back out immediately and carefully. The buffer
  1023	 * content is no longer trusted either and the console lock is no longer
  1024	 * held.
  1025	 *
  1026	 * Internal helper to avoid duplicated code
  1027	 */
  1028	static bool __console_update_unsafe(struct cons_write_context *wctxt, bool unsafe)
> 1029	{
  1030		struct cons_context *ctxt = &ACCESS_PRIVATE(wctxt, ctxt);
  1031		struct console *con = ctxt->console;
  1032		struct cons_state new;
  1033	
  1034		do  {
  1035			if (!console_can_proceed(wctxt))
  1036				return false;
  1037			/*
  1038			 * console_can_proceed() saved the real state in
  1039			 * ctxt->old_state
  1040			 */
  1041			copy_full_state(new, ctxt->old_state);
  1042			new.unsafe = unsafe;
  1043	
  1044		} while (!cons_state_try_cmpxchg(con, CON_STATE_CUR, &ctxt->old_state, &new));
  1045	
  1046		copy_full_state(ctxt->state, new);
  1047		return true;
  1048	}
  1049	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-08-17  6:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308171313.el16bGIc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=john.ogness@linutronix.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.