All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: SSunk <ssunkkan@gmail.com>
Cc: tudor.ambarus@linaro.org, pratyush@kernel.org, michael@walle.cc,
	richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for more XMC series
Date: Thu, 17 Aug 2023 15:20:50 +0200	[thread overview]
Message-ID: <20230817152050.6679eae3@xps-13> (raw)
In-Reply-To: <20230817124655.13023-1-ssunkkan@gmail.com>

Hello,

ssunkkan@gmail.com wrote on Thu, 17 Aug 2023 20:46:55 +0800:

> Add XMC XM25QH128C/XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C
> and set the parse_sfdp flag.

Please look at the git history and correct the title.

> Signed-off-by: Kankan Sun <ssunkkan@gmail.com>
> ---
>  drivers/mtd/spi-nor/xmc.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/xmc.c b/drivers/mtd/spi-nor/xmc.c
> index 051411e86339..b2374187ec4f 100644
> --- a/drivers/mtd/spi-nor/xmc.c
> +++ b/drivers/mtd/spi-nor/xmc.c
> @@ -16,6 +16,22 @@ static const struct flash_info xmc_nor_parts[] = {
>  	{ "XM25QH128A", INFO(0x207018, 0, 64 * 1024, 256)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>  			      SPI_NOR_QUAD_READ) },
> +	{ "XM25QH128C", INFO(0x204018, 0, 64 * 1024, 256)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ) },
> +	{ "XM25QH256C", INFO(0x204019, 0, 64 * 1024, 512)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> +	{ "XM25QU256C", INFO(0x204119, 0, 64 * 1024, 512)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> +	{ "XM25QH512C", INFO(0x204020, 0, 64 * 1024, 1024)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> +	{ "XM25QU512C", INFO(0x204120, 0, 64 * 1024, 1024)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

You say you enable SFDP in the commit log but the diff shows the
opposite?

> +
>  };
>  
>  const struct spi_nor_manufacturer spi_nor_xmc = {


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2023-08-17 13:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 12:46 [PATCH] Add support for more XMC series SSunk
2023-08-17 13:14 ` Michael Walle
2023-08-17 13:20 ` Miquel Raynal [this message]
2023-08-17 17:03   ` SSunk
2023-08-17 17:10     ` Michael Walle
2023-08-17 17:17       ` Clus Tom
2023-08-29  4:56         ` SSunk
2023-08-29  6:48           ` Michael Walle
2023-08-31  4:13             ` SSunk
2023-08-31  6:41               ` Michael Walle
     [not found] <20230812030731.3711-1-ssunkkan@gmail.com>
2023-12-06 12:33 ` Jagan Teki
     [not found] <20230812031846.3958-1-ssunkkan@gmail.com>
     [not found] ` <CAPnjgZ1Z6pKEif5HKFLcG0AQJL1qrqy9j78TjvuhpsOUzS7JGQ@mail.gmail.com>
     [not found]   ` <CABjXDjHOpcM=JtCe2SGzwQ+GbQT7cg8xQxFbthPqW3KXaJ1P3Q@mail.gmail.com>
2023-08-14 22:42     ` Simon Glass
2023-08-15  2:46       ` Clus Tom
2023-08-31  4:07         ` SSunk
2023-08-31  5:48         ` SSunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817152050.6679eae3@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=ssunkkan@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.