All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Cheng Xu <chengyou@linux.alibaba.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, KaiShen@linux.alibaba.com
Subject: Re: [PATCH for-next 2/3] RDMA/erdma: Refactor the storage structure of MTT entries
Date: Thu, 17 Aug 2023 20:07:35 +0300	[thread overview]
Message-ID: <20230817170735.GP22185@unreal> (raw)
In-Reply-To: <20230817102151.75964-3-chengyou@linux.alibaba.com>

On Thu, Aug 17, 2023 at 06:21:50PM +0800, Cheng Xu wrote:
> Currently our MTT only support inline mtt entries (0 level MTT) and
> indirect MTT entries (1 level mtt), which will limit the maximum length
> of MRs. In order to implement a multi-level MTT, we refactor the
> structure of MTT first.
> 
> Signed-off-by: Cheng Xu <chengyou@linux.alibaba.com>
> ---
>  drivers/infiniband/hw/erdma/erdma_hw.h    |   4 +-
>  drivers/infiniband/hw/erdma/erdma_qp.c    |   2 +-
>  drivers/infiniband/hw/erdma/erdma_verbs.c | 214 +++++++++++++---------
>  drivers/infiniband/hw/erdma/erdma_verbs.h |  26 ++-
>  4 files changed, 152 insertions(+), 94 deletions(-)

<...>

> +/* Hierarchical storage structure for MTT entries */
> +struct erdma_mtt {
> +	u64 *buf;
> +	size_t size;
> +
> +	bool continuous;
> +	union {
> +		dma_addr_t buf_dma;
> +		struct {
> +			struct scatterlist *sglist;
> +			u32 nsg;
> +			u32 level;
> +		};
> +	};
> +
> +	struct erdma_mtt *low_level;

This variable is used in third patch only, but please don't resubmit yet.

Thanks

  reply	other threads:[~2023-08-17 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 10:21 [PATCH for-next 0/3] RDMA/erdma: Add hierachical MTT support Cheng Xu
2023-08-17 10:21 ` [PATCH for-next 1/3] RDMA/erdma: Renaming variable names and field names of struct erdma_mem Cheng Xu
2023-08-17 10:21 ` [PATCH for-next 2/3] RDMA/erdma: Refactor the storage structure of MTT entries Cheng Xu
2023-08-17 17:07   ` Leon Romanovsky [this message]
2023-08-17 10:21 ` [PATCH for-next 3/3] RDMA/erdma: Implement hierachical MTT Cheng Xu
2023-08-19 11:42 ` [PATCH for-next 0/3] RDMA/erdma: Add hierachical MTT support Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817170735.GP22185@unreal \
    --to=leon@kernel.org \
    --cc=KaiShen@linux.alibaba.com \
    --cc=chengyou@linux.alibaba.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.