All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [intel-tdx:guest-kexec 4/7] drivers/firmware/efi/efi.c:643: warning: Function parameter or member 'unaccepted' not described in 'reserve_unaccepted'
Date: Thu, 17 Aug 2023 20:45:24 +0800	[thread overview]
Message-ID: <202308172004.ONqNOmsa-lkp@intel.com> (raw)

tree:   https://github.com/intel/tdx.git guest-kexec
head:   c3817f480d1101b9c14987e84b6b3abc70c67a2d
commit: 61db94f763a6bf583ab264342115605ee8e33173 [4/7] efi: Make sure unaccepted table is mapped in crashkernel case
config: riscv-randconfig-r036-20230817 (https://download.01.org/0day-ci/archive/20230817/202308172004.ONqNOmsa-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172004.ONqNOmsa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308172004.ONqNOmsa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/efi/efi.c:643: warning: Function parameter or member 'unaccepted' not described in 'reserve_unaccepted'


vim +643 drivers/firmware/efi/efi.c

   625	
   626	/**
   627	 * reserve_unaccepted - Map and reserve unaccepted configuration table
   628	 *
   629	 * memblock_add() makes sure that the table is mapped in direct mapping. During
   630	 * normal boot it happens automatically because the table is allocated from
   631	 * usable memory. But during crashkernel boot only memory specifically
   632	 * reserved for crash scenario is mapped. memblock_add() forces the table to be
   633	 * mapped in crashkernel case.
   634	 *
   635	 * Align the range to the nearest page boarders. Ranges smaller than page size
   636	 * are not going to be mapped.
   637	 *
   638	 * memblock_reserve() makes sure that future allocations will not touch the
   639	 * table.
   640	 */
   641	
   642	static __init void reserve_unaccepted(struct efi_unaccepted_memory *unaccepted)
 > 643	{
   644		phys_addr_t start, size;
   645	
   646		start = PAGE_ALIGN_DOWN(efi.unaccepted);
   647		size = PAGE_ALIGN(sizeof(*unaccepted) + unaccepted->size);
   648	
   649		memblock_add(start, size);
   650		memblock_reserve(start, size);
   651	}
   652	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-08-17 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 12:45 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-08-17 11:30 [intel-tdx:guest-kexec 4/7] drivers/firmware/efi/efi.c:643: warning: Function parameter or member 'unaccepted' not described in 'reserve_unaccepted' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308172004.ONqNOmsa-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.