All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Kees Cook <keescook@chromium.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, llvm@lists.linux.dev,
	linux-hardening@vger.kernel.org
Subject: [PATCH 0/7] wifi: cfg80211: Annotate with __counted_by
Date: Thu, 17 Aug 2023 14:15:22 -0700	[thread overview]
Message-ID: <20230817211114.never.208-kees@kernel.org> (raw)

Hi,

This annotates several structures with the coming __counted_by attribute
for bounds checking of flexible arrays at run-time. As a note toward
applicability, had this mitigation been available already, the flaw
fixed in commit 6311071a0562 ("wifi: nl80211: fix integer overflow in
nl80211_parse_mbssid_elems()") would have already been unexploitable
(i.e. writes through an out-of-bounds index would have been blocked).

Thanks!

-Kees

Kees Cook (7):
  wifi: cfg80211: Annotate struct cfg80211_acl_data with __counted_by
  wifi: cfg80211: Annotate struct cfg80211_cqm_config with __counted_by
  wifi: cfg80211: Annotate struct cfg80211_mbssid_elems with
    __counted_by
  wifi: cfg80211: Annotate struct cfg80211_pmsr_request with
    __counted_by
  wifi: cfg80211: Annotate struct cfg80211_rnr_elems with __counted_by
  wifi: cfg80211: Annotate struct cfg80211_scan_request with
    __counted_by
  wifi: cfg80211: Annotate struct cfg80211_tid_config with __counted_by

 include/net/cfg80211.h | 12 ++++++------
 net/wireless/core.h    |  2 +-
 net/wireless/nl80211.c |  7 +++----
 net/wireless/pmsr.c    |  3 +--
 4 files changed, 11 insertions(+), 13 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-08-17 21:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 21:15 Kees Cook [this message]
2023-08-17 21:15 ` [PATCH 1/7] wifi: cfg80211: Annotate struct cfg80211_acl_data with __counted_by Kees Cook
2023-08-17 21:21   ` Justin Stitt
2023-08-17 21:23   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson
2023-08-17 21:15 ` [PATCH 2/7] wifi: cfg80211: Annotate struct cfg80211_cqm_config " Kees Cook
2023-08-17 21:23   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson
2023-08-17 21:15 ` [PATCH 3/7] wifi: cfg80211: Annotate struct cfg80211_mbssid_elems " Kees Cook
2023-08-17 21:24   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson
2023-08-17 21:15 ` [PATCH 4/7] wifi: cfg80211: Annotate struct cfg80211_pmsr_request " Kees Cook
2023-08-17 21:24   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson
2023-08-17 21:15 ` [PATCH 5/7] wifi: cfg80211: Annotate struct cfg80211_rnr_elems " Kees Cook
2023-08-17 21:24   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson
2023-08-17 21:15 ` [PATCH 6/7] wifi: cfg80211: Annotate struct cfg80211_scan_request " Kees Cook
2023-08-17 21:24   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson
2023-08-17 21:15 ` [PATCH 7/7] wifi: cfg80211: Annotate struct cfg80211_tid_config " Kees Cook
2023-08-17 21:24   ` Gustavo A. R. Silva
2023-08-17 22:03   ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817211114.never.208-kees@kernel.org \
    --to=keescook@chromium.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.