From: Michael Schmitz <schmitzmic@gmail.com>
To: s.shtylyov@omp.ru, linux-ide@vger.kernel.org, linux-m68k@vger.kernel.org
Cc: will@sowerbutts.com, rz@linux-m68k.org, geert@linux-m68k.org
Subject: [PATCH 0/3] Q40 IDE fixes
Date: Fri, 18 Aug 2023 10:12:29 +1200 [thread overview]
Message-ID: <20230817221232.22035-1-schmitzmic@gmail.com> (raw)
The pata_falcon IDE driver for m68k Q40 has been broken since Q40
was converted to use pata_falcon in preparation for removal of the
legacy IDE core in v5.14. A bug has only recently been reported.
This patch series to fix the bug has seen some discussion and review
on linux-m68k in the past week. It's also been tested on both Q40
and Atari.
The bug reporter has since found that he can use pata_legacy for
his Q40, but that is solely due to his disk written in the default
IDE byte order. Other users of Q40 will have data on disk in
big-endian order, and will have to use the pata_falcon driver
which does not attempt byte swapping to host byte order in its
data_xfer() function.
Patch 1 fixes the bug introduced in v5.14. That one ought not
to be controversial (I hope).
Patch 2 adds a module parameter to select drives to have byte
swapping to host byte order applied (useful for connecting drives
in IDE default byte order to Q40 and Atari for interoperability).
Patch 3 changes the Atari Falcon IDE platform device to use a
device ID compatible with the byte swapping scheme. This patch
should go through the m68k tree, not IDE.
Feedback welcome!
Cheers,
Michael
next reply other threads:[~2023-08-17 22:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 22:12 Michael Schmitz [this message]
2023-08-17 22:12 ` [PATCH 1/3] m68k/q40: fix IO base selection for Q40 in pata_falcon.c Michael Schmitz
2023-08-18 0:42 ` Damien Le Moal
2023-08-18 2:53 ` Michael Schmitz
2023-08-18 5:33 ` Finn Thain
2023-08-19 20:29 ` Sergey Shtylyov
2023-08-20 19:19 ` Michael Schmitz
2023-08-21 7:46 ` Michael Schmitz
2023-08-17 22:12 ` [PATCH 2/3] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data Michael Schmitz
2023-08-18 0:51 ` Damien Le Moal
2023-08-18 3:08 ` Michael Schmitz
2023-08-18 3:15 ` Damien Le Moal
2023-08-18 4:01 ` Michael Schmitz
2023-08-20 18:07 ` Sergey Shtylyov
2023-08-20 19:27 ` Michael Schmitz
2023-08-22 19:10 ` Sergei Shtylyov
2023-08-22 19:44 ` Sergei Shtylyov
2023-08-22 20:21 ` Michael Schmitz
2023-08-17 22:12 ` [PATCH 3/3] m68k/atari: change Falcon IDE platform device to id 0 Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817221232.22035-1-schmitzmic@gmail.com \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rz@linux-m68k.org \
--cc=s.shtylyov@omp.ru \
--cc=will@sowerbutts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.