From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.oasis-open.org>, <hengqi@linux.alibaba.com>,
<david.edmondson@oracle.com>, <xuanzhuo@linux.alibaba.com>,
<sburla@marvell.com>
Cc: <shahafs@nvidia.com>, <virtio@lists.oasis-open.org>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH requirements v5 1/7] net-features: Add requirements document for release 1.4
Date: Fri, 18 Aug 2023 07:35:51 +0300 [thread overview]
Message-ID: <20230818043557.496964-2-parav@nvidia.com> (raw)
In-Reply-To: <20230818043557.496964-1-parav@nvidia.com>
Add requirements document template for the virtio net features.
Add virtio net device counters visible to driver.
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v4->v5:
- Fixed attributes query and counters query
v3->v4:
- Addressed comment from David
- Added link to more counters that we are already discussing
v0->v1:
- removed tx dropped counter
- updated requirements to mention about virtqueue interface for counters
query
---
net-workstream/features-1.4.md | 41 ++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 net-workstream/features-1.4.md
diff --git a/net-workstream/features-1.4.md b/net-workstream/features-1.4.md
new file mode 100644
index 0000000..ea36f09
--- /dev/null
+++ b/net-workstream/features-1.4.md
@@ -0,0 +1,41 @@
+# 1. Introduction
+
+This document describes the overall requirements for virtio net device
+improvements for upcoming release 1.4. Some of these requirements are
+interrelated and influence the interface design, hence reviewing them
+together is desired while updating the virtio net interface.
+
+# 2. Summary
+1. Device counters visible to the driver
+
+# 3. Requirements
+## 3.1 Device counters
+1. The driver should be able to query the device and/or per vq counters for
+ debugging purpose using a virtqueue directly from driver to device for
+ example using a control vq.
+2. The driver should be able to query which counters are supported using a
+ virtqueue command, for example using an existing control vq.
+3. If this device is migrated between two hosts, the driver should be able
+ get the counter values in the destination host from where it was left
+ off in the source host.
+4. If a virtio device is a group member device, it must be possible to query
+ all of the group member counters via the group owner device.
+5. If a virtio device is a group member device, it must be possible to query
+ all of the group member counter attributes via the group owner device.
+
+### 3.1.1 Per receive queue counters
+1. le64 rx_oversize_pkt_errors: Packet dropped due to receive packet being
+ oversize than the buffer size
+2. le64 rx_no_buffer_pkt_errors: Packet dropped due to unavailability of the
+ buffer in the receive queue
+3. le64 rx_gso_pkts: Packets treated as receive GSO sequence by the device
+4. le64 rx_pkts: Total packets received by the device
+
+### 3.1.2 Per transmit queue counters
+1. le64 tx_gso_pkts: Packets send as transmit GSO sequence
+2. le64 tx_pkts: Total packets send by the device
+
+### 3.1.3 More counters
+More counters discussed in [1].
+
+[1] https://lists.oasis-open.org/archives/virtio-comment/202308/msg00176.html
--
2.26.2
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-08-18 4:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 4:35 [virtio-comment] [PATCH requirements v5 0/7] virtio net requirements for 1.4 Parav Pandit
2023-08-18 4:35 ` Parav Pandit [this message]
2023-08-21 10:44 ` [virtio-comment] [PATCH requirements v5 1/7] net-features: Add requirements document for release 1.4 David Edmondson
2023-08-18 4:35 ` [virtio-comment] [PATCH requirements v5 2/7] net-features: Add low latency transmit queue requirements Parav Pandit
2023-08-18 4:35 ` [virtio-comment] [PATCH requirements v5 3/7] net-features: Add low latency receive " Parav Pandit
2023-08-21 10:47 ` [virtio-comment] " David Edmondson
2023-08-22 6:12 ` [virtio-comment] " Parav Pandit
2023-09-11 13:47 ` [virtio-comment] Re: [virtio] " Stefan Hajnoczi
2023-09-11 16:03 ` [virtio-comment] " Parav Pandit
2023-08-18 4:35 ` [virtio-comment] [PATCH requirements v5 4/7] net-features: Add notification coalescing requirements Parav Pandit
2023-08-18 4:35 ` [virtio-comment] [PATCH requirements v5 5/7] net-features: Add n-tuple receive flow filters requirements Parav Pandit
2023-08-21 5:06 ` [virtio-comment] " Heng Qi
2023-08-21 5:14 ` [virtio-comment] " Parav Pandit
2023-08-22 7:41 ` Parav Pandit
2023-08-18 4:35 ` [virtio-comment] [PATCH requirements v5 6/7] net-features: Add packet timestamp requirements Parav Pandit
2023-08-18 4:35 ` [virtio-comment] [PATCH requirements v5 7/7] net-features: Add header data split requirements Parav Pandit
2023-08-21 10:45 ` [virtio-comment] " David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818043557.496964-2-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=david.edmondson@oracle.com \
--cc=hengqi@linux.alibaba.com \
--cc=sburla@marvell.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.