All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: oe-kbuild-all@lists.linux.dev,
	Christian Brauner <christianvanbrauner@gmail.com>,
	Christian Brauner <brauner@kernel.org>,
	Josef Bacik <josef@toxicpanda.com>
Subject: [brauner-vfs:vfs.super_wait 35/49] block/disk-events.c:302: warning: Excess function parameter 'events' description in 'disk_force_media_change'
Date: Fri, 18 Aug 2023 05:56:33 +0800	[thread overview]
Message-ID: <202308180521.aoCedovs-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.super_wait
head:   32fa790ce40b4c73b40079070061718e5540bfe9
commit: de76e11e14ec9c1a731f51632e822b859eb736b5 [35/49] block: simplify the disk_force_media_change interface
config: microblaze-randconfig-r032-20230817 (https://download.01.org/0day-ci/archive/20230818/202308180521.aoCedovs-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308180521.aoCedovs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308180521.aoCedovs-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/disk-events.c:302: warning: Excess function parameter 'events' description in 'disk_force_media_change'


vim +302 block/disk-events.c

d5870edfa3afc4 Christoph Hellwig  2021-06-24  291  
e6138dc12de9df Matteo Croce       2021-07-13  292  /**
e6138dc12de9df Matteo Croce       2021-07-13  293   * disk_force_media_change - force a media change event
e6138dc12de9df Matteo Croce       2021-07-13  294   * @disk: the disk which will raise the event
e6138dc12de9df Matteo Croce       2021-07-13  295   * @events: the events to raise
e6138dc12de9df Matteo Croce       2021-07-13  296   *
de76e11e14ec9c Christoph Hellwig  2023-08-11  297   * Should be called when the media changes for @disk.  Generates a uevent
de76e11e14ec9c Christoph Hellwig  2023-08-11  298   * and attempts to free all dentries and inodes and invalidates all block
e6138dc12de9df Matteo Croce       2021-07-13  299   * device page cache entries in that case.
e6138dc12de9df Matteo Croce       2021-07-13  300   */
de76e11e14ec9c Christoph Hellwig  2023-08-11  301  void disk_force_media_change(struct gendisk *disk)
e6138dc12de9df Matteo Croce       2021-07-13 @302  {
de76e11e14ec9c Christoph Hellwig  2023-08-11  303  	disk_event_uevent(disk, DISK_EVENT_MEDIA_CHANGE);
b90ecc0379eb7b Demi Marie Obenour 2023-06-07  304  	inc_diskseq(disk);
e6138dc12de9df Matteo Croce       2021-07-13  305  	if (__invalidate_device(disk->part0, true))
e6138dc12de9df Matteo Croce       2021-07-13  306  		pr_warn("VFS: busy inodes on changed media %s\n",
e6138dc12de9df Matteo Croce       2021-07-13  307  			disk->disk_name);
e6138dc12de9df Matteo Croce       2021-07-13  308  	set_bit(GD_NEED_PART_SCAN, &disk->state);
e6138dc12de9df Matteo Croce       2021-07-13  309  }
e6138dc12de9df Matteo Croce       2021-07-13  310  EXPORT_SYMBOL_GPL(disk_force_media_change);
e6138dc12de9df Matteo Croce       2021-07-13  311  

:::::: The code at line 302 was first introduced by commit
:::::: e6138dc12de9df17cbda9c40314d69592855ac5e block: add a helper to raise a media changed event

:::::: TO: Matteo Croce <mcroce@microsoft.com>
:::::: CC: Jens Axboe <axboe@kernel.dk>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-08-17 21:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308180521.aoCedovs-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=brauner@kernel.org \
    --cc=christianvanbrauner@gmail.com \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.