From: Geliang Tang <geliang.tang@suse.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v3 5/6] Squash to "bpf: Export more bpf_burst related functions"
Date: Fri, 18 Aug 2023 16:39:31 +0800 [thread overview]
Message-ID: <20230818083931.GA21065@bogon> (raw)
In-Reply-To: <b2f50040-0373-4e5e-b4d1-f94c40e2f2b6@tessares.net>
On Wed, Aug 16, 2023 at 01:55:01PM +0200, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 03/08/2023 06:27, Geliang Tang wrote:
> > Add "ignore -Wmissing-prototypes" for bpf_mptcp_subflow_queues_empty(),
> > drop the declarations in protocol.h.
> >
> > Drop bpf_mptcp_subflow_memory_free(), it will be defined in BPF context.
> >
> > Update bpf_mptcp_subflow_queues_empty().
>
> I also had to partially revert this commit.
>
> Maybe "__bpf_kfunc" would avoid such issues reported by Sparse?
>
> #define __bpf_kfunc __used noinline
>
> Do you mind looking at that please?
Hi Matt,
"__bpf_kfunc" doesn't work. I have to ask BPF maintainers what to do for
this and hope to receive their response.
Thanks,
-Geliang
>
> New patches for t/upstream:
> - 11ace9718934: mptcp: partially revert "Squash to "bpf: Export more
> bpf_burst related functions""
> - Results: d30c287ad522..dd7fb06cb618 (export)
>
> Tests are now in progress:
>
> https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230816T115317
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
next prev parent reply other threads:[~2023-08-18 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 4:27 [PATCH mptcp-next v3 0/6] BPF packet scheduler updates part 3 Geliang Tang
2023-08-03 4:27 ` [PATCH mptcp-next v3 1/6] Squash to "mptcp: add sched_data helpers" Geliang Tang
2023-08-16 10:47 ` Matthieu Baerts
2023-08-03 4:27 ` [PATCH mptcp-next v3 2/6] Squash to "bpf: Add bpf_mptcp_sched_kfunc_set" Geliang Tang
2023-08-03 4:27 ` [PATCH mptcp-next v3 3/6] Squash to "selftests/bpf: add two mptcp netns helpers" Geliang Tang
2023-08-03 4:27 ` [PATCH mptcp-next v3 4/6] Squash to "selftests/bpf: Add bpf_rr scheduler" Geliang Tang
2023-08-03 4:27 ` [PATCH mptcp-next v3 5/6] Squash to "bpf: Export more bpf_burst related functions" Geliang Tang
2023-08-16 11:55 ` Matthieu Baerts
2023-08-18 8:39 ` Geliang Tang [this message]
2023-08-18 9:04 ` Matthieu Baerts
2023-08-03 4:27 ` [PATCH mptcp-next v3 6/6] Squash to "selftests/bpf: Add bpf_burst scheduler" Geliang Tang
2023-08-03 4:53 ` Squash to "selftests/bpf: Add bpf_burst scheduler": Build Failure MPTCP CI
2023-08-03 5:31 ` Squash to "selftests/bpf: Add bpf_burst scheduler": Tests Results MPTCP CI
2023-08-08 15:41 ` [PATCH mptcp-next v3 0/6] BPF packet scheduler updates part 3 Mat Martineau
2023-08-11 20:59 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818083931.GA21065@bogon \
--to=geliang.tang@suse.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.