All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 01/14] jobstats: change jobstats_abort to jobstats_cancel
Date: Fri, 18 Aug 2023 09:10:51 -0700	[thread overview]
Message-ID: <20230818091051.3f2b95d1@hermes.local> (raw)
In-Reply-To: <ZN81KkDBIPy3Zzpw@bricha3-MOBL.ger.corp.intel.com>

On Fri, 18 Aug 2023 10:08:58 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Thu, Aug 17, 2023 at 07:52:36PM -0700, Stephen Hemminger wrote:
> > The term abort is on the "Replace now" list of words.
> > Use cancel instead.
> >   
> I see cancel generally being used as a replacement throughout this
> patchset, but I wonder if the use of th term could be confusing as it
> doesn't strictly match the term "abort" at least to my mind.
> 
> When an operation is aborted, (to me anyway) it generally means that the
> operation is just stopped at whatever point it is at, and nothing more is
> done. However, when an operation is cancelled, that would imply to me that
> the operation is not only stopped, but whatever tasks were already done by
> that operation are undone. Would others share this understanding? If so, we
> should make the rollback/no-rollback behaviour clear.
> 
> /Bruce

It seemed like the best of the alternatives proposed here: 
https://inclusivenaming.org/word-lists/tier-1/abort/

Recommended Replacements
	User-Initiated Termination
	Force quit
	Cancel
	System-Initiated Termination
	Fail
	Close (app, program, connection)
	End
	Halt
	Hard stop
	Stop (something you triggered)

I don't think the rollback semantics are implied by either word.
They should be spelled out more though.


  reply	other threads:[~2023-08-18 16:10 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  2:52 [PATCH 00/14] remove use of term abort Stephen Hemminger
2023-08-18  2:52 ` [PATCH 01/14] jobstats: change jobstats_abort to jobstats_cancel Stephen Hemminger
2023-08-18  9:08   ` Bruce Richardson
2023-08-18 16:10     ` Stephen Hemminger [this message]
2023-08-18  2:52 ` [PATCH 02/14] all: remove use of word abort Stephen Hemminger
2023-08-18  4:04   ` Honnappa Nagarahalli
2023-08-18  2:52 ` [PATCH 03/14] pipeline: remove use of term abort Stephen Hemminger
2023-08-18  2:52 ` [PATCH 04/14] net/vmxnet3: replace abort() with rte_panic() Stephen Hemminger
2023-08-18  2:52 ` [PATCH 05/14] event/dlb2: remove word abort in comments Stephen Hemminger
2023-08-18  2:52 ` [PATCH 06/14] net/vdev_netvsc: replace use of term abort Stephen Hemminger
2023-08-18  2:52 ` [PATCH 07/14] net/netvsc: replace abort with cancel Stephen Hemminger
2023-08-18  2:52 ` [PATCH 08/14] net/ionic: remove word aborting Stephen Hemminger
2023-08-18  2:52 ` [PATCH 09/14] net/bnx2x: replace abort with cancel Stephen Hemminger
2023-08-18  2:52 ` [PATCH 10/14] net/mlx5: " Stephen Hemminger
2023-08-18  2:52 ` [PATCH 11/14] net/softnic: " Stephen Hemminger
2023-08-18  2:52 ` [PATCH 12/14] net/mlx4: remove word abort Stephen Hemminger
2023-08-18  2:52 ` [PATCH 13/14] sfc: remove use of term abort Stephen Hemminger
2023-08-18  2:52 ` [PATCH 14/14] net/axgbe: replace word abort Stephen Hemminger
2023-08-18 17:45 ` [PATCH v2 00/13] Replace us of term abort Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 01/13] jobstats: change jobstats_abort to jobstats_cancel Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 02/13] all: remove use of word abort Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 03/13] pipeline: remove use of term abort Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 04/13] net/vmxnet3: replace abort() with rte_panic() Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 05/13] event/dlb2: remove word abort in comments Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 06/13] net/vdev_netvsc: replace use of term abort Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 07/13] net/netvsc: replace abort with cancel Stephen Hemminger
2023-08-18 22:26     ` Long Li
2023-08-18 17:45   ` [PATCH v2 08/13] net/ionic: remove word aborting Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 09/13] net/bnx2x: replace abort with cancel Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 10/13] net/mlx5: " Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 11/13] net/softnic: " Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 12/13] net/mlx4: remove word abort Stephen Hemminger
2023-08-18 17:45   ` [PATCH v2 13/13] net/axgbe: replace " Stephen Hemminger
2023-08-30 16:49   ` [PATCH v2 00/13] Replace us of term abort Thomas Monjalon
2023-09-06 19:39     ` Stephen Hemminger
2023-09-06 21:19       ` Thomas Monjalon
2023-09-06 23:03         ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818091051.3f2b95d1@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.