All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Pavel Zhukov <pavel@zhukoff.net>
Cc: aplanas@suse.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] bitbake.conf: add bunzip2 in HOSTTOOLS
Date: Fri, 18 Aug 2023 11:56:38 +0200	[thread overview]
Message-ID: <2023081809563803d02330@mail.local> (raw)
In-Reply-To: <2e707be5-5139-4e2c-a967-ff258d69eaec@app.fastmail.com>

Hi Pavel,

On 18/08/2023 11:39:12+0200, Pavel Zhukov wrote:
> Hi Alberto,
> Looks like the regression has been  introduced in  previous update. This patch https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=eb3ec7469fff857c819332371ad1d586f43c79c3 (which was reverted by https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=3aba44a75dd565b192f7328f2a0150a313de3cc1 )  solved the issue without bringing bunzip to every system
> 

I guess you should submit the oe-core patch again and maybe it would be
a good idea to get it upstream.

> -- 
> Pavel
> 
> On Fri, Aug 18, 2023, at 11:30, Alberto Planas via lists.openembedded.org wrote:
> > From: Alberto Planas <aplanas@suse.com>
> > 
> > rpm2cpio.sh can make calls to bunzip2 to uncompress the RPM payload that
> > conform the cpio file.
> > 
> > bzip2 is already part of HOSTTOOLS, as a link to the system installed
> > bzip2.
> > 
> > This patch add bunzip2 in HOSTOOLS list as a non-optional binary, so is
> > available to rpm2cpio.sh when it is required.
> > 
> > The currect rpm2cpio.sh has other calls to gunzip (present in HOSTOOLS),
> > xzcat (missing), unlzma (missing) and unzstd (present in HOSTTOOLS since
> > bff58d337890e804d33d7decbaa46065a4d3bba4)
> > 
> > Adding the missing ones will not add any new host dependency as xz-utils
> > is already listed as a requirement.
> > 
> > Signed-off-by: Alberto Planas <aplanas@suse.com>
> > ---
> > meta/conf/bitbake.conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 599bbc4ba8..b19f265b3d 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -516,7 +516,7 @@ HOSTTOOLS_DIR = "${TMPDIR}/hosttools"
> >  
> > # Tools needed to run builds with OE-Core
> > HOSTTOOLS += " \
> > -    [ ar as awk basename bash bzip2 cat chgrp chmod chown chrpath cmp comm cp cpio \
> > +    [ ar as awk basename bash bunzip2 bzip2 cat chgrp chmod chown chrpath cmp comm cp cpio \
> >      cpp cut date dd diff diffstat dirname du echo egrep env expand expr false \
> >      fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
> >      head hostname iconv id install ld ldd ln ls lz4c make md5sum mkdir mkfifo mknod \
> > -- 
> > 2.41.0
> > 
> > 
> > 
> > 
> > 
> > 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#186354): https://lists.openembedded.org/g/openembedded-core/message/186354
> Mute This Topic: https://lists.openembedded.org/mt/100817328/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2023-08-18  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  9:30 [PATCH] bitbake.conf: add bunzip2 in HOSTTOOLS aplanas
2023-08-18  9:39 ` [OE-core] " Pavel Zhukov
2023-08-18  9:56   ` Alexandre Belloni [this message]
2023-08-18 10:36   ` Alberto Planas Dominguez
2023-08-30  8:08 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023081809563803d02330@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=aplanas@suse.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pavel@zhukoff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.