From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Simon Horman <horms@kernel.org>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next v2 13/15] ice: ice_aq_check_events: fix off-by-one check when filling buffer
Date: Fri, 18 Aug 2023 21:51:43 +0300 [thread overview]
Message-ID: <20230818185143.GE22185@unreal> (raw)
In-Reply-To: <20230817212239.2601543-14-anthony.l.nguyen@intel.com>
On Thu, Aug 17, 2023 at 02:22:37PM -0700, Tony Nguyen wrote:
> From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> Allow task's event buffer to be filled also in the case that it's size
> is exactly the size of the message.
>
> Fixes: d69ea414c9b4 ("ice: implement device flash update via devlink")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-08-18 18:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 21:22 [PATCH net-next v2 00/15][pull request] Intel Wired LAN Driver Updates 2023-08-17 (ice) Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 01/15] ice: remove unused methods Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 02/15] ice: refactor ice_ddp to make functions static Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 03/15] ice: refactor ice_lib " Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 04/15] ice: refactor ice_vf_lib " Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 05/15] ice: Utilize assign_bit() helper Tony Nguyen
2023-08-18 18:51 ` Leon Romanovsky
2023-08-17 21:22 ` [PATCH net-next v2 06/15] ice: refactor ice_sched to make functions static Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 07/15] ice: refactor ice_ptp_hw " Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 08/15] ice: refactor ice_vsi_is_vlan_pruning_ena Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 09/15] ice: move E810T functions to before device agnostic ones Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 10/15] ice: Remove redundant VSI configuration in eswitch setup Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 11/15] ice: use list_for_each_entry() helper Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 12/15] ice: drop two params from ice_aq_alloc_free_res() Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 13/15] ice: ice_aq_check_events: fix off-by-one check when filling buffer Tony Nguyen
2023-08-18 18:51 ` Leon Romanovsky [this message]
2023-08-17 21:22 ` [PATCH net-next v2 14/15] ice: embed &ice_rq_event_info event into struct ice_aq_task Tony Nguyen
2023-08-17 21:22 ` [PATCH net-next v2 15/15] ice: split ice_aq_wait_for_event() func into two Tony Nguyen
2023-08-19 2:20 ` [PATCH net-next v2 00/15][pull request] Intel Wired LAN Driver Updates 2023-08-17 (ice) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818185143.GE22185@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.